mbox series

[v3,0/4] crypto: qat - fixes to aes xts

Message ID 20200629171620.2989-1-giovanni.cabiddu@intel.com
Headers show
Series crypto: qat - fixes to aes xts | expand

Message

Cabiddu, Giovanni June 29, 2020, 5:16 p.m. UTC
This series fixes a few issues with the xts(aes) implementation in the
QuickAssist driver:
 - Requests that are not multiple of the block size are rejected
 - Input key not validated
 - xts(aes) requests with key size 192 bits are rejected with -EINVAL

Changes from v2:
 - Patch #4 - removed CRYPTO_ALG_ASYNC flag from mask in the allocation
   of the fallback tfm to allow asynchronous implementations as fallback.
 - Patch #4 - added CRYPTO_ALG_NEED_FALLBACK flag as mask when allocating
   fallback tfm to avoid implementations that require fallback.
 - Reworked commit messages to have system logs in one line.

Changes from v1:
 - Removed extra pair of parenthesis around PTR_ERR in patch #4 (crypto:
   qat - allow xts requests not multiple of block)

Giovanni Cabiddu (4):
  crypto: qat - allow xts requests not multiple of block
  crypto: qat - validate xts key
  crypto: qat - remove unused field in skcipher ctx
  crypto: qat - fallback for xts with 192 bit keys

 drivers/crypto/qat/qat_common/qat_algs.c | 98 ++++++++++++++++++++++--
 1 file changed, 90 insertions(+), 8 deletions(-)

Comments

Herbert Xu July 9, 2020, 12:53 p.m. UTC | #1
On Mon, Jun 29, 2020 at 06:16:16PM +0100, Giovanni Cabiddu wrote:
> This series fixes a few issues with the xts(aes) implementation in the

> QuickAssist driver:

>  - Requests that are not multiple of the block size are rejected

>  - Input key not validated

>  - xts(aes) requests with key size 192 bits are rejected with -EINVAL

> 

> Changes from v2:

>  - Patch #4 - removed CRYPTO_ALG_ASYNC flag from mask in the allocation

>    of the fallback tfm to allow asynchronous implementations as fallback.

>  - Patch #4 - added CRYPTO_ALG_NEED_FALLBACK flag as mask when allocating

>    fallback tfm to avoid implementations that require fallback.

>  - Reworked commit messages to have system logs in one line.

> 

> Changes from v1:

>  - Removed extra pair of parenthesis around PTR_ERR in patch #4 (crypto:

>    qat - allow xts requests not multiple of block)

> 

> Giovanni Cabiddu (4):

>   crypto: qat - allow xts requests not multiple of block

>   crypto: qat - validate xts key

>   crypto: qat - remove unused field in skcipher ctx

>   crypto: qat - fallback for xts with 192 bit keys

> 

>  drivers/crypto/qat/qat_common/qat_algs.c | 98 ++++++++++++++++++++++--

>  1 file changed, 90 insertions(+), 8 deletions(-)


All applied.  Thanks.
-- 
Email: Herbert Xu <herbert@gondor.apana.org.au>
Home Page: http://gondor.apana.org.au/~herbert/
PGP Key: http://gondor.apana.org.au/~herbert/pubkey.txt