| Message ID | 20200415084758.2.Ic98f6622c60a1aa547ed85781f2c3b9d3e56b734@changeid |
|---|---|
| State | New |
| Headers | show |
| Series | None | expand |
Quoting Douglas Anderson (2020-04-15 08:48:40) > Allow people to specify to use a GPIO for hot-plug-detect. Add an > example. > > NOTE: The current patch adding support for hpd-gpios to the Linux > driver for hpd-gpios only adds enough support to the driver so that > the bridge can use one of its own GPIOs. The bindings, however, are > written generically. > > Signed-off-by: Douglas Anderson <dianders@chromium.org> > --- > > .../bindings/display/bridge/ti,sn65dsi86.yaml | 10 +++++++++- > 1 file changed, 9 insertions(+), 1 deletion(-) > > diff --git a/Documentation/devicetree/bindings/display/bridge/ti,sn65dsi86.yaml b/Documentation/devicetree/bindings/display/bridge/ti,sn65dsi86.yaml > index 8cacc6db33a9..554bfd003000 100644 > --- a/Documentation/devicetree/bindings/display/bridge/ti,sn65dsi86.yaml > +++ b/Documentation/devicetree/bindings/display/bridge/ti,sn65dsi86.yaml > @@ -60,6 +60,10 @@ properties: > const: 1 > description: See ../../pwm/pwm.yaml for description of the cell formats. > > + hpd-gpios: > + maxItems: 1 > + description: If present use the given GPIO for hot-plug-detect. Shouldn't this go in the panel node? And the panel driver should get the gpio and poll it after powering up the panel? Presumably that's why we have the no-hpd property in the simple panel binding vs. putting it here in the bridge.
diff --git a/Documentation/devicetree/bindings/display/bridge/ti,sn65dsi86.yaml b/Documentation/devicetree/bindings/display/bridge/ti,sn65dsi86.yaml index 8cacc6db33a9..554bfd003000 100644 --- a/Documentation/devicetree/bindings/display/bridge/ti,sn65dsi86.yaml +++ b/Documentation/devicetree/bindings/display/bridge/ti,sn65dsi86.yaml @@ -60,6 +60,10 @@ properties: const: 1 description: See ../../pwm/pwm.yaml for description of the cell formats. + hpd-gpios: + maxItems: 1 + description: If present use the given GPIO for hot-plug-detect. + data-lanes: description: See ../../media/video-interface.txt @@ -148,7 +152,7 @@ examples: #address-cells = <1>; #size-cells = <0>; - bridge@2d { + sn65dsi86_bridge: bridge@2d { compatible = "ti,sn65dsi86"; reg = <0x2d>; @@ -165,6 +169,10 @@ examples: clocks = <&rpmhcc RPMH_LN_BB_CLK2>; clock-names = "refclk"; + gpio-controller; + #gpio-cells = <2>; + hpd-gpios = <&sn65dsi86_bridge 2 GPIO_ACTIVE_HIGH>; + ports { #address-cells = <1>; #size-cells = <0>;
Allow people to specify to use a GPIO for hot-plug-detect. Add an example. NOTE: The current patch adding support for hpd-gpios to the Linux driver for hpd-gpios only adds enough support to the driver so that the bridge can use one of its own GPIOs. The bindings, however, are written generically. Signed-off-by: Douglas Anderson <dianders@chromium.org> --- .../bindings/display/bridge/ti,sn65dsi86.yaml | 10 +++++++++- 1 file changed, 9 insertions(+), 1 deletion(-)