| Message ID | 1591440907-20021-1-git-send-email-sivaprak@codeaurora.org |
|---|---|
| Headers | show |
| Series | Add APSS clock controller support for IPQ6018 | expand |
Ping! Hi Stephen, Is it possible for you to review this series? We have regulators and few other patches depend on this patch, it would be great if you could provide your inputs on this. Thanks, Siva On 6/6/2020 4:25 PM, Sivaprakash Murugesan wrote: > The CPU on Qualcomm's IPQ6018 devices are primarily fed by APSS PLL and XO, > these are connected to a clock mux and enable block. > > This patch series adds support for these clocks and inturn enables clocks > required for CPU freq. > > [V7] > * Removed dts patch from this series, will send that separately > * Addressed Rob's minor comment on the binding > * Patch 1 depends on a53 pll bindings > https://lkml.org/lkml/2020/5/4/60 > [V6] > * Split mailbox driver from this series, mailbox changes will sent as a > separate series > * Addressed review comments from Stephen > [V5] > * Addressed Bjorn comments on apss clk and dt-bindings > * Patch 2 depends on a53 pll dt-bindings > https://www.spinics.net/lists/linux-clk/msg48358.html > [V4] > * Re-written PLL found on IPQ platforms as a separate driver > * Addressed stephen's comments on apss clock controller and pll > * Addressed Rob's review comments on bindings > * moved a53 pll binding from this series as it is not applicable, will send > it separately. > [V3] > * Fixed dt binding check error in patch2 > dt-bindings: clock: Add YAML schemas for QCOM A53 PLL > [V2] > * Restructred the patch series as there are two different HW blocks, > the mux and enable belongs to the apcs block and PLL has a separate HW > block. > * Converted qcom mailbox and qcom a53 pll documentation to yaml. > * Addressed review comments from Stephen, Rob and Sibi where it is applicable. > * Changed this cover letter to state the purpose of this patch series > > Sivaprakash Murugesan (4): > dt-bindings: clock: add ipq6018 a53 pll compatible > clk: qcom: Add ipq apss pll driver > clk: qcom: Add DT bindings for ipq6018 apss clock controller > clk: qcom: Add ipq6018 apss clock controller > > .../devicetree/bindings/clock/qcom,a53pll.yaml | 18 ++++ > drivers/clk/qcom/Kconfig | 19 ++++ > drivers/clk/qcom/Makefile | 2 + > drivers/clk/qcom/apss-ipq-pll.c | 95 ++++++++++++++++++ > drivers/clk/qcom/apss-ipq6018.c | 106 +++++++++++++++++++++ > include/dt-bindings/clock/qcom,apss-ipq.h | 12 +++ > 6 files changed, 252 insertions(+) > create mode 100644 drivers/clk/qcom/apss-ipq-pll.c > create mode 100644 drivers/clk/qcom/apss-ipq6018.c > create mode 100644 include/dt-bindings/clock/qcom,apss-ipq.h >
Quoting Sivaprakash Murugesan (2020-06-18 00:00:58) > Ping! > > Hi Stephen, > > Is it possible for you to review this series? We have regulators and few > other patches regulators depend on CPU clk patches? > > depend on this patch, it would be great if you could provide your inputs > on this. >
On 6/20/2020 6:06 AM, Stephen Boyd wrote: > Quoting Sivaprakash Murugesan (2020-06-06 03:55:04) >> cpus on ipq6018 are clocked by a53 pll, add device compatible for a53 >> pll found on ipq6018 devices. >> >> Signed-off-by: Sivaprakash Murugesan <sivaprak@codeaurora.org> >> --- >> [V7] >> * Addressed minor review comment from Rob >> .../devicetree/bindings/clock/qcom,a53pll.yaml | 18 ++++++++++++++++++ >> 1 file changed, 18 insertions(+) >> >> diff --git a/Documentation/devicetree/bindings/clock/qcom,a53pll.yaml b/Documentation/devicetree/bindings/clock/qcom,a53pll.yaml >> index 20d2638..3161fab 100644 >> --- a/Documentation/devicetree/bindings/clock/qcom,a53pll.yaml >> +++ b/Documentation/devicetree/bindings/clock/qcom,a53pll.yaml >> @@ -15,6 +15,7 @@ description: >> >> properties: >> compatible: >> + const: qcom,ipq6018-a53pll >> const: qcom,msm8916-a53pll >> >> reg: > I'm getting this error when running dt binding check: > > ruamel.yaml.constructor.DuplicateKeyError: while constructing a mapping > in "<unicode string>", line 18, column 5 > found duplicate key "const" with value "qcom,msm8916-a53pll" (original value: "qcom,ipq6018-a53pll") > in "<unicode string>", line 19, column 5 This error started coming after updating the dt-schema version. Guess I need to replace const with enum to get rid of this error. will address this.