mbox series

[PULL,0/4] softfloat patch queue

Message ID 20200515184722.31182-1-richard.henderson@linaro.org
Headers show
Series softfloat patch queue | expand

Message

Richard Henderson May 15, 2020, 6:47 p.m. UTC 
I got distracted this week and never posted my follow-on
patches.  So flush the queue now and I'll post the other
patches for review soon.


r~


The following changes since commit 66706192de113c82ecf849f6943878c453b5d2ba:

  Merge remote-tracking branch 'remotes/stsquad/tags/pull-testing-tcg-plugins-150520-2' into staging (2020-05-15 15:47:47 +0100)

are available in the Git repository at:

  https://github.com/rth7680/qemu.git tags/pull-fpu-20200515

for you to fetch changes up to 9ecaf5ccec13ff2e8fe1e72f6e0f3367d2169c1c:

  softfloat: fix floatx80 pseudo-denormal round to integer (2020-05-15 11:04:50 -0700)

----------------------------------------------------------------
floatx80 x87 pseudo-denormal fixes

----------------------------------------------------------------
Joseph Myers (4):
      softfloat: silence sNaN for conversions to/from floatx80
      softfloat: fix floatx80 pseudo-denormal addition / subtraction
      softfloat: fix floatx80 pseudo-denormal comparisons
      softfloat: fix floatx80 pseudo-denormal round to integer

 fpu/softfloat.c                            | 39 ++++++++++++++----
 tests/tcg/i386/test-i386-pseudo-denormal.c | 38 ++++++++++++++++++
 tests/tcg/i386/test-i386-snan-convert.c    | 63 ++++++++++++++++++++++++++++++
 3 files changed, 133 insertions(+), 7 deletions(-)
 create mode 100644 tests/tcg/i386/test-i386-pseudo-denormal.c
 create mode 100644 tests/tcg/i386/test-i386-snan-convert.c

Comments

Peter Maydell May 15, 2020, 9:31 p.m. UTC | #1 
On Fri, 15 May 2020 at 19:47, Richard Henderson
<richard.henderson@linaro.org> wrote:
>

> I got distracted this week and never posted my follow-on

> patches.  So flush the queue now and I'll post the other

> patches for review soon.

>

>

> r~

>

>

> The following changes since commit 66706192de113c82ecf849f6943878c453b5d2ba:

>

>   Merge remote-tracking branch 'remotes/stsquad/tags/pull-testing-tcg-plugins-150520-2' into staging (2020-05-15 15:47:47 +0100)

>

> are available in the Git repository at:

>

>   https://github.com/rth7680/qemu.git tags/pull-fpu-20200515

>

> for you to fetch changes up to 9ecaf5ccec13ff2e8fe1e72f6e0f3367d2169c1c:

>

>   softfloat: fix floatx80 pseudo-denormal round to integer (2020-05-15 11:04:50 -0700)

>

> ----------------------------------------------------------------

> floatx80 x87 pseudo-denormal fixes

>



Applied, thanks.

Please update the changelog at https://wiki.qemu.org/ChangeLog/5.1
for any user-visible changes.

-- PMM
no-reply@patchew.org May 16, 2020, 5:46 a.m. UTC | #2 
Patchew URL: https://patchew.org/QEMU/20200515184722.31182-1-richard.henderson@linaro.org/



Hi,

This series seems to have some coding style problems. See output below for
more information:

Message-id: 20200515184722.31182-1-richard.henderson@linaro.org
Subject: [PULL 0/4] softfloat patch queue
Type: series

=== TEST SCRIPT BEGIN ===
#!/bin/bash
git rev-parse base > /dev/null || exit 0
git config --local diff.renamelimit 0
git config --local diff.renames True
git config --local diff.algorithm histogram
./scripts/checkpatch.pl --mailback base..
=== TEST SCRIPT END ===

Updating 3c8cf5a9c21ff8782164d1def7f44bd888713384
From https://github.com/patchew-project/qemu
 - [tag update]      patchew/20200515190153.6017-1-richard.henderson@linaro.org -> patchew/20200515190153.6017-1-richard.henderson@linaro.org
Switched to a new branch 'test'
36efd04 softfloat: fix floatx80 pseudo-denormal round to integer
4c2e880 softfloat: fix floatx80 pseudo-denormal comparisons
013fb4d softfloat: fix floatx80 pseudo-denormal addition / subtraction
f1a96f5 softfloat: silence sNaN for conversions to/from floatx80

=== OUTPUT BEGIN ===
1/4 Checking commit f1a96f5122b8 (softfloat: silence sNaN for conversions to/from floatx80)
WARNING: added, moved or deleted file(s), does MAINTAINERS need updating?
#88: 
new file mode 100644

ERROR: Use of volatile is usually wrong, please add a comment
#98: FILE: tests/tcg/i386/test-i386-snan-convert.c:6:
+volatile float f_res;

ERROR: Use of volatile is usually wrong, please add a comment
#99: FILE: tests/tcg/i386/test-i386-snan-convert.c:7:
+volatile double d_res;

ERROR: Use of volatile is usually wrong, please add a comment
#100: FILE: tests/tcg/i386/test-i386-snan-convert.c:8:
+volatile long double ld_res;

ERROR: Use of volatile is usually wrong, please add a comment
#102: FILE: tests/tcg/i386/test-i386-snan-convert.c:10:
+volatile float f_snan = __builtin_nansf("");

ERROR: Use of volatile is usually wrong, please add a comment
#103: FILE: tests/tcg/i386/test-i386-snan-convert.c:11:
+volatile double d_snan = __builtin_nans("");

ERROR: Use of volatile is usually wrong, please add a comment
#104: FILE: tests/tcg/i386/test-i386-snan-convert.c:12:
+volatile long double ld_snan = __builtin_nansl("");

total: 6 errors, 1 warnings, 123 lines checked

Patch 1/4 has style problems, please review.  If any of these errors
are false positives report them to the maintainer, see
CHECKPATCH in MAINTAINERS.

2/4 Checking commit 013fb4df5f1b (softfloat: fix floatx80 pseudo-denormal addition / subtraction)
WARNING: Block comments use a leading /* on a separate line
#29: FILE: fpu/softfloat.c:5870:
+                /* At least one of the values is a pseudo-denormal,

WARNING: Block comments use a trailing */ on a separate line
#30: FILE: fpu/softfloat.c:5871:
+                 * and there is a carry out of the result.  */

WARNING: added, moved or deleted file(s), does MAINTAINERS need updating?
#38: 
new file mode 100644

ERROR: Use of volatile is usually wrong, please add a comment
#53: FILE: tests/tcg/i386/test-i386-pseudo-denormal.c:11:
+volatile union u ld_pseudo_m16382 = { .s = { UINT64_C(1) << 63, 0 } };

ERROR: Use of volatile is usually wrong, please add a comment
#55: FILE: tests/tcg/i386/test-i386-pseudo-denormal.c:13:
+volatile long double ld_res;

ERROR: spaces required around that '-' (ctx:VxV)
#61: FILE: tests/tcg/i386/test-i386-pseudo-denormal.c:19:
+    if (ld_res != 0x1p-16381L) {
                       ^

total: 3 errors, 3 warnings, 36 lines checked

Patch 2/4 has style problems, please review.  If any of these errors
are false positives report them to the maintainer, see
CHECKPATCH in MAINTAINERS.

3/4 Checking commit 4c2e8807fd1f (softfloat: fix floatx80 pseudo-denormal comparisons)
ERROR: spaces required around that '-' (ctx:VxV)
#43: FILE: tests/tcg/i386/test-i386-pseudo-denormal.c:23:
+    if (ld_pseudo_m16382.ld != 0x1p-16382L) {
                                    ^

total: 1 errors, 0 warnings, 22 lines checked

Patch 3/4 has style problems, please review.  If any of these errors
are false positives report them to the maintainer, see
CHECKPATCH in MAINTAINERS.

4/4 Checking commit 36efd04e9c7b (softfloat: fix floatx80 pseudo-denormal round to integer)
ERROR: space prohibited after that open parenthesis '('
#29: FILE: fpu/softfloat.c:5744:
+             && ( (uint64_t) ( extractFloatx80Frac( a ) ) == 0 ) ) {

ERROR: space prohibited before that close parenthesis ')'
#29: FILE: fpu/softfloat.c:5744:
+             && ( (uint64_t) ( extractFloatx80Frac( a ) ) == 0 ) ) {

total: 2 errors, 0 warnings, 29 lines checked

Patch 4/4 has style problems, please review.  If any of these errors
are false positives report them to the maintainer, see
CHECKPATCH in MAINTAINERS.

=== OUTPUT END ===

Test command exited with code: 1


The full log is available at
http://patchew.org/logs/20200515184722.31182-1-richard.henderson@linaro.org/testing.checkpatch/?type=message.
---
Email generated automatically by Patchew [https://patchew.org/].
Please send your feedback to patchew-devel@redhat.com