diff mbox series

[v5,02/19] exec: Fix cpu_watchpoint_address_matches address length

Message ID 20200508154359.7494-3-richard.henderson@linaro.org
State Superseded
Headers show
Series target/arm: sve load/store improvements | expand

Commit Message

Richard Henderson May 8, 2020, 3:43 p.m. UTC 
The only caller of cpu_watchpoint_address_matches passes
TARGET_PAGE_SIZE, so the bug is not currently visible.

Reviewed-by: Peter Maydell <peter.maydell@linaro.org>

Signed-off-by: Richard Henderson <richard.henderson@linaro.org>

---
 exec.c | 2 +-
 1 file changed, 1 insertion(+), 1 deletion(-)

-- 
2.20.1

Comments

Philippe Mathieu-Daudé May 9, 2020, 11:59 a.m. UTC | #1 
On 5/8/20 5:43 PM, Richard Henderson wrote:
> The only caller of cpu_watchpoint_address_matches passes

> TARGET_PAGE_SIZE, so the bug is not currently visible.

> 

> Reviewed-by: Peter Maydell <peter.maydell@linaro.org>

> Signed-off-by: Richard Henderson <richard.henderson@linaro.org>

> ---

>   exec.c | 2 +-

>   1 file changed, 1 insertion(+), 1 deletion(-)

> 

> diff --git a/exec.c b/exec.c

> index 2874bb5088..5162f0d12f 100644

> --- a/exec.c

> +++ b/exec.c

> @@ -1127,7 +1127,7 @@ int cpu_watchpoint_address_matches(CPUState *cpu, vaddr addr, vaddr len)

>       int ret = 0;

>   

>       QTAILQ_FOREACH(wp, &cpu->watchpoints, entry) {

> -        if (watchpoint_address_matches(wp, addr, TARGET_PAGE_SIZE)) {

> +        if (watchpoint_address_matches(wp, addr, len)) {

>               ret |= wp->flags;

>           }

>       }

> 


Reviewed-by: Philippe Mathieu-Daudé <f4bug@amsat.org>
diff mbox series

Patch

diff --git a/exec.c b/exec.c
index 2874bb5088..5162f0d12f 100644
--- a/exec.c
+++ b/exec.c
@@ -1127,7 +1127,7 @@  int cpu_watchpoint_address_matches(CPUState *cpu, vaddr addr, vaddr len)
     int ret = 0;
 
     QTAILQ_FOREACH(wp, &cpu->watchpoints, entry) {
-        if (watchpoint_address_matches(wp, addr, TARGET_PAGE_SIZE)) {
+        if (watchpoint_address_matches(wp, addr, len)) {
             ret |= wp->flags;
         }
     }