| Message ID | 1571254641-13626-1-git-send-email-thara.gopinath@linaro.org |
|---|---|
| Headers | show |
| Series | Introduce Power domain based warming device driver | expand |
On 12/03/2019 12:04 PM, Amit Kucheria wrote: > On Thu, Oct 17, 2019 at 1:07 AM Thara Gopinath > <thara.gopinath@linaro.org> wrote: >> >> Add a hook in thermal_cooling_device_ops to be called after >> the cooling device has been initialized and registered >> but before binding it to a thermal zone. >> >> In this patch series it is used to hook up a power domain >> to the device pointer of cooling device. >> >> It can be used for any other relevant late initializations >> of a cooling device as well. > > Please describe WHY this hook is needed. Hi Amit, Thanks for the review. This patch is no longer relevant. I had posted a v4 of this series based on other review comments[1] 1. https://lkml.org/lkml/2019/11/20/355 -- Warm Regards Thara
Certain resources modeled as a generic power domain in linux kernel can be used to warm up the SoC (mx power domain on sdm845) if the temperature falls below certain threshold. These power domains can be considered as thermal warming devices. (opposite of thermal cooling devices). In kernel, these warming devices can be modeled as a thermal cooling device. Since linux kernel today has no instance of a resource modeled as a power domain acting as a thermal warming device, a generic power domain based thermal warming device driver that can be used pan-Socs is the approach taken in this patch series. Since thermal warming devices can be thought of as the mirror opposite of thermal cooling devices, this patch series re-uses thermal cooling device framework. To use these power domains as warming devices require further tweaks in the thermal framework which are out of scope of this patch series. These tweaks have been posted as a separate series[1]. The first patch in this series extends the genpd framework to export out the performance states of a power domain so that when a power domain is modeled as a cooling device, the number of possible states and current state of the cooling device can be retrieved from the genpd framework. The second patch implements the newly added genpd callback for Qualcomm RPMH power domain driver which hosts the mx power domain. The third patch introduces late init ops for thermal cooling device that is called after the cooling device is created and registered but before binding it to a thermal zone for specific initializations. The fourth patch introduces the generic power domain warming device driver. The fifth patch extends Qualcomm RPMh power controller driver to register mx power domain as a thermal warming device in the kernel. The sixth patch describes the dt binding extensions for mx power domain to be a thermal warming device. The seventh patch introduces the DT entreis for sdm845 to register mx power domain as a thermal warming device. v1->v2: - Rename the patch series from "qcom: Model RPMH power domains as thermal cooling devices" to "Introduce Power domain based thermal warming devices" as it is more appropriate. - Introduce a new patch(patch 3) describing the dt-bindings for generic power domain warming device. - Patch specific changes mentioned in respective patches. v2->v3: - Changed power domain warming device from a virtual device node entry in DT to being a subnode of power domain controller binding following Rob's review comments. - Implemented Ulf's review comments. - The changes above introduced two new patches (patch 3 and 4) 1. https://lkml.org/lkml/2019/9/18/1180 Thara Gopinath (7): PM/Domains: Add support for retrieving genpd performance states information soc: qcom: rpmhpd: Introduce function to retrieve power domain performance state count thermal: core: Add late init hook to cooling device ops thermal: Add generic power domain warming device driver. soc: qcom: Extend RPMh power controller driver to register warming devices. dt-bindings: soc: qcom: Extend RPMh power controller binding to describe thermal warming device arm64: dts: qcom: Add mx power domain as thermal warming device. .../devicetree/bindings/power/qcom,rpmpd.txt | 10 ++ arch/arm64/boot/dts/qcom/sdm845.dtsi | 5 + drivers/base/power/domain.c | 37 ++++++ drivers/soc/qcom/rpmhpd.c | 30 ++++- drivers/thermal/Kconfig | 10 ++ drivers/thermal/Makefile | 2 + drivers/thermal/pwr_domain_warming.c | 136 +++++++++++++++++++++ drivers/thermal/thermal_core.c | 13 ++ include/linux/pm_domain.h | 13 ++ include/linux/pwr_domain_warming.h | 31 +++++ include/linux/thermal.h | 1 + 11 files changed, 287 insertions(+), 1 deletion(-) create mode 100644 drivers/thermal/pwr_domain_warming.c create mode 100644 include/linux/pwr_domain_warming.h -- 2.1.4