| Message ID | 20191114133023.32185-1-dmurphy@ti.com |
|---|---|
| Headers | show |
| Series | Multicolor Framework | expand |
On 14/11/2019 14:30, Dan Murphy wrote: > Hello > > Simple fix in the multicolor code where the extended registration call was not > called in the devm_* function > > Thanks Martin F. for finding this issue. > > Hopefully this will be pulled in for the 5.5 merge window. For patches 2, 3, 4 Tested-by: Martin Fuzzey <martin.fuzzey@flowbird.group> I have applied patch 1 to my tree too but, being just documentation, it's not testable. I don't have a lp50xx but have written my own multicolor driver on top of this patchset (for a custom LED controller implemented in a MCU). Martin
On Thu, Nov 14, 2019 at 07:30:14AM -0600, Dan Murphy wrote: > Add the reg property to each channel node. This update is > to accomodate the multicolor framework. In addition to the > accomodation this allows the LEDs to be placed on any channel > and allow designs to skip channels as opposed to requiring > sequential order. > > Signed-off-by: Dan Murphy <dmurphy@ti.com> > CC: Shawn Guo <shawnguo@kernel.org> > CC: Sascha Hauer <s.hauer@pengutronix.de> > CC: Pengutronix Kernel Team <kernel@pengutronix.de> > CC: Fabio Estevam <festevam@gmail.com> > CC: NXP Linux Team <linux-imx@nxp.com> > --- > arch/arm/boot/dts/imx6dl-yapp4-common.dtsi | 14 ++++++++++---- > 1 file changed, 10 insertions(+), 4 deletions(-) > > diff --git a/arch/arm/boot/dts/imx6dl-yapp4-common.dtsi b/arch/arm/boot/dts/imx6dl-yapp4-common.dtsi > index e8d800fec637..efc466ed1fea 100644 > --- a/arch/arm/boot/dts/imx6dl-yapp4-common.dtsi > +++ b/arch/arm/boot/dts/imx6dl-yapp4-common.dtsi > @@ -257,29 +257,35 @@ > reg = <0x30>; > clock-mode = /bits/ 8 <1>; > status = "disabled"; > + #address-cells = <1>; > + #size-cells = <0>; > > - chan0 { > + chan@0 { Again, why do not we rename it to led@0 as you update the bindings in the last patch in the series? Shawn > chan-name = "R"; > led-cur = /bits/ 8 <0x20>; > max-cur = /bits/ 8 <0x60>; > + reg = <0>; > }; > > - chan1 { > + chan@1 { > chan-name = "G"; > led-cur = /bits/ 8 <0x20>; > max-cur = /bits/ 8 <0x60>; > + reg = <1>; > }; > > - chan2 { > + chan@2 { > chan-name = "B"; > led-cur = /bits/ 8 <0x20>; > max-cur = /bits/ 8 <0x60>; > + reg = <2>; > }; > > - chan3 { > + chan@3 { > chan-name = "W"; > led-cur = /bits/ 8 <0x0>; > max-cur = /bits/ 8 <0x0>; > + reg = <3>; > }; > }; > > -- > 2.22.0.214.g8dca754b1e >
Shawn On 12/2/19 3:06 AM, Shawn Guo wrote: > On Thu, Nov 14, 2019 at 07:30:14AM -0600, Dan Murphy wrote: >> Add the reg property to each channel node. This update is >> to accomodate the multicolor framework. In addition to the >> accomodation this allows the LEDs to be placed on any channel >> and allow designs to skip channels as opposed to requiring >> sequential order. >> >> Signed-off-by: Dan Murphy <dmurphy@ti.com> >> CC: Shawn Guo <shawnguo@kernel.org> >> CC: Sascha Hauer <s.hauer@pengutronix.de> >> CC: Pengutronix Kernel Team <kernel@pengutronix.de> >> CC: Fabio Estevam <festevam@gmail.com> >> CC: NXP Linux Team <linux-imx@nxp.com> >> --- >> arch/arm/boot/dts/imx6dl-yapp4-common.dtsi | 14 ++++++++++---- >> 1 file changed, 10 insertions(+), 4 deletions(-) >> >> diff --git a/arch/arm/boot/dts/imx6dl-yapp4-common.dtsi b/arch/arm/boot/dts/imx6dl-yapp4-common.dtsi >> index e8d800fec637..efc466ed1fea 100644 >> --- a/arch/arm/boot/dts/imx6dl-yapp4-common.dtsi >> +++ b/arch/arm/boot/dts/imx6dl-yapp4-common.dtsi >> @@ -257,29 +257,35 @@ >> reg = <0x30>; >> clock-mode = /bits/ 8 <1>; >> status = "disabled"; >> + #address-cells = <1>; >> + #size-cells = <0>; >> >> - chan0 { >> + chan@0 { > Again, why do not we rename it to led@0 as you update the bindings in > the last patch in the series? I am trying to limit the amount of change in this patchset. I know what you are asking is for a small change but that would be another patch to the series to the label. I want to keep functional changes like this isolated from clean up changes like you asked for bissectability. From that point we can make additional changes. I would really like this to get into 5.6 as I thought I hit the merge window for 5.5 but it did not make it. Dan
Pavel On 11/14/19 7:30 AM, Dan Murphy wrote: > Hello > > Simple fix in the multicolor code where the extended registration call was not > called in the devm_* function > > Thanks Martin F. for finding this issue. > > Hopefully this will be pulled in for the 5.5 merge window. > > Dan > > Dan Murphy (19): > dt: bindings: Add multicolor class dt bindings documention > dt-bindings: leds: Add multicolor ID to the color ID list > leds: Add multicolor ID to the color ID list > leds: multicolor: Introduce a multicolor class definition > dt: bindings: lp50xx: Introduce the lp50xx family of RGB drivers > leds: lp50xx: Add the LP50XX family of the RGB LED driver > dt: bindings: lp55xx: Be consistent in the document with LED acronym > dt: bindings: lp55xx: Update binding for Multicolor Framework > ARM: dts: n900: Add reg property to the LP5523 channel node > ARM: dts: imx6dl-yapp4: Add reg property to the lp5562 channel node > ARM: dts: ste-href: Add reg property to the LP5521 channel nodes > leds: lp55xx: Convert LED class registration to devm_* > leds: lp55xx: Add multicolor framework support to lp55xx > leds: lp5523: Update the lp5523 code to add multicolor brightness > function > leds: lp5521: Add multicolor framework multicolor brightness support > leds: lp55xx: Fix checkpatch file permissions issues > leds: lp5523: Fix checkpatch issues in the code > dt: bindings: Update lp55xx binding to recommended LED naming > leds: lp55xx-common: Remove extern from lp55xx-common header Are these going to be pulled in for 5.6? I need to post the changes requested by Shawn on the DT but would like to do it against the leds-next tree. Dan
Hello Bump for application to leds-next Dan On 11/14/19 7:30 AM, Dan Murphy wrote: > Hello > > Simple fix in the multicolor code where the extended registration call was not > called in the devm_* function > > Thanks Martin F. for finding this issue. > > Hopefully this will be pulled in for the 5.5 merge window. > > Dan > > Dan Murphy (19): > dt: bindings: Add multicolor class dt bindings documention > dt-bindings: leds: Add multicolor ID to the color ID list > leds: Add multicolor ID to the color ID list > leds: multicolor: Introduce a multicolor class definition > dt: bindings: lp50xx: Introduce the lp50xx family of RGB drivers > leds: lp50xx: Add the LP50XX family of the RGB LED driver > dt: bindings: lp55xx: Be consistent in the document with LED acronym > dt: bindings: lp55xx: Update binding for Multicolor Framework > ARM: dts: n900: Add reg property to the LP5523 channel node > ARM: dts: imx6dl-yapp4: Add reg property to the lp5562 channel node > ARM: dts: ste-href: Add reg property to the LP5521 channel nodes > leds: lp55xx: Convert LED class registration to devm_* > leds: lp55xx: Add multicolor framework support to lp55xx > leds: lp5523: Update the lp5523 code to add multicolor brightness > function > leds: lp5521: Add multicolor framework multicolor brightness support > leds: lp55xx: Fix checkpatch file permissions issues > leds: lp5523: Fix checkpatch issues in the code > dt: bindings: Update lp55xx binding to recommended LED naming > leds: lp55xx-common: Remove extern from lp55xx-common header > > .../ABI/testing/sysfs-class-led-multicolor | 36 + > .../bindings/leds/leds-class-multicolor.txt | 98 +++ > .../devicetree/bindings/leds/leds-lp50xx.txt | 148 ++++ > .../devicetree/bindings/leds/leds-lp55xx.txt | 163 +++- > Documentation/leds/index.rst | 1 + > Documentation/leds/leds-class-multicolor.rst | 100 +++ > arch/arm/boot/dts/imx6dl-yapp4-common.dtsi | 14 +- > arch/arm/boot/dts/omap3-n900.dts | 29 +- > arch/arm/boot/dts/ste-href.dtsi | 22 +- > drivers/leds/Kconfig | 22 + > drivers/leds/Makefile | 2 + > drivers/leds/led-class-multicolor.c | 272 ++++++ > drivers/leds/led-core.c | 1 + > drivers/leds/leds-lp50xx.c | 799 ++++++++++++++++++ > drivers/leds/leds-lp5521.c | 43 +- > drivers/leds/leds-lp5523.c | 62 +- > drivers/leds/leds-lp5562.c | 22 +- > drivers/leds/leds-lp55xx-common.c | 235 ++++-- > drivers/leds/leds-lp55xx-common.h | 36 +- > drivers/leds/leds-lp8501.c | 23 +- > include/dt-bindings/leds/common.h | 3 +- > include/linux/led-class-multicolor.h | 139 +++ > include/linux/platform_data/leds-lp55xx.h | 8 + > 23 files changed, 2106 insertions(+), 172 deletions(-) > create mode 100644 Documentation/ABI/testing/sysfs-class-led-multicolor > create mode 100644 Documentation/devicetree/bindings/leds/leds-class-multicolor.txt > create mode 100644 Documentation/devicetree/bindings/leds/leds-lp50xx.txt > create mode 100644 Documentation/leds/leds-class-multicolor.rst > create mode 100644 drivers/leds/led-class-multicolor.c > create mode 100644 drivers/leds/leds-lp50xx.c > create mode 100644 include/linux/led-class-multicolor.h >
On Thu 2019-11-14 07:30:15, Dan Murphy wrote: > Add the reg property to each channel node. This update is > to accomodate the multicolor framework. In addition to the > accomodation this allows the LEDs to be placed on any channel > and allow designs to skip channels as opposed to requiring > sequential order. > > Signed-off-by: Dan Murphy <dmurphy@ti.com> > CC: Linus Walleij <linus.walleij@linaro.org> Acked-by: Pavel Machek <pavel@ucw.cz> -- (english) http://www.livejournal.com/~pavelmachek (cesky, pictures) http://atrey.karlin.mff.cuni.cz/~pavel/picture/horses/blog.html
On Thu 2019-11-14 07:30:16, Dan Murphy wrote: > Convert the LED class registration calls to the LED devm_* > registration calls. > > Signed-off-by: Dan Murphy <dmurphy@ti.com> Nothing obviously wrong here. Was it tested? Acked-by: Pavel Machek <pavel@ucw.cz> Best regards, Pavel -- (english) http://www.livejournal.com/~pavelmachek (cesky, pictures) http://atrey.karlin.mff.cuni.cz/~pavel/picture/horses/blog.html
On Thu 2019-11-14 07:30:20, Dan Murphy wrote: > Fix the checkpatch warnings for the use of the file permission macros. > In converting the file permissions to the DEVICE_ATTR_XX macros the > call back function names needed to be updated within the code. > > This means that the lp55xx_ needed to be dropped in the name to keep in > harmony with the ABI documentation. > > Signed-off-by: Dan Murphy <dmurphy@ti.com> Acked-by: Pavel Machek <pavel@ucw.cz> -- (english) http://www.livejournal.com/~pavelmachek (cesky, pictures) http://atrey.karlin.mff.cuni.cz/~pavel/picture/horses/blog.html
Hello Do you have a time frame in applying this patch set? Dan On 12/18/19 8:45 AM, Dan Murphy wrote: > Hello > > Bump for application to leds-next > > Dan > > On 11/14/19 7:30 AM, Dan Murphy wrote: >> Hello >>
On 1/8/20 2:48 PM, Dan Murphy wrote: > Hello > > Do you have a time frame in applying this patch set? I am afraid we're not waiting just for applying but for Pavel's opinion on the most crucial parts of this patch set... > On 12/18/19 8:45 AM, Dan Murphy wrote: >> Hello >> >> Bump for application to leds-next >> >> Dan >> >> On 11/14/19 7:30 AM, Dan Murphy wrote: >>> Hello >>>
Hello Simple fix in the multicolor code where the extended registration call was not called in the devm_* function Thanks Martin F. for finding this issue. Hopefully this will be pulled in for the 5.5 merge window. Dan Dan Murphy (19): dt: bindings: Add multicolor class dt bindings documention dt-bindings: leds: Add multicolor ID to the color ID list leds: Add multicolor ID to the color ID list leds: multicolor: Introduce a multicolor class definition dt: bindings: lp50xx: Introduce the lp50xx family of RGB drivers leds: lp50xx: Add the LP50XX family of the RGB LED driver dt: bindings: lp55xx: Be consistent in the document with LED acronym dt: bindings: lp55xx: Update binding for Multicolor Framework ARM: dts: n900: Add reg property to the LP5523 channel node ARM: dts: imx6dl-yapp4: Add reg property to the lp5562 channel node ARM: dts: ste-href: Add reg property to the LP5521 channel nodes leds: lp55xx: Convert LED class registration to devm_* leds: lp55xx: Add multicolor framework support to lp55xx leds: lp5523: Update the lp5523 code to add multicolor brightness function leds: lp5521: Add multicolor framework multicolor brightness support leds: lp55xx: Fix checkpatch file permissions issues leds: lp5523: Fix checkpatch issues in the code dt: bindings: Update lp55xx binding to recommended LED naming leds: lp55xx-common: Remove extern from lp55xx-common header .../ABI/testing/sysfs-class-led-multicolor | 36 + .../bindings/leds/leds-class-multicolor.txt | 98 +++ .../devicetree/bindings/leds/leds-lp50xx.txt | 148 ++++ .../devicetree/bindings/leds/leds-lp55xx.txt | 163 +++- Documentation/leds/index.rst | 1 + Documentation/leds/leds-class-multicolor.rst | 100 +++ arch/arm/boot/dts/imx6dl-yapp4-common.dtsi | 14 +- arch/arm/boot/dts/omap3-n900.dts | 29 +- arch/arm/boot/dts/ste-href.dtsi | 22 +- drivers/leds/Kconfig | 22 + drivers/leds/Makefile | 2 + drivers/leds/led-class-multicolor.c | 272 ++++++ drivers/leds/led-core.c | 1 + drivers/leds/leds-lp50xx.c | 799 ++++++++++++++++++ drivers/leds/leds-lp5521.c | 43 +- drivers/leds/leds-lp5523.c | 62 +- drivers/leds/leds-lp5562.c | 22 +- drivers/leds/leds-lp55xx-common.c | 235 ++++-- drivers/leds/leds-lp55xx-common.h | 36 +- drivers/leds/leds-lp8501.c | 23 +- include/dt-bindings/leds/common.h | 3 +- include/linux/led-class-multicolor.h | 139 +++ include/linux/platform_data/leds-lp55xx.h | 8 + 23 files changed, 2106 insertions(+), 172 deletions(-) create mode 100644 Documentation/ABI/testing/sysfs-class-led-multicolor create mode 100644 Documentation/devicetree/bindings/leds/leds-class-multicolor.txt create mode 100644 Documentation/devicetree/bindings/leds/leds-lp50xx.txt create mode 100644 Documentation/leds/leds-class-multicolor.rst create mode 100644 drivers/leds/led-class-multicolor.c create mode 100644 drivers/leds/leds-lp50xx.c create mode 100644 include/linux/led-class-multicolor.h -- 2.22.0.214.g8dca754b1e