| Message ID | 20191022142741.1794378-1-arnd@arndb.de |
|---|---|
| State | Accepted |
| Commit | fbbfb3f83e7866d953a26aa9a8c5e75e9ff11952 |
| Headers | show |
| Series | hwrng: omap3-rom - Fix unused function warnings | expand |
Hi, On Tue, Oct 22, 2019 at 04:27:31PM +0200, Arnd Bergmann wrote: > When runtime-pm is disabled, we get a few harmless warnings: > > drivers/char/hw_random/omap3-rom-rng.c:65:12: error: unused function 'omap_rom_rng_runtime_suspend' [-Werror,-Wunused-function] > drivers/char/hw_random/omap3-rom-rng.c:81:12: error: unused function 'omap_rom_rng_runtime_resume' [-Werror,-Wunused-function] > > Mark these functions as __maybe_unused so gcc can drop them > silently. > > Fixes: 8d9d4bdc495f ("hwrng: omap3-rom - Use runtime PM instead of custom functions") > Signed-off-by: Arnd Bergmann <arnd@arndb.de> > --- Reviewed-by: Sebastian Reichel <sebastian.reichel@collabora.com> -- Sebastian > drivers/char/hw_random/omap3-rom-rng.c | 4 ++-- > 1 file changed, 2 insertions(+), 2 deletions(-) > > diff --git a/drivers/char/hw_random/omap3-rom-rng.c b/drivers/char/hw_random/omap3-rom-rng.c > index 0b90983c95c8..e08a8887e718 100644 > --- a/drivers/char/hw_random/omap3-rom-rng.c > +++ b/drivers/char/hw_random/omap3-rom-rng.c > @@ -62,7 +62,7 @@ static int omap3_rom_rng_read(struct hwrng *rng, void *data, size_t max, bool w) > return r; > } > > -static int omap_rom_rng_runtime_suspend(struct device *dev) > +static int __maybe_unused omap_rom_rng_runtime_suspend(struct device *dev) > { > struct omap_rom_rng *ddata; > int r; > @@ -78,7 +78,7 @@ static int omap_rom_rng_runtime_suspend(struct device *dev) > return 0; > } > > -static int omap_rom_rng_runtime_resume(struct device *dev) > +static int __maybe_unused omap_rom_rng_runtime_resume(struct device *dev) > { > struct omap_rom_rng *ddata; > int r; > -- > 2.20.0 >
On Tue, Oct 22, 2019 at 04:27:31PM +0200, Arnd Bergmann wrote: > When runtime-pm is disabled, we get a few harmless warnings: > > drivers/char/hw_random/omap3-rom-rng.c:65:12: error: unused function 'omap_rom_rng_runtime_suspend' [-Werror,-Wunused-function] > drivers/char/hw_random/omap3-rom-rng.c:81:12: error: unused function 'omap_rom_rng_runtime_resume' [-Werror,-Wunused-function] > > Mark these functions as __maybe_unused so gcc can drop them > silently. > > Fixes: 8d9d4bdc495f ("hwrng: omap3-rom - Use runtime PM instead of custom functions") > Signed-off-by: Arnd Bergmann <arnd@arndb.de> > --- > drivers/char/hw_random/omap3-rom-rng.c | 4 ++-- > 1 file changed, 2 insertions(+), 2 deletions(-) Patch applied. Thanks. -- Email: Herbert Xu <herbert@gondor.apana.org.au> Home Page: http://gondor.apana.org.au/~herbert/ PGP Key: http://gondor.apana.org.au/~herbert/pubkey.txt
diff --git a/drivers/char/hw_random/omap3-rom-rng.c b/drivers/char/hw_random/omap3-rom-rng.c index 0b90983c95c8..e08a8887e718 100644 --- a/drivers/char/hw_random/omap3-rom-rng.c +++ b/drivers/char/hw_random/omap3-rom-rng.c @@ -62,7 +62,7 @@ static int omap3_rom_rng_read(struct hwrng *rng, void *data, size_t max, bool w) return r; } -static int omap_rom_rng_runtime_suspend(struct device *dev) +static int __maybe_unused omap_rom_rng_runtime_suspend(struct device *dev) { struct omap_rom_rng *ddata; int r; @@ -78,7 +78,7 @@ static int omap_rom_rng_runtime_suspend(struct device *dev) return 0; } -static int omap_rom_rng_runtime_resume(struct device *dev) +static int __maybe_unused omap_rom_rng_runtime_resume(struct device *dev) { struct omap_rom_rng *ddata; int r;
When runtime-pm is disabled, we get a few harmless warnings: drivers/char/hw_random/omap3-rom-rng.c:65:12: error: unused function 'omap_rom_rng_runtime_suspend' [-Werror,-Wunused-function] drivers/char/hw_random/omap3-rom-rng.c:81:12: error: unused function 'omap_rom_rng_runtime_resume' [-Werror,-Wunused-function] Mark these functions as __maybe_unused so gcc can drop them silently. Fixes: 8d9d4bdc495f ("hwrng: omap3-rom - Use runtime PM instead of custom functions") Signed-off-by: Arnd Bergmann <arnd@arndb.de> --- drivers/char/hw_random/omap3-rom-rng.c | 4 ++-- 1 file changed, 2 insertions(+), 2 deletions(-) -- 2.20.0