mbox series

[00/11] target/arm: decodetree prep patches

Message ID 20190807045335.1361-1-richard.henderson@linaro.org
Headers show
Series target/arm: decodetree prep patches | expand

Message

Richard Henderson Aug. 7, 2019, 4:53 a.m. UTC 
These are split out of my decodetree conversion of the
aarch32 general instructions.  With one exception, these
are all related to cleaning up how we refer to "PC".


r~


Richard Henderson (11):
  target/arm: Pass in pc to thumb_insn_is_16bit
  target/arm: Introduce pc_curr
  target/arm: Introduce read_pc
  target/arm: Introduce add_reg_for_lit
  target/arm: Remove redundant s->pc & ~1
  target/arm: Replace s->pc with s->base.pc_next
  target/arm: Replace offset with pc in gen_exception_insn
  target/arm: Replace offset with pc in gen_exception_internal_insn
  target/arm: Remove offset argument to gen_exception_bkpt_insn
  target/arm: Use unallocated_encoding for aarch32
  target/arm: Remove helper_double_saturate

 target/arm/helper.h            |   1 -
 target/arm/translate-a64.h     |   4 +-
 target/arm/translate.h         |   5 +-
 target/arm/op_helper.c         |  15 --
 target/arm/translate-a64.c     | 109 +++++----
 target/arm/translate-vfp.inc.c |  45 +---
 target/arm/translate.c         | 397 +++++++++++++++------------------
 7 files changed, 249 insertions(+), 327 deletions(-)

-- 
2.17.1

Comments

Peter Maydell Aug. 7, 2019, 5:52 p.m. UTC | #1 
On Wed, 7 Aug 2019 at 05:53, Richard Henderson
<richard.henderson@linaro.org> wrote:
>

> These are split out of my decodetree conversion of the

> aarch32 general instructions.  With one exception, these

> are all related to cleaning up how we refer to "PC".

>

>

> r~

>

>

> Richard Henderson (11):

>   target/arm: Pass in pc to thumb_insn_is_16bit

>   target/arm: Introduce pc_curr

>   target/arm: Introduce read_pc

>   target/arm: Introduce add_reg_for_lit

>   target/arm: Remove redundant s->pc & ~1

>   target/arm: Replace s->pc with s->base.pc_next

>   target/arm: Replace offset with pc in gen_exception_insn

>   target/arm: Replace offset with pc in gen_exception_internal_insn

>   target/arm: Remove offset argument to gen_exception_bkpt_insn

>   target/arm: Use unallocated_encoding for aarch32

>   target/arm: Remove helper_double_saturate


Whole series
Reviewed-by: Peter Maydell <peter.maydell@linaro.org>


I have one query on 3/11 but the change itself is clearly
correct so it's just a question of if we need to tweak the
commit message. Once we've figured that out I'll apply the
series to target-arm.next.

thanks
-- PMM
Peter Maydell Aug. 9, 2019, 12:49 p.m. UTC | #2 
On Wed, 7 Aug 2019 at 18:52, Peter Maydell <peter.maydell@linaro.org> wrote:
>

> On Wed, 7 Aug 2019 at 05:53, Richard Henderson

> <richard.henderson@linaro.org> wrote:

> >

> > These are split out of my decodetree conversion of the

> > aarch32 general instructions.  With one exception, these

> > are all related to cleaning up how we refer to "PC".

> >

> >

> > r~

> >

> >

> > Richard Henderson (11):

> >   target/arm: Pass in pc to thumb_insn_is_16bit

> >   target/arm: Introduce pc_curr

> >   target/arm: Introduce read_pc

> >   target/arm: Introduce add_reg_for_lit

> >   target/arm: Remove redundant s->pc & ~1

> >   target/arm: Replace s->pc with s->base.pc_next

> >   target/arm: Replace offset with pc in gen_exception_insn

> >   target/arm: Replace offset with pc in gen_exception_internal_insn

> >   target/arm: Remove offset argument to gen_exception_bkpt_insn

> >   target/arm: Use unallocated_encoding for aarch32

> >   target/arm: Remove helper_double_saturate

>

> Whole series

> Reviewed-by: Peter Maydell <peter.maydell@linaro.org>

>

> I have one query on 3/11 but the change itself is clearly

> correct so it's just a question of if we need to tweak the

> commit message. Once we've figured that out I'll apply the

> series to target-arm.next.


Now applied to target-arm.next with the agreed commit tweak.

thanks
-- PMM