| Message ID | 20190803011037.41864-1-raj.khem@gmail.com |
|---|---|
| State | New |
| Headers | show |
| Series | [oe,meta-perl,1/2] libsub-exporter-progressive-perl: Replace DEPENDS_PN with DEPENDS | expand |
Shouldn't this one be rather RDEPENDS_${PN}?
It was building without this build time dependency before and it's not
-native, so I guess it was rather typo in runtime dependency?
On Sat, Aug 3, 2019 at 3:11 AM Khem Raj <raj.khem@gmail.com> wrote:
> Fixes
> libsub-exporter-progressive-perl_0.001013.bb: QA Issue: recipe uses
> DEPENDS_${PN}, should use DEPENDS [pkgvarcheck]
>
> Signed-off-by: Khem Raj <raj.khem@gmail.com>
> ---
> .../libsub/libsub-exporter-progressive-perl_0.001013.bb | 2 +-
> 1 file changed, 1 insertion(+), 1 deletion(-)
>
> diff --git a/meta-perl/recipes-perl/libsub/
> libsub-exporter-progressive-perl_0.001013.bb
> b/meta-perl/recipes-perl/libsub/
> libsub-exporter-progressive-perl_0.001013.bb
> index 64d19c0f1f..e484f4a7a0 100644
> --- a/meta-perl/recipes-perl/libsub/
> libsub-exporter-progressive-perl_0.001013.bb
> +++ b/meta-perl/recipes-perl/libsub/
> libsub-exporter-progressive-perl_0.001013.bb
> @@ -13,7 +13,7 @@ HOMEPAGE = "
> https://metacpan.org/pod/Sub-Exporter-Progressive/"
> LICENSE = "Artistic-1.0 | GPL-1.0+"
> LIC_FILES_CHKSUM = "file://LICENSE;md5=003fa970662359a43ac2c2961108b0f1"
>
> -DEPENDS_${PN} = " perl-module-test-more"
> +DEPENDS += " perl-module-test-more"
>
> SRC_URI =
> "${CPAN_MIRROR}/authors/id/F/FR/FREW/Sub-Exporter-Progressive-${PV}.tar.gz"
> SRC_URI[md5sum] = "72cf6acdd2a0a8b105821a4db98e4ebe"
> --
> 2.22.0
>
> --
> _______________________________________________
> Openembedded-devel mailing list
> Openembedded-devel@lists.openembedded.org
> http://lists.openembedded.org/mailman/listinfo/openembedded-devel
>
--
_______________________________________________
Openembedded-devel mailing list
Openembedded-devel@lists.openembedded.org
http://lists.openembedded.org/mailman/listinfo/openembedded-devel
Yes, you are right. I already fixed it locally will send v2 soon On Sat, Aug 3, 2019 at 3:11 AM Martin Jansa <martin.jansa@gmail.com> wrote: > Shouldn't this one be rather RDEPENDS_${PN}? > > It was building without this build time dependency before and it's not > -native, so I guess it was rather typo in runtime dependency? > > On Sat, Aug 3, 2019 at 3:11 AM Khem Raj <raj.khem@gmail.com> wrote: > >> Fixes >> libsub-exporter-progressive-perl_0.001013.bb: QA Issue: recipe uses >> DEPENDS_${PN}, should use DEPENDS [pkgvarcheck] >> >> Signed-off-by: Khem Raj <raj.khem@gmail.com> >> --- >> .../libsub/libsub-exporter-progressive-perl_0.001013.bb | 2 +- >> 1 file changed, 1 insertion(+), 1 deletion(-) >> >> diff --git a/meta-perl/recipes-perl/libsub/ >> libsub-exporter-progressive-perl_0.001013.bb >> b/meta-perl/recipes-perl/libsub/ >> libsub-exporter-progressive-perl_0.001013.bb >> index 64d19c0f1f..e484f4a7a0 100644 >> --- a/meta-perl/recipes-perl/libsub/ >> libsub-exporter-progressive-perl_0.001013.bb >> +++ b/meta-perl/recipes-perl/libsub/ >> libsub-exporter-progressive-perl_0.001013.bb >> @@ -13,7 +13,7 @@ HOMEPAGE = " >> https://metacpan.org/pod/Sub-Exporter-Progressive/" >> LICENSE = "Artistic-1.0 | GPL-1.0+" >> LIC_FILES_CHKSUM = "file://LICENSE;md5=003fa970662359a43ac2c2961108b0f1" >> >> -DEPENDS_${PN} = " perl-module-test-more" >> +DEPENDS += " perl-module-test-more" >> >> SRC_URI = >> "${CPAN_MIRROR}/authors/id/F/FR/FREW/Sub-Exporter-Progressive-${PV}.tar.gz" >> SRC_URI[md5sum] = "72cf6acdd2a0a8b105821a4db98e4ebe" >> -- >> 2.22.0 >> >> -- >> _______________________________________________ >> Openembedded-devel mailing list >> Openembedded-devel@lists.openembedded.org >> http://lists.openembedded.org/mailman/listinfo/openembedded-devel >> > -- _______________________________________________ Openembedded-devel mailing list Openembedded-devel@lists.openembedded.org http://lists.openembedded.org/mailman/listinfo/openembedded-devel
On Sat, Aug 03, 2019 at 12:11:32PM +0200, Martin Jansa wrote: > Shouldn't this one be rather RDEPENDS_${PN}? > > It was building without this build time dependency before and it's not > -native, so I guess it was rather typo in runtime dependency? This also sounds wrong to me. As expected it uses Test::More only when running tests, so forcing a runtime dependency is unnecessary. RDEPENDS_${PN}-ptest would be correct if there was a ptest package. cu Adrian -- "Is there not promise of rain?" Ling Tan asked suddenly out of the darkness. There had been need of rain for many days. "Only a promise," Lao Er said. Pearl S. Buck - Dragon Seed -- _______________________________________________ Openembedded-devel mailing list Openembedded-devel@lists.openembedded.org http://lists.openembedded.org/mailman/listinfo/openembedded-devel
diff --git a/meta-perl/recipes-perl/libsub/libsub-exporter-progressive-perl_0.001013.bb b/meta-perl/recipes-perl/libsub/libsub-exporter-progressive-perl_0.001013.bb index 64d19c0f1f..e484f4a7a0 100644 --- a/meta-perl/recipes-perl/libsub/libsub-exporter-progressive-perl_0.001013.bb +++ b/meta-perl/recipes-perl/libsub/libsub-exporter-progressive-perl_0.001013.bb @@ -13,7 +13,7 @@ HOMEPAGE = "https://metacpan.org/pod/Sub-Exporter-Progressive/" LICENSE = "Artistic-1.0 | GPL-1.0+" LIC_FILES_CHKSUM = "file://LICENSE;md5=003fa970662359a43ac2c2961108b0f1" -DEPENDS_${PN} = " perl-module-test-more" +DEPENDS += " perl-module-test-more" SRC_URI = "${CPAN_MIRROR}/authors/id/F/FR/FREW/Sub-Exporter-Progressive-${PV}.tar.gz" SRC_URI[md5sum] = "72cf6acdd2a0a8b105821a4db98e4ebe"
Fixes libsub-exporter-progressive-perl_0.001013.bb: QA Issue: recipe uses DEPENDS_${PN}, should use DEPENDS [pkgvarcheck] Signed-off-by: Khem Raj <raj.khem@gmail.com> --- .../libsub/libsub-exporter-progressive-perl_0.001013.bb | 2 +- 1 file changed, 1 insertion(+), 1 deletion(-) -- 2.22.0 -- _______________________________________________ Openembedded-devel mailing list Openembedded-devel@lists.openembedded.org http://lists.openembedded.org/mailman/listinfo/openembedded-devel