| Message ID | 20190801151421.21486-2-dmurphy@ti.com |
|---|---|
| State | Superseded |
| Headers | show |
| Series | [1/3] leds: lm3532: Fix brightness control for i2c mode | expand |
Dan, On 8/1/19 5:14 PM, Dan Murphy wrote: > Add a property for each control bank to configure the > full scale current setting for the device. > > Signed-off-by: Dan Murphy <dmurphy@ti.com> > --- > Documentation/devicetree/bindings/leds/leds-lm3532.txt | 4 ++++ > 1 file changed, 4 insertions(+) > > diff --git a/Documentation/devicetree/bindings/leds/leds-lm3532.txt b/Documentation/devicetree/bindings/leds/leds-lm3532.txt > index c087f85ddddc..d3498dd24e8e 100644 > --- a/Documentation/devicetree/bindings/leds/leds-lm3532.txt > +++ b/Documentation/devicetree/bindings/leds/leds-lm3532.txt > @@ -62,6 +62,9 @@ Optional LED child properties: > - label : see Documentation/devicetree/bindings/leds/common.txt > - linux,default-trigger : > see Documentation/devicetree/bindings/leds/common.txt > + - ti,fs-current : Defines the full scale current value for each control > + bank. The range is from 5000uA-29800uA in increments > + of 800uA. Wouldn't led-max-microamp fit here? > > Example: > led-controller@38 { > @@ -85,6 +88,7 @@ led-controller@38 { > reg = <0>; > led-sources = <2>; > ti,led-mode = <1>; > + ti,fs-current = <21800>; > label = ":backlight"; > linux,default-trigger = "backlight"; > }; > -- Best regards, Jacek Anaszewski
Jacek On 8/1/19 1:53 PM, Jacek Anaszewski wrote: > Dan, > > On 8/1/19 5:14 PM, Dan Murphy wrote: >> Add a property for each control bank to configure the >> full scale current setting for the device. >> >> Signed-off-by: Dan Murphy <dmurphy@ti.com> >> --- >> Documentation/devicetree/bindings/leds/leds-lm3532.txt | 4 ++++ >> 1 file changed, 4 insertions(+) >> >> diff --git a/Documentation/devicetree/bindings/leds/leds-lm3532.txt b/Documentation/devicetree/bindings/leds/leds-lm3532.txt >> index c087f85ddddc..d3498dd24e8e 100644 >> --- a/Documentation/devicetree/bindings/leds/leds-lm3532.txt >> +++ b/Documentation/devicetree/bindings/leds/leds-lm3532.txt >> @@ -62,6 +62,9 @@ Optional LED child properties: >> - label : see Documentation/devicetree/bindings/leds/common.txt >> - linux,default-trigger : >> see Documentation/devicetree/bindings/leds/common.txt >> + - ti,fs-current : Defines the full scale current value for each control >> + bank. The range is from 5000uA-29800uA in increments >> + of 800uA. > Wouldn't led-max-microamp fit here? Ah thats what I was looking for. I would rather use existing properties. I will change that. Dan
diff --git a/Documentation/devicetree/bindings/leds/leds-lm3532.txt b/Documentation/devicetree/bindings/leds/leds-lm3532.txt index c087f85ddddc..d3498dd24e8e 100644 --- a/Documentation/devicetree/bindings/leds/leds-lm3532.txt +++ b/Documentation/devicetree/bindings/leds/leds-lm3532.txt @@ -62,6 +62,9 @@ Optional LED child properties: - label : see Documentation/devicetree/bindings/leds/common.txt - linux,default-trigger : see Documentation/devicetree/bindings/leds/common.txt + - ti,fs-current : Defines the full scale current value for each control + bank. The range is from 5000uA-29800uA in increments + of 800uA. Example: led-controller@38 { @@ -85,6 +88,7 @@ led-controller@38 { reg = <0>; led-sources = <2>; ti,led-mode = <1>; + ti,fs-current = <21800>; label = ":backlight"; linux,default-trigger = "backlight"; };
Add a property for each control bank to configure the full scale current setting for the device. Signed-off-by: Dan Murphy <dmurphy@ti.com> --- Documentation/devicetree/bindings/leds/leds-lm3532.txt | 4 ++++ 1 file changed, 4 insertions(+) -- 2.22.0.214.g8dca754b1e