| Message ID | 20190724044906.12007-1-vkoul@kernel.org |
|---|---|
| Headers | show |
| Series | arm64: dts: qcom: sdm845: Fix DTS warnings | expand |
On Wed, Jul 24, 2019 at 10:20 AM Vinod Koul <vkoul@kernel.org> wrote: > > We get a warning about missing unit name for soc node, so add it. > > arch/arm64/boot/dts/qcom/sdm845.dtsi:623.11-2814.4: Warning (unit_address_vs_reg): /soc: node has a reg or ranges property, but no unit name > > Signed-off-by: Vinod Koul <vkoul@kernel.org> > Reviewed-by: Stephen Boyd <swboyd@chromium.org> Reviewed-by: Amit Kucheria <amit.kucheria@linaro.org> > --- > arch/arm64/boot/dts/qcom/sdm845.dtsi | 2 +- > 1 file changed, 1 insertion(+), 1 deletion(-) > > diff --git a/arch/arm64/boot/dts/qcom/sdm845.dtsi b/arch/arm64/boot/dts/qcom/sdm845.dtsi > index 601cfb078bd5..e81f4a6d08ce 100644 > --- a/arch/arm64/boot/dts/qcom/sdm845.dtsi > +++ b/arch/arm64/boot/dts/qcom/sdm845.dtsi > @@ -620,7 +620,7 @@ > method = "smc"; > }; > > - soc: soc { > + soc: soc@0 { > #address-cells = <2>; > #size-cells = <2>; > ranges = <0 0 0 0 0x10 0>; > -- > 2.20.1 >
On Wed, Jul 24, 2019 at 10:20 AM Vinod Koul <vkoul@kernel.org> wrote: > > Unit name is supposed to be a number, using a macro with hex value is > not recommended, so add the value in unit name. > > arch/arm64/boot/dts/qcom/pm8998.dtsi:81.18-84.6: Warning (unit_address_format): /soc/spmi@c440000/pmic@0/adc@3100/adc-chan@0x06: unit name should not have leading "0x" > arch/arm64/boot/dts/qcom/pm8998.dtsi:81.18-84.6: Warning (unit_address_format): /soc/spmi@c440000/pmic@0/adc@3100/adc-chan@0x06: unit name should not have leading 0s > > Signed-off-by: Vinod Koul <vkoul@kernel.org> Reviewed-by: Amit Kucheria <amit.kucheria@linaro.org> > --- > arch/arm64/boot/dts/qcom/pm8998.dtsi | 2 +- > 1 file changed, 1 insertion(+), 1 deletion(-) > > diff --git a/arch/arm64/boot/dts/qcom/pm8998.dtsi b/arch/arm64/boot/dts/qcom/pm8998.dtsi > index 051a52df80f9..dc2ce23cde05 100644 > --- a/arch/arm64/boot/dts/qcom/pm8998.dtsi > +++ b/arch/arm64/boot/dts/qcom/pm8998.dtsi > @@ -78,7 +78,7 @@ > #size-cells = <0>; > #io-channel-cells = <1>; > > - adc-chan@ADC5_DIE_TEMP { > + adc-chan@6 { > reg = <ADC5_DIE_TEMP>; > label = "die_temp"; > }; > -- > 2.20.1 >
Quoting Vinod Koul (2019-07-23 21:49:05) > Unit name is supposed to be a number, using a macro with hex value is > not recommended, so add the value in unit name. > > arch/arm64/boot/dts/qcom/pm8998.dtsi:81.18-84.6: Warning (unit_address_format): /soc/spmi@c440000/pmic@0/adc@3100/adc-chan@0x06: unit name should not have leading "0x" > arch/arm64/boot/dts/qcom/pm8998.dtsi:81.18-84.6: Warning (unit_address_format): /soc/spmi@c440000/pmic@0/adc@3100/adc-chan@0x06: unit name should not have leading 0s > > Signed-off-by: Vinod Koul <vkoul@kernel.org> > --- Reviewed-by: Stephen Boyd <swboyd@chromium.org>
On Tue, Jul 23, 2019 at 9:51 PM Vinod Koul <vkoul@kernel.org> wrote: > > We get a warning about missing unit name for soc node, so add it. > > arch/arm64/boot/dts/qcom/sdm845.dtsi:623.11-2814.4: Warning (unit_address_vs_reg): /soc: node has a reg or ranges property, but no unit name > > Signed-off-by: Vinod Koul <vkoul@kernel.org> > Reviewed-by: Stephen Boyd <swboyd@chromium.org> > --- > arch/arm64/boot/dts/qcom/sdm845.dtsi | 2 +- > 1 file changed, 1 insertion(+), 1 deletion(-) > > diff --git a/arch/arm64/boot/dts/qcom/sdm845.dtsi b/arch/arm64/boot/dts/qcom/sdm845.dtsi > index 601cfb078bd5..e81f4a6d08ce 100644 > --- a/arch/arm64/boot/dts/qcom/sdm845.dtsi > +++ b/arch/arm64/boot/dts/qcom/sdm845.dtsi > @@ -620,7 +620,7 @@ > method = "smc"; > }; > > - soc: soc { > + soc: soc@0 { > #address-cells = <2>; > #size-cells = <2>; > ranges = <0 0 0 0 0x10 0>; So Amit Pundir noted that this patch is causing 5.4-rc to no longer boot on db845 w/ AOSP, due to it changing the userland sysfs paths from "/devices/platform/soc/1a00000.mdss" to "/devices/platform/soc@0/1a00000.mdss" Is there a better solution here that might not break userspace? thanks -john
On Mon, Oct 7, 2019 at 12:44 PM John Stultz <john.stultz@linaro.org> wrote: > > On Tue, Jul 23, 2019 at 9:51 PM Vinod Koul <vkoul@kernel.org> wrote: > > > > We get a warning about missing unit name for soc node, so add it. > > > > arch/arm64/boot/dts/qcom/sdm845.dtsi:623.11-2814.4: Warning (unit_address_vs_reg): /soc: node has a reg or ranges property, but no unit name > > > > Signed-off-by: Vinod Koul <vkoul@kernel.org> > > Reviewed-by: Stephen Boyd <swboyd@chromium.org> > > --- > > arch/arm64/boot/dts/qcom/sdm845.dtsi | 2 +- > > 1 file changed, 1 insertion(+), 1 deletion(-) > > > > diff --git a/arch/arm64/boot/dts/qcom/sdm845.dtsi b/arch/arm64/boot/dts/qcom/sdm845.dtsi > > index 601cfb078bd5..e81f4a6d08ce 100644 > > --- a/arch/arm64/boot/dts/qcom/sdm845.dtsi > > +++ b/arch/arm64/boot/dts/qcom/sdm845.dtsi > > @@ -620,7 +620,7 @@ > > method = "smc"; > > }; > > > > - soc: soc { > > + soc: soc@0 { > > #address-cells = <2>; > > #size-cells = <2>; > > ranges = <0 0 0 0 0x10 0>; > > So Amit Pundir noted that this patch is causing 5.4-rc to no longer > boot on db845 w/ AOSP, due to it changing the userland sysfs paths > from "/devices/platform/soc/1a00000.mdss" to > "/devices/platform/soc@0/1a00000.mdss" > > Is there a better solution here that might not break userspace? Other than doing the right thing of not relying on /sys/devices/platform/* paths, implement per target/file DTC_FLAGS similar to CFLAGS. There is another want for this in order to enable dtc symbols for overlays on a per board basis. Rob