| Message ID | 20190703231038.73097-1-john.stultz@linaro.org |
|---|---|
| State | New |
| Headers | show |
| Series | [1/2] mesa: Fix clang build error w/ util_blitter_get_color_format_for_zs() | expand |
Thanks for the notice. I had already had a fix for this, but forgot to push it. It's pushed now. Marek On Wed, Jul 3, 2019 at 7:10 PM John Stultz <john.stultz@linaro.org> wrote: > Building with clang, I'm seeing > u_blitter.h:627:1: error: control may reach end of non-void function > [-Werror,-Wreturn-type] > > The util_blitter_get_color_format_for_zs() asserts for any > unhandled types, so we do not expect to reach the end of the > function here. > > But provide a dummy return with an explicit assert above > to ensure we don't hit it with any future changes to the logic. > > Cc: Rob Clark <robdclark@chromium.org> > Cc: Emil Velikov <emil.l.velikov@gmail.com> > Cc: Amit Pundir <amit.pundir@linaro.org> > Cc: Sumit Semwal <sumit.semwal@linaro.org> > Cc: Alistair Strachan <astrachan@google.com> > Cc: Greg Hartman <ghartman@google.com> > Cc: Tapani Pälli <tapani.palli@intel.com> > Cc: Marek Olšák <marek.olsak@amd.com> > Signed-off-by: John Stultz <john.stultz@linaro.org> > --- > src/gallium/auxiliary/util/u_blitter.h | 3 +++ > 1 file changed, 3 insertions(+) > > diff --git a/src/gallium/auxiliary/util/u_blitter.h > b/src/gallium/auxiliary/util/u_blitter.h > index 9e3fa55e648..7d6c3db64da 100644 > --- a/src/gallium/auxiliary/util/u_blitter.h > +++ b/src/gallium/auxiliary/util/u_blitter.h > @@ -624,6 +624,9 @@ util_blitter_get_color_format_for_zs(enum pipe_format > format) > default: > assert(0); > } > + assert(0); > + /*XXX NEVER GET HERE*/ > + return PIPE_FORMAT_R32G32_UINT; > } > > #ifdef __cplusplus > -- > 2.17.1 > > _______________________________________________ > dri-devel mailing list > dri-devel@lists.freedesktop.org > https://lists.freedesktop.org/mailman/listinfo/dri-devel <div dir="ltr"><div>Thanks for the notice. I had already had a fix for this, but forgot to push it. It's pushed now.</div><div><br></div><div>Marek<br></div></div><br><div class="gmail_quote"><div dir="ltr" class="gmail_attr">On Wed, Jul 3, 2019 at 7:10 PM John Stultz <<a href="mailto:john.stultz@linaro.org">john.stultz@linaro.org</a>> wrote:<br></div><blockquote class="gmail_quote" style="margin:0px 0px 0px 0.8ex;border-left:1px solid rgb(204,204,204);padding-left:1ex">Building with clang, I'm seeing<br> u_blitter.h:627:1: error: control may reach end of non-void function [-Werror,-Wreturn-type]<br> <br> The util_blitter_get_color_format_for_zs() asserts for any<br> unhandled types, so we do not expect to reach the end of the<br> function here.<br> <br> But provide a dummy return with an explicit assert above<br> to ensure we don't hit it with any future changes to the logic.<br> <br> Cc: Rob Clark <<a href="mailto:robdclark@chromium.org" target="_blank">robdclark@chromium.org</a>><br> Cc: Emil Velikov <<a href="mailto:emil.l.velikov@gmail.com" target="_blank">emil.l.velikov@gmail.com</a>><br> Cc: Amit Pundir <<a href="mailto:amit.pundir@linaro.org" target="_blank">amit.pundir@linaro.org</a>><br> Cc: Sumit Semwal <<a href="mailto:sumit.semwal@linaro.org" target="_blank">sumit.semwal@linaro.org</a>><br> Cc: Alistair Strachan <<a href="mailto:astrachan@google.com" target="_blank">astrachan@google.com</a>><br> Cc: Greg Hartman <<a href="mailto:ghartman@google.com" target="_blank">ghartman@google.com</a>><br> Cc: Tapani Pälli <<a href="mailto:tapani.palli@intel.com" target="_blank">tapani.palli@intel.com</a>><br> Cc: Marek Olšák <<a href="mailto:marek.olsak@amd.com" target="_blank">marek.olsak@amd.com</a>><br> Signed-off-by: John Stultz <<a href="mailto:john.stultz@linaro.org" target="_blank">john.stultz@linaro.org</a>><br> ---<br> src/gallium/auxiliary/util/u_blitter.h | 3 +++<br> 1 file changed, 3 insertions(+)<br> <br> diff --git a/src/gallium/auxiliary/util/u_blitter.h b/src/gallium/auxiliary/util/u_blitter.h<br> index 9e3fa55e648..7d6c3db64da 100644<br> --- a/src/gallium/auxiliary/util/u_blitter.h<br> +++ b/src/gallium/auxiliary/util/u_blitter.h<br> @@ -624,6 +624,9 @@ util_blitter_get_color_format_for_zs(enum pipe_format format)<br> default:<br> assert(0);<br> }<br> + assert(0);<br> + /*XXX NEVER GET HERE*/<br> + return PIPE_FORMAT_R32G32_UINT;<br> }<br> <br> #ifdef __cplusplus<br> -- <br> 2.17.1<br> <br> _______________________________________________<br> dri-devel mailing list<br> <a href="mailto:dri-devel@lists.freedesktop.org" target="_blank">dri-devel@lists.freedesktop.org</a><br> <a href="https://lists.freedesktop.org/mailman/listinfo/dri-devel" rel="noreferrer" target="_blank">https://lists.freedesktop.org/mailman/listinfo/dri-devel</a></blockquote></div>
diff --git a/src/gallium/auxiliary/util/u_blitter.h b/src/gallium/auxiliary/util/u_blitter.h index 9e3fa55e648..7d6c3db64da 100644 --- a/src/gallium/auxiliary/util/u_blitter.h +++ b/src/gallium/auxiliary/util/u_blitter.h @@ -624,6 +624,9 @@ util_blitter_get_color_format_for_zs(enum pipe_format format) default: assert(0); } + assert(0); + /*XXX NEVER GET HERE*/ + return PIPE_FORMAT_R32G32_UINT; } #ifdef __cplusplus
Building with clang, I'm seeing u_blitter.h:627:1: error: control may reach end of non-void function [-Werror,-Wreturn-type] The util_blitter_get_color_format_for_zs() asserts for any unhandled types, so we do not expect to reach the end of the function here. But provide a dummy return with an explicit assert above to ensure we don't hit it with any future changes to the logic. Cc: Rob Clark <robdclark@chromium.org> Cc: Emil Velikov <emil.l.velikov@gmail.com> Cc: Amit Pundir <amit.pundir@linaro.org> Cc: Sumit Semwal <sumit.semwal@linaro.org> Cc: Alistair Strachan <astrachan@google.com> Cc: Greg Hartman <ghartman@google.com> Cc: Tapani Pälli <tapani.palli@intel.com> Cc: Marek Olšák <marek.olsak@amd.com> Signed-off-by: John Stultz <john.stultz@linaro.org> --- src/gallium/auxiliary/util/u_blitter.h | 3 +++ 1 file changed, 3 insertions(+) -- 2.17.1