| Message ID | 20190629130017.2973-10-richard.henderson@linaro.org |
|---|---|
| State | New |
| Headers | show |
| Series | tcg/ppc: Add vector opcodes | expand |
On Saturday, June 29, 2019, Richard Henderson <richard.henderson@linaro.org> wrote: > This line is just preparation for full vector multiply support > in some of subsequent patches. > > This patch should be aquashed into the patch on implementing multiply. > Signed-off-by: Richard Henderson <richard.henderson@linaro.org> > Signed-off-by: Aleksandar Markovic <amarkovic@wavecomp.com> > --- > tcg/ppc/tcg-target.inc.c | 1 + > 1 file changed, 1 insertion(+) > > diff --git a/tcg/ppc/tcg-target.inc.c b/tcg/ppc/tcg-target.inc.c > index 307e809fad..e19400609c 100644 > --- a/tcg/ppc/tcg-target.inc.c > +++ b/tcg/ppc/tcg-target.inc.c > @@ -3306,6 +3306,7 @@ static const TCGTargetOpDef > *tcg_target_op_def(TCGOpcode op) > > case INDEX_op_add_vec: > case INDEX_op_sub_vec: > + case INDEX_op_mul_vec: > case INDEX_op_and_vec: > case INDEX_op_or_vec: > case INDEX_op_xor_vec: > -- > 2.17.1 > > >
On 6/30/19 11:52 AM, Aleksandar Markovic wrote: > > > On Saturday, June 29, 2019, Richard Henderson <richard.henderson@linaro.org > <mailto:richard.henderson@linaro.org>> wrote: > > This line is just preparation for full vector multiply support > in some of subsequent patches. > > > This patch should be aquashed into the patch on implementing multiply. Yes it should. Incidentally, why did you split it out in the first place? r~
On Jun 30, 2019 12:49 PM, "Richard Henderson" <richard.henderson@linaro.org> wrote: > > On 6/30/19 11:52 AM, Aleksandar Markovic wrote: > > > > > > On Saturday, June 29, 2019, Richard Henderson < richard.henderson@linaro.org > > <mailto:richard.henderson@linaro.org>> wrote: > > > > This line is just preparation for full vector multiply support > > in some of subsequent patches. > > > > > > This patch should be aquashed into the patch on implementing multiply. > > Yes it should. > > Incidentally, why did you split it out in the first place? > I wanted to split the patch 1 from v4 into smaller patches, and use remaining v4 patches as-is, so I did not want to meld this segment (from patch 1) and one of remaining patches (mul), otherwise remaining patches wouldn't be as-is. But v5 was done mainly for debugging purposes. Normally, two mentioned partches on “multiply” should obviously be melded. > > r~
diff --git a/tcg/ppc/tcg-target.inc.c b/tcg/ppc/tcg-target.inc.c index 307e809fad..e19400609c 100644 --- a/tcg/ppc/tcg-target.inc.c +++ b/tcg/ppc/tcg-target.inc.c @@ -3306,6 +3306,7 @@ static const TCGTargetOpDef *tcg_target_op_def(TCGOpcode op) case INDEX_op_add_vec: case INDEX_op_sub_vec: + case INDEX_op_mul_vec: case INDEX_op_and_vec: case INDEX_op_or_vec: case INDEX_op_xor_vec: