mbox series

[BUGFIX,IMPROVEMENT,0/7] boost throughput with synced I/O, reduce latency and fix a bandwidth bug

Message ID 20190624194042.38747-1-paolo.valente@linaro.org
Headers show
Series boost throughput with synced I/O, reduce latency and fix a bandwidth bug | expand

Message

Paolo Valente June 24, 2019, 7:40 p.m. UTC
Hi Jens,
this series, based against for-5.3/block, contains:
1) The improvements to recover the throughput loss reported by
   Srivatsa [1] (first five patches)
2) A preemption improvement to reduce I/O latency
3) A fix of a subtle bug causing loss of control over I/O bandwidths

Thanks,
Paolo

[1] https://lkml.org/lkml/2019/5/17/755

Paolo Valente (7):
  block, bfq: reset inject limit when think-time state changes
  block, bfq: fix rq_in_driver check in bfq_update_inject_limit
  block, bfq: update base request service times when possible
  block, bfq: bring forward seek&think time update
  block, bfq: detect wakers and unconditionally inject their I/O
  block, bfq: preempt lower-weight or lower-priority queues
  block, bfq: re-schedule empty queues if they deserve I/O plugging

 block/bfq-iosched.c | 952 ++++++++++++++++++++++++++++++--------------
 block/bfq-iosched.h |  25 +-
 2 files changed, 686 insertions(+), 291 deletions(-)

--
2.20.1

Comments

Srivatsa S. Bhat June 24, 2019, 8:15 p.m. UTC | #1
On 6/24/19 12:40 PM, Paolo Valente wrote:
> Hi Jens,

> this series, based against for-5.3/block, contains:

> 1) The improvements to recover the throughput loss reported by

>    Srivatsa [1] (first five patches)

> 2) A preemption improvement to reduce I/O latency

> 3) A fix of a subtle bug causing loss of control over I/O bandwidths

> 


Thanks a lot for these patches, Paolo!

Would you mind adding:

Reported-by: Srivatsa S. Bhat (VMware) <srivatsa@csail.mit.edu>
Tested-by: Srivatsa S. Bhat (VMware) <srivatsa@csail.mit.edu>


to the first 5 patches, as appropriate?

Thank you!

> 

> [1] https://lkml.org/lkml/2019/5/17/755

> 

> Paolo Valente (7):

>   block, bfq: reset inject limit when think-time state changes

>   block, bfq: fix rq_in_driver check in bfq_update_inject_limit

>   block, bfq: update base request service times when possible

>   block, bfq: bring forward seek&think time update

>   block, bfq: detect wakers and unconditionally inject their I/O

>   block, bfq: preempt lower-weight or lower-priority queues

>   block, bfq: re-schedule empty queues if they deserve I/O plugging

> 

>  block/bfq-iosched.c | 952 ++++++++++++++++++++++++++++++--------------

>  block/bfq-iosched.h |  25 +-

>  2 files changed, 686 insertions(+), 291 deletions(-)

> 


Regards,
Srivatsa
VMware Photon OS
Paolo Valente June 25, 2019, 5:11 a.m. UTC | #2
> Il giorno 24 giu 2019, alle ore 22:15, Srivatsa S. Bhat <srivatsa@csail.mit.edu> ha scritto:

> 

> On 6/24/19 12:40 PM, Paolo Valente wrote:

>> Hi Jens,

>> this series, based against for-5.3/block, contains:

>> 1) The improvements to recover the throughput loss reported by

>>   Srivatsa [1] (first five patches)

>> 2) A preemption improvement to reduce I/O latency

>> 3) A fix of a subtle bug causing loss of control over I/O bandwidths

>> 

> 

> Thanks a lot for these patches, Paolo!

> 

> Would you mind adding:

> 

> Reported-by: Srivatsa S. Bhat (VMware) <srivatsa@csail.mit.edu>

> Tested-by: Srivatsa S. Bhat (VMware) <srivatsa@csail.mit.edu>

> 

> to the first 5 patches, as appropriate?

> 


With great pleasure!  (sorry for adding you only as tester in the
first place)

Thanks,
Paolo

> Thank you!

> 

>> 

>> [1] https://lkml.org/lkml/2019/5/17/755

>> 

>> Paolo Valente (7):

>>  block, bfq: reset inject limit when think-time state changes

>>  block, bfq: fix rq_in_driver check in bfq_update_inject_limit

>>  block, bfq: update base request service times when possible

>>  block, bfq: bring forward seek&think time update

>>  block, bfq: detect wakers and unconditionally inject their I/O

>>  block, bfq: preempt lower-weight or lower-priority queues

>>  block, bfq: re-schedule empty queues if they deserve I/O plugging

>> 

>> block/bfq-iosched.c | 952 ++++++++++++++++++++++++++++++--------------

>> block/bfq-iosched.h |  25 +-

>> 2 files changed, 686 insertions(+), 291 deletions(-)

>> 

> 

> Regards,

> Srivatsa

> VMware Photon OS