| Message ID | 20190605205706.569-1-richard.henderson@linaro.org |
|---|---|
| Headers | show |
| Series | linux-user/aarch64: Support PROT_BTI | expand |
Patchew URL: https://patchew.org/QEMU/20190605205706.569-1-richard.henderson@linaro.org/ Hi, This series seems to have some coding style problems. See output below for more information: Subject: [Qemu-devel] [PATCH v6 0/6] linux-user/aarch64: Support PROT_BTI Type: series Message-id: 20190605205706.569-1-richard.henderson@linaro.org === TEST SCRIPT BEGIN === #!/bin/bash git rev-parse base > /dev/null || exit 0 git config --local diff.renamelimit 0 git config --local diff.renames True git config --local diff.algorithm histogram ./scripts/checkpatch.pl --mailback base.. === TEST SCRIPT END === From https://github.com/patchew-project/qemu * [new tag] patchew/20190605205706.569-1-richard.henderson@linaro.org -> patchew/20190605205706.569-1-richard.henderson@linaro.org Switched to a new branch 'test' 6038ce2e0e tests/tcg/aarch64: Add bti smoke test b16ad5bd7b linux-user: Parse NT_GNU_PROPERTY_TYPE_0 notes 68fefef717 include/elf: Add defines related to notes for GNU systems 951669d523 linux-user: Set PAGE_TARGET_1 for TARGET_PROT_BTI 6ec44edda5 linux-user: Validate mmap/mprotect prot value 4eb77556ad linux-user/aarch64: Reset btype for syscalls and signals === OUTPUT BEGIN === 1/6 Checking commit 4eb77556ad1e (linux-user/aarch64: Reset btype for syscalls and signals) 2/6 Checking commit 6ec44edda5a0 (linux-user: Validate mmap/mprotect prot value) 3/6 Checking commit 951669d5231b (linux-user: Set PAGE_TARGET_1 for TARGET_PROT_BTI) 4/6 Checking commit 68fefef717be (include/elf: Add defines related to notes for GNU systems) 5/6 Checking commit b16ad5bd7b5c (linux-user: Parse NT_GNU_PROPERTY_TYPE_0 notes) 6/6 Checking commit 6038ce2e0e44 (tests/tcg/aarch64: Add bti smoke test) WARNING: added, moved or deleted file(s), does MAINTAINERS need updating? #33: new file mode 100644 ERROR: code indent should never use tabs #50: FILE: tests/tcg/aarch64/bti-1.c:13: +^Ihint^I#34\n\$ ERROR: code indent should never use tabs #51: FILE: tests/tcg/aarch64/bti-1.c:14: +^Ib^Iskip2_sigill2\n\$ ERROR: externs should be avoided in .c files #133: FILE: tests/tcg/aarch64/bti-crt.inc.c:13: +int main(void); ERROR: code indent should never use tabs #180: FILE: tests/tcg/aarch64/bti-crt.inc.c:60: +^I.align^I3\n\$ ERROR: code indent should never use tabs #181: FILE: tests/tcg/aarch64/bti-crt.inc.c:61: +^I.long^I4\n\$ ERROR: code indent should never use tabs #182: FILE: tests/tcg/aarch64/bti-crt.inc.c:62: + .long^I16\n\$ ERROR: code indent should never use tabs #183: FILE: tests/tcg/aarch64/bti-crt.inc.c:63: + .long^I5\n\$ ERROR: code indent should never use tabs #184: FILE: tests/tcg/aarch64/bti-crt.inc.c:64: + .string^I\"GNU\"\n\$ ERROR: code indent should never use tabs #185: FILE: tests/tcg/aarch64/bti-crt.inc.c:65: +^I.long^I0xc0000000\n\$ ERROR: code indent should never use tabs #186: FILE: tests/tcg/aarch64/bti-crt.inc.c:66: +^I.long^I4\n\$ ERROR: code indent should never use tabs #187: FILE: tests/tcg/aarch64/bti-crt.inc.c:67: +^I.long^I1\n\$ ERROR: code indent should never use tabs #189: FILE: tests/tcg/aarch64/bti-crt.inc.c:69: +^I.previous");$ total: 12 errors, 1 warnings, 153 lines checked Patch 6/6 has style problems, please review. If any of these errors are false positives report them to the maintainer, see CHECKPATCH in MAINTAINERS. === OUTPUT END === Test command exited with code: 1 The full log is available at http://patchew.org/logs/20190605205706.569-1-richard.henderson@linaro.org/testing.checkpatch/?type=message. --- Email generated automatically by Patchew [https://patchew.org/]. Please send your feedback to patchew-devel@redhat.com
Dave Martin has recently posted a kernel patch set for supporting ARMv8.5 Branch Target Identification in userland. http://lists.infradead.org/pipermail/linux-arm-kernel/2019-May/654654.html While that support is not yet in the upstream kernel, it looks to be close to its final form. Note that the patch set spells this PROT_BTI_GUARDED, but review suggested to rename to PROT_BTI. Changes since v5: * New function to validate the target PROT parameter for mmap/mprotect. * Require BTI in the cpu for PROT_BTI set. * Set PSTATE.BTYPE=2 for the signal handler. Adjust the smoke test to match. * Tidy up the note parsing. r~ Richard Henderson (6): linux-user/aarch64: Reset btype for syscalls and signals linux-user: Validate mmap/mprotect prot value linux-user: Set PAGE_TARGET_1 for TARGET_PROT_BTI include/elf: Add defines related to notes for GNU systems linux-user: Parse NT_GNU_PROPERTY_TYPE_0 notes tests/tcg/aarch64: Add bti smoke test include/elf.h | 48 ++++++++++++ include/exec/cpu-all.h | 2 + linux-user/syscall_defs.h | 4 + linux-user/aarch64/cpu_loop.c | 7 ++ linux-user/aarch64/signal.c | 10 ++- linux-user/elfload.c | 83 ++++++++++++++++++-- linux-user/mmap.c | 122 ++++++++++++++++++++++-------- target/arm/translate-a64.c | 6 +- tests/tcg/aarch64/bti-1.c | 77 +++++++++++++++++++ tests/tcg/aarch64/bti-crt.inc.c | 69 +++++++++++++++++ tests/tcg/aarch64/Makefile.target | 3 + 11 files changed, 387 insertions(+), 44 deletions(-) create mode 100644 tests/tcg/aarch64/bti-1.c create mode 100644 tests/tcg/aarch64/bti-crt.inc.c -- 2.17.1