mbox series

[0/5] Add pinconf support for BM1880 SoC

Message ID 20190520083101.10229-1-manivannan.sadhasivam@linaro.org
Headers show
Series Add pinconf support for BM1880 SoC | expand

Message

Manivannan Sadhasivam May 20, 2019, 8:30 a.m. UTC 
Hi Linus,

This patchset adds pinconf support for Bitmain BM1880 SoC. In the previous
patchset adding pinctrl support, I declared that the SoC doesn't support
pinconf settings but further interaction with Bitmain engineers revealed
that the SoC does support it and hence this patchset.

Currently, there is no drive strength support added but it will come later.
Also, the current driver has some code to set pinmux in dedicated PWM
registers separately which is not needed, so I removed those and simplified
the driver.

Thanks,
Mani

Manivannan Sadhasivam (5):
  dt-bindings: pinctrl: Modify pinctrl memory map
  arm64: dts: bitmain: Modify pin controller memory map
  pinctrl: Rework the pinmux handling for BM1880 SoC
  dt-bindings: pinctrl: Document pinconf bindings for BM1880 SoC
  pinctrl: Add pinconf support for BM1880 SoC

 .../pinctrl/bitmain,bm1880-pinctrl.txt        |  23 +-
 arch/arm64/boot/dts/bitmain/bm1880.dtsi       |   4 +-
 drivers/pinctrl/pinctrl-bm1880.c              | 455 +++++++++++-------
 3 files changed, 304 insertions(+), 178 deletions(-)

-- 
2.17.1

Comments

Linus Walleij May 24, 2019, 11:51 a.m. UTC | #1 
On Mon, May 20, 2019 at 10:31 AM Manivannan Sadhasivam
<manivannan.sadhasivam@linaro.org> wrote:

> Earlier, the PWM registers were included as part of the pinctrl memory

> map, but this turned to be useless as the muxing is being handled by the

> SoC pin controller itself. Hence, this commit removes the pwm register

> mapping from the pinctrl node to make it more clean.

>

> Fixes: af2ff87de413 ("arm64: dts: bitmain: Add pinctrl support for BM1880 SoC")

> Signed-off-by: Manivannan Sadhasivam <manivannan.sadhasivam@linaro.org>


Acked-by: Linus Walleij <linus.walleij@linaro.org>


Please funnel this through ARM SoC.

Yours,
Linus Walleij
Linus Walleij May 24, 2019, 11:54 a.m. UTC | #2 
On Mon, May 20, 2019 at 10:31 AM Manivannan Sadhasivam
<manivannan.sadhasivam@linaro.org> wrote:

> Add pinconf support for Bitmain BM1880 SoC. Pinconf support includes

> pin bias, slew rate and schmitt trigger. Drive strength support will

> be added later.

>

> Signed-off-by: Manivannan Sadhasivam <manivannan.sadhasivam@linaro.org>


Patch applied.

Yours,
Linus Walleij