mbox series

[v3,0/2] arm: aspeed: Add RTC Model

Message ID 20190430044036.1144-1-joel@jms.id.au
Headers show
Series arm: aspeed: Add RTC Model | expand

Message

Joel Stanley April 30, 2019, 4:40 a.m. UTC 
v3: Add some commit messages, resend as v2 didn't send properly
v2: Minor fixes, added vmstate and reset, and rebased on Cédric's series

Based-on: 20190411161013.4514-4-clg@kaod.org
[PATCH 3/3] aspeed: use sysbus_init_child_obj() to initialize children

A model for the ASPEED BMC real time clock (RTC). The model is sufficient
for running the guest Linux kernel driver, and ticks in time with the
host when programmed.

It does not implement the alarm functionality, which includes the
interrupt.

Joel Stanley (2):
  hw: timer: Add ASPEED RTC device
  hw/arm/aspeed: Add RTC to SoC

 hw/arm/aspeed_soc.c           |  13 +++
 hw/timer/Makefile.objs        |   2 +-
 hw/timer/aspeed_rtc.c         | 180 ++++++++++++++++++++++++++++++++++
 hw/timer/trace-events         |   4 +
 include/hw/arm/aspeed_soc.h   |   2 +
 include/hw/timer/aspeed_rtc.h |  31 ++++++
 6 files changed, 231 insertions(+), 1 deletion(-)
 create mode 100644 hw/timer/aspeed_rtc.c
 create mode 100644 include/hw/timer/aspeed_rtc.h

-- 
2.20.1

Comments

Peter Maydell May 3, 2019, 1:36 p.m. UTC | #1 
On Tue, 30 Apr 2019 at 05:40, Joel Stanley <joel@jms.id.au> wrote:
>

> v3: Add some commit messages, resend as v2 didn't send properly

> v2: Minor fixes, added vmstate and reset, and rebased on Cédric's series

>

> Based-on: 20190411161013.4514-4-clg@kaod.org

> [PATCH 3/3] aspeed: use sysbus_init_child_obj() to initialize children

>

> A model for the ASPEED BMC real time clock (RTC). The model is sufficient

> for running the guest Linux kernel driver, and ticks in time with the

> host when programmed.

>

> It does not implement the alarm functionality, which includes the

> interrupt.


Hi -- I've reviewed this series, but can't apply it yet as
it's based on Cedric's patchset which needs a respin. If
I forget to apply this when I apply the respin of that one,
please ping me...

thanks
-- PMM
Cédric Le Goater May 6, 2019, 12:17 p.m. UTC | #2 
On 5/3/19 3:36 PM, Peter Maydell wrote:
> On Tue, 30 Apr 2019 at 05:40, Joel Stanley <joel@jms.id.au> wrote:

>>

>> v3: Add some commit messages, resend as v2 didn't send properly

>> v2: Minor fixes, added vmstate and reset, and rebased on Cédric's series

>>

>> Based-on: 20190411161013.4514-4-clg@kaod.org

>> [PATCH 3/3] aspeed: use sysbus_init_child_obj() to initialize children

>>

>> A model for the ASPEED BMC real time clock (RTC). The model is sufficient

>> for running the guest Linux kernel driver, and ticks in time with the

>> host when programmed.

>>

>> It does not implement the alarm functionality, which includes the

>> interrupt.

> 

> Hi -- I've reviewed this series, but can't apply it yet as

> it's based on Cedric's patchset which needs a respin. If

> I forget to apply this when I apply the respin of that one,

> please ping me...


I will work on a fix ASAP.

Thanks,

C.