| Message ID | 20190423212254.9504-1-ndesaulniers@google.com |
|---|---|
| State | Accepted |
| Commit | fd7f744caed82dcfd3a23bce8843836d6e94d584 |
| Headers | show |
| Series | riscv: vdso: drop unnecessary cc-ldoption | expand |
On Tue, Apr 23, 2019 at 02:22:53PM -0700, Nick Desaulniers wrote: > Towards the goal of removing cc-ldoption, it seems that --hash-style= > was added to binutils 2.17.50.0.2 in 2006. The minimal required version > of binutils for the kernel according to > Documentation/process/changes.rst is 2.20. Looks good, Reviewed-by: Christoph Hellwig <hch@lst.de>
On Tue, 23 Apr 2019 23:20:20 PDT (-0700), Christoph Hellwig wrote: > On Tue, Apr 23, 2019 at 02:22:53PM -0700, Nick Desaulniers wrote: >> Towards the goal of removing cc-ldoption, it seems that --hash-style= >> was added to binutils 2.17.50.0.2 in 2006. The minimal required version >> of binutils for the kernel according to >> Documentation/process/changes.rst is 2.20. > > Looks good, > > Reviewed-by: Christoph Hellwig <hch@lst.de> Thanks! This in on for-next.
diff --git a/arch/riscv/kernel/vdso/Makefile b/arch/riscv/kernel/vdso/Makefile index fec62b24df89..b07b765f312a 100644 --- a/arch/riscv/kernel/vdso/Makefile +++ b/arch/riscv/kernel/vdso/Makefile @@ -36,7 +36,7 @@ $(obj)/vdso.so.dbg: $(src)/vdso.lds $(obj-vdso) FORCE # these symbols in the kernel code rather than hand-coded addresses. SYSCFLAGS_vdso.so.dbg = -shared -s -Wl,-soname=linux-vdso.so.1 \ - $(call cc-ldoption, -Wl$(comma)--hash-style=both) + -Wl,--hash-style=both $(obj)/vdso-dummy.o: $(src)/vdso.lds $(obj)/rt_sigreturn.o FORCE $(call if_changed,vdsold)
Towards the goal of removing cc-ldoption, it seems that --hash-style= was added to binutils 2.17.50.0.2 in 2006. The minimal required version of binutils for the kernel according to Documentation/process/changes.rst is 2.20. Link: https://gcc.gnu.org/ml/gcc/2007-01/msg01141.html Cc: clang-built-linux@googlegroups.com Suggested-by: Masahiro Yamada <yamada.masahiro@socionext.com> Signed-off-by: Nick Desaulniers <ndesaulniers@google.com> --- arch/riscv/kernel/vdso/Makefile | 2 +- 1 file changed, 1 insertion(+), 1 deletion(-) -- 2.21.0.593.g511ec345e18-goog