| Message ID | 20190328230404.12909-1-richard.henderson@linaro.org |
|---|---|
| Headers | show |
| Series | tcg: Move the softmmu tlb to CPUNegativeOffsetState | expand |
Patchew URL: https://patchew.org/QEMU/20190328230404.12909-1-richard.henderson@linaro.org/
Hi,
This series seems to have some coding style problems. See output below for
more information:
Message-id: 20190328230404.12909-1-richard.henderson@linaro.org
Subject: [Qemu-devel] [PATCH for-4.1 v2 00/36] tcg: Move the softmmu tlb to CPUNegativeOffsetState
Type: series
=== TEST SCRIPT BEGIN ===
#!/bin/bash
git rev-parse base > /dev/null || exit 0
git config --local diff.renamelimit 0
git config --local diff.renames True
git config --local diff.algorithm histogram
./scripts/checkpatch.pl --mailback base..
=== TEST SCRIPT END ===
Updating 3c8cf5a9c21ff8782164d1def7f44bd888713384
From https://github.com/patchew-project/qemu
t [tag update] patchew/20190328133503.6490-1-peter.maydell@linaro.org -> patchew/20190328133503.6490-1-peter.maydell@linaro.org
t [tag update] patchew/20190328143003.16702-1-peter.maydell@linaro.org -> patchew/20190328143003.16702-1-peter.maydell@linaro.org
t [tag update] patchew/20190328152635.2794-1-peter.maydell@linaro.org -> patchew/20190328152635.2794-1-peter.maydell@linaro.org
t [tag update] patchew/20190328152944.3199-1-peter.maydell@linaro.org -> patchew/20190328152944.3199-1-peter.maydell@linaro.org
* [new tag] patchew/20190328230404.12909-1-richard.henderson@linaro.org -> patchew/20190328230404.12909-1-richard.henderson@linaro.org
Auto packing the repository in background for optimum performance.
See "git help gc" for manual housekeeping.
Switched to a new branch 'test'
f9a66881e4 tcg/arm: Use LDRD to load tlb mask+table
a586dfdc11 tcg/aarch64: Use LDP to load tlb mask+table
7ef50708e7 cpu: Remove CPU_COMMON
7c6cb89b16 cpu: Move the softmmu tlb to CPUNegativeOffsetState
3543e67ac0 cpu: Move icount_decr to CPUNegativeOffsetState
113e6c106f cpu: Introduce CPUNegativeOffsetState
95d493bf38 cpu: Introduce cpu_set_cpustate_pointers
34c8a29e55 cpu: Move ENV_OFFSET to exec/gen-icount.h
dd15a5a8c7 target/xtensa: Use env_cpu, env_archcpu
a95792f513 target/unicore32: Use env_cpu, env_archcpu
5c574e3f08 target/tricore: Use env_cpu
17a6f23a59 target/tilegx: Use env_cpu
a6ab5b9053 target/sparc: Use env_cpu, env_archcpu
2818ba16bf target/sh4: Use env_cpu, env_archcpu
950b4f85e6 target/s390x: Use env_cpu, env_archcpu
ca5cfd47a6 target/riscv: Use env_cpu, env_archcpu
b66b95baa1 target/ppc: Use env_cpu, env_archcpu
ddb073ba26 target/openrisc: Use env_cpu, env_archcpu
2e474a6b7d target/nios2: Use env_cpu, env_archcpu
3825a5e3dd target/moxie: Use env_cpu, env_archcpu
0bbc8862a5 target/mips: Use env_cpu, env_archcpu
0583f518fa target/microblaze: Use env_cpu, env_archcpu
c2cf5d2738 target/m68k: Use env_cpu, env_archcpu
65f2736258 target/lm32: Use env_cpu, env_archcpu
928c5fa23c target/i386: Use env_cpu, env_archcpu
6302562a79 target/hppa: Use env_cpu, env_archcpu
745b9da831 target/cris: Use env_cpu, env_archcpu
71ddd63a36 target/arm: Use env_cpu, env_archcpu
a9d03a568d target/alpha: Use env_cpu, env_archcpu
a7dd6ee21d cpu: Introduce env_archcpu
def257dbab cpu: Replace ENV_GET_CPU with env_cpu
3f602af99d cpu: Define ArchCPU
f1145468e6 cpu: Define CPUArchState with typedef
53b9e78cca tcg: Create struct CPUTLB
73e019c8f9 tcg: Split out target/arch/cpu-param.h
2c6d24b7d4 tcg: Fold CPUTLBWindow into CPUTLBDesc
=== OUTPUT BEGIN ===
1/36 Checking commit 2c6d24b7d40f (tcg: Fold CPUTLBWindow into CPUTLBDesc)
2/36 Checking commit 73e019c8f909 (tcg: Split out target/arch/cpu-param.h)
WARNING: added, moved or deleted file(s), does MAINTAINERS need updating?
#56:
new file mode 100644
WARNING: Block comments use a leading /* on a separate line
#357: FILE: target/i386/cpu-param.h:4:
+/* ??? This is really 48 bits, sign-extended, but the only thing
WARNING: Block comments use * on subsequent lines
#358: FILE: target/i386/cpu-param.h:5:
+/* ??? This is really 48 bits, sign-extended, but the only thing
+ accessible to userland with bit 48 set is the VSYSCALL, and that
WARNING: Block comments use a trailing */ on a separate line
#359: FILE: target/i386/cpu-param.h:6:
+ is handled via other mechanisms. */
WARNING: Block comments use a leading /* on a separate line
#466: FILE: target/m68k/cpu-param.h:2:
+/* Coldfire Linux uses 8k pages
ERROR: code indent should never use tabs
#1024: FILE: target/sh4/cpu-param.h:2:
+#define TARGET_PAGE_BITS 12^I/* 4k */$
total: 1 errors, 5 warnings, 1030 lines checked
Patch 2/36 has style problems, please review. If any of these errors
are false positives report them to the maintainer, see
CHECKPATCH in MAINTAINERS.
3/36 Checking commit 53b9e78ccaf7 (tcg: Create struct CPUTLB)
WARNING: line over 80 characters
#350: FILE: accel/tcg/cputlb.c:781:
+ env_tlb(env)->d[mmu_idx].viotlb[vidx] = env_tlb(env)->d[mmu_idx].iotlb[index];
total: 0 errors, 1 warnings, 677 lines checked
Patch 3/36 has style problems, please review. If any of these errors
are false positives report them to the maintainer, see
CHECKPATCH in MAINTAINERS.
4/36 Checking commit f1145468e661 (cpu: Define CPUArchState with typedef)
5/36 Checking commit 3f602af99da2 (cpu: Define ArchCPU)
6/36 Checking commit def257dbabdb (cpu: Replace ENV_GET_CPU with env_cpu)
7/36 Checking commit a7dd6ee21d47 (cpu: Introduce env_archcpu)
8/36 Checking commit a9d03a568d8f (target/alpha: Use env_cpu, env_archcpu)
9/36 Checking commit 71ddd63a36f3 (target/arm: Use env_cpu, env_archcpu)
10/36 Checking commit 745b9da8311a (target/cris: Use env_cpu, env_archcpu)
ERROR: suspect code indent for conditional statements (24, 16)
#96: FILE: target/cris/op_helper.c:141:
if (tlb_v) {
+ tlb_flush_page(env_cpu(env), vaddr);
total: 1 errors, 0 warnings, 76 lines checked
Patch 10/36 has style problems, please review. If any of these errors
are false positives report them to the maintainer, see
CHECKPATCH in MAINTAINERS.
11/36 Checking commit 6302562a7979 (target/hppa: Use env_cpu, env_archcpu)
12/36 Checking commit 928c5fa23cb7 (target/i386: Use env_cpu, env_archcpu)
13/36 Checking commit 65f273625801 (target/lm32: Use env_cpu, env_archcpu)
14/36 Checking commit c2cf5d2738d0 (target/m68k: Use env_cpu, env_archcpu)
15/36 Checking commit 0583f518fa3f (target/microblaze: Use env_cpu, env_archcpu)
16/36 Checking commit 0bbc8862a577 (target/mips: Use env_cpu, env_archcpu)
17/36 Checking commit 3825a5e3dd7f (target/moxie: Use env_cpu, env_archcpu)
18/36 Checking commit 2e474a6b7dc0 (target/nios2: Use env_cpu, env_archcpu)
19/36 Checking commit ddb073ba26a6 (target/openrisc: Use env_cpu, env_archcpu)
20/36 Checking commit b66b95baa16e (target/ppc: Use env_cpu, env_archcpu)
21/36 Checking commit ca5cfd47a6c9 (target/riscv: Use env_cpu, env_archcpu)
22/36 Checking commit 950b4f85e669 (target/s390x: Use env_cpu, env_archcpu)
23/36 Checking commit 2818ba16bff7 (target/sh4: Use env_cpu, env_archcpu)
24/36 Checking commit a6ab5b9053ed (target/sparc: Use env_cpu, env_archcpu)
25/36 Checking commit 17a6f23a59c7 (target/tilegx: Use env_cpu)
26/36 Checking commit 5c574e3f088c (target/tricore: Use env_cpu)
27/36 Checking commit a95792f513ad (target/unicore32: Use env_cpu, env_archcpu)
28/36 Checking commit dd15a5a8c7ea (target/xtensa: Use env_cpu, env_archcpu)
29/36 Checking commit 34c8a29e5557 (cpu: Move ENV_OFFSET to exec/gen-icount.h)
30/36 Checking commit 95d493bf38bd (cpu: Introduce cpu_set_cpustate_pointers)
31/36 Checking commit 113e6c106fca (cpu: Introduce CPUNegativeOffsetState)
32/36 Checking commit 3543e67ac0a3 (cpu: Move icount_decr to CPUNegativeOffsetState)
ERROR: return is not a function, parentheses are not required
#191: FILE: cpus.c:240:
+ return (cpu->icount_budget -
total: 1 errors, 0 warnings, 326 lines checked
Patch 32/36 has style problems, please review. If any of these errors
are false positives report them to the maintainer, see
CHECKPATCH in MAINTAINERS.
33/36 Checking commit 7c6cb89b161e (cpu: Move the softmmu tlb to CPUNegativeOffsetState)
34/36 Checking commit 7ef50708e758 (cpu: Remove CPU_COMMON)
35/36 Checking commit a586dfdc11a5 (tcg/aarch64: Use LDP to load tlb mask+table)
36/36 Checking commit f9a66881e4de (tcg/arm: Use LDRD to load tlb mask+table)
=== OUTPUT END ===
Test command exited with code: 1
The full log is available at
http://patchew.org/logs/20190328230404.12909-1-richard.henderson@linaro.org/testing.checkpatch/?type=message.
---
Email generated automatically by Patchew [https://patchew.org/].
Please send your feedback to patchew-devel@redhat.com
On Fri, 29 Mar 2019 at 00:44, <no-reply@patchew.org> wrote: > > Patchew URL: https://patchew.org/QEMU/20190328230404.12909-1-richard.henderson@linaro.org/ > > > > Hi, > > This series seems to have some coding style problems. See output below for > more information: Richard -- at least some of these checkpatch nits look like they're real rather than false positives: could you have a look through them and fold in fixes where appropriate? thanks -- PMM