| Message ID | 20190304195536.1019650-1-arnd@arndb.de |
|---|---|
| State | Accepted |
| Commit | a23eab893476f67bd7572cdbf24498d647c86e48 |
| Headers | show |
| Series | HID: hid-asus: select CONFIG_POWER_SUPPLY | expand |
On Mon, Mar 4, 2019 at 8:55 PM Arnd Bergmann <arnd@arndb.de> wrote: > > The newly added power supply code fails to link when the power supply core > code is disabled: > > drivers/hid/hid-asus.o: In function `asus_battery_get_property': > hid-asus.c:(.text+0x11de): undefined reference to `power_supply_get_drvdata' > drivers/hid/hid-asus.o: In function `asus_probe': > hid-asus.c:(.text+0x170c): undefined reference to `devm_power_supply_register' > hid-asus.c:(.text+0x1734): undefined reference to `power_supply_powers' > drivers/hid/hid-asus.o: In function `asus_raw_event': > hid-asus.c:(.text+0x1914): undefined reference to `power_supply_changed' > > Select the subsystem from Kconfig as we do for other hid drivers already. > > Fixes: 6311d329e12a ("HID: hid-asus: Add BT keyboard dock battery monitoring support") > Signed-off-by: Arnd Bergmann <arnd@arndb.de> > --- Applied to for-5.1/upstream-fixes Cheers, Benjamin > drivers/hid/Kconfig | 1 + > 1 file changed, 1 insertion(+) > > diff --git a/drivers/hid/Kconfig b/drivers/hid/Kconfig > index 6ca8d322b487..4ca0cdfa6b33 100644 > --- a/drivers/hid/Kconfig > +++ b/drivers/hid/Kconfig > @@ -150,6 +150,7 @@ config HID_ASUS > tristate "Asus" > depends on LEDS_CLASS > depends on ASUS_WMI || ASUS_WMI=n > + select POWER_SUPPLY > ---help--- > Support for Asus notebook built-in keyboard and touchpad via i2c, and > the Asus Republic of Gamers laptop keyboard special keys. > -- > 2.20.0 >
diff --git a/drivers/hid/Kconfig b/drivers/hid/Kconfig index 6ca8d322b487..4ca0cdfa6b33 100644 --- a/drivers/hid/Kconfig +++ b/drivers/hid/Kconfig @@ -150,6 +150,7 @@ config HID_ASUS tristate "Asus" depends on LEDS_CLASS depends on ASUS_WMI || ASUS_WMI=n + select POWER_SUPPLY ---help--- Support for Asus notebook built-in keyboard and touchpad via i2c, and the Asus Republic of Gamers laptop keyboard special keys.
The newly added power supply code fails to link when the power supply core code is disabled: drivers/hid/hid-asus.o: In function `asus_battery_get_property': hid-asus.c:(.text+0x11de): undefined reference to `power_supply_get_drvdata' drivers/hid/hid-asus.o: In function `asus_probe': hid-asus.c:(.text+0x170c): undefined reference to `devm_power_supply_register' hid-asus.c:(.text+0x1734): undefined reference to `power_supply_powers' drivers/hid/hid-asus.o: In function `asus_raw_event': hid-asus.c:(.text+0x1914): undefined reference to `power_supply_changed' Select the subsystem from Kconfig as we do for other hid drivers already. Fixes: 6311d329e12a ("HID: hid-asus: Add BT keyboard dock battery monitoring support") Signed-off-by: Arnd Bergmann <arnd@arndb.de> --- drivers/hid/Kconfig | 1 + 1 file changed, 1 insertion(+) -- 2.20.0