| Message ID | 1551927501-14527-1-git-send-email-aisheng.dong@nxp.com |
|---|---|
| State | New |
| Headers | show |
| Series | [1/1] pinctrl: imx: fix scu link errors | expand |
On Thu, Mar 7, 2019 at 4:05 AM Aisheng Dong <aisheng.dong@nxp.com> wrote: > From: Anders Roxell <anders.roxell@linaro.org> > > Currently PINCTRL_IMX8QM and PINCTRL_IMX8QXP will select PINCTRL_IMX_SCU. > However, PINCTRL_IMX_SCU may not be valid due to it depends on IMX_MBOX. > Then we may meet the following link errors: > ld: drivers/pinctrl/freescale/pinctrl-scu.o: in function `imx_pinctrl_sc_ipc_init': > pinctrl-scu.c:(.text+0x10): undefined reference to `imx_scu_get_handle' > ld: pinctrl-scu.c:(.text+0x10): relocation truncated to fit: R_AARCH64_CALL26 against undefined symbol `imx_scu_get_handle' > ld: drivers/pinctrl/freescale/pinctrl-scu.o: in function `imx_pinconf_get_scu': > pinctrl-scu.c:(.text+0xa0): undefined reference to `imx_scu_call_rpc' > ld: pinctrl-scu.c:(.text+0xa0): relocation truncated to fit: R_AARCH64_CALL26 against undefined symbol `imx_scu_call_rpc' > ld: drivers/pinctrl/freescale/pinctrl-scu.o: in function `imx_pinconf_set_scu': > pinctrl-scu.c:(.text+0x1b4): undefined reference to `imx_scu_call_rpc' > ld: pinctrl-scu.c:(.text+0x1b4): relocation truncated to fit: R_AARCH64_CALL26 against undefined symbol `imx_scu_call_rpc' > ld: drivers/pinctrl/freescale/pinctrl-imx8qxp.o: in function `imx8qxp_pinctrl_probe': > pinctrl-imx8qxp.c:(.text+0x28): undefined reference to `imx_pinctrl_probe' > ld: pinctrl-imx8qxp.c:(.text+0x28): relocation truncated to fit: R_AARCH64_CALL26 against undefined symbol `imx_pinctrl_probe' > > Rework so that PINCTRL_IMX8QM and PINCTRL_IMX8QXP depends on IMX_SCU > as well in case they're wrongly enabled. > > Suggested-by: Arnd Bergmann <arnd@arndb.de> > Signed-off-by: Anders Roxell <anders.roxell@linaro.org> > Signed-off-by: Dong Aisheng <aisheng.dong@nxp.com> Patch applied. Yours, Linus Walleij
diff --git a/drivers/pinctrl/freescale/Kconfig b/drivers/pinctrl/freescale/Kconfig index e6dff31..0d83878 100644 --- a/drivers/pinctrl/freescale/Kconfig +++ b/drivers/pinctrl/freescale/Kconfig @@ -138,14 +138,14 @@ config PINCTRL_IMX8MQ config PINCTRL_IMX8QM bool "IMX8QM pinctrl driver" - depends on ARCH_MXC && ARM64 + depends on IMX_SCU && ARCH_MXC && ARM64 select PINCTRL_IMX_SCU help Say Y here to enable the imx8qm pinctrl driver config PINCTRL_IMX8QXP bool "IMX8QXP pinctrl driver" - depends on ARCH_MXC && ARM64 + depends on IMX_SCU && ARCH_MXC && ARM64 select PINCTRL_IMX_SCU help Say Y here to enable the imx8qxp pinctrl driver