diff mbox series

mainline/master boot bisection: v5.0-4854-g8dcd175bc3d5 on odroid-xu3

Message ID 5c80c49b.1c69fb81.605bf.26ea@mx.google.com
State Superseded
Headers show
Series mainline/master boot bisection: v5.0-4854-g8dcd175bc3d5 on odroid-xu3 | expand

Commit Message

kernelci.org bot March 7, 2019, 7:13 a.m. UTC 
* * * * * * * * * * * * * * * * * * * * * * * * * * * * * * * * *
* This automated bisection report was sent to you on the basis  *
* that you may be involved with the breaking commit it has      *
* found.  No manual investigation has been done to verify it,   *
* and the root cause of the problem may be somewhere else.      *
* Hope this helps!                                              *
* * * * * * * * * * * * * * * * * * * * * * * * * * * * * * * * *

mainline/master boot bisection: v5.0-4854-g8dcd175bc3d5 on odroid-xu3

Summary:
  Start:      8dcd175bc3d5 Merge branch 'akpm' (patches from Andrew)
  Details:    https://kernelci.org/boot/id/5c8052c159b5146b7bfe6018
  Plain log:  https://storage.kernelci.org//mainline/master/v5.0-4854-g8dcd175bc3d5/arm/exynos_defconfig/gcc-7/lab-collabora/boot-exynos5422-odroidxu3.txt
  HTML log:   https://storage.kernelci.org//mainline/master/v5.0-4854-g8dcd175bc3d5/arm/exynos_defconfig/gcc-7/lab-collabora/boot-exynos5422-odroidxu3.html
  Result:     0918f18c7179 crypto: s5p - add AES support for Exynos5433

Checks:
  revert:     PASS
  verify:     PASS

Parameters:
  Tree:       mainline
  URL:        git://git.kernel.org/pub/scm/linux/kernel/git/torvalds/linux.git
  Branch:     master
  Target:     odroid-xu3
  CPU arch:   arm
  Lab:        lab-collabora
  Compiler:   gcc-7
  Config:     exynos_defconfig
  Test suite: boot

Breaking commit found:

-------------------------------------------------------------------------------
commit 0918f18c7179e8cdf718d01531a81b28130b4217
Author: Kamil Konieczny <k.konieczny@partner.samsung.com>
Date:   Fri Feb 22 13:21:44 2019 +0100

    crypto: s5p - add AES support for Exynos5433
    
    Add AES crypto HW acceleration for Exynos5433, with the help of SlimSSS IP.
    
    Reviewed-by: Krzysztof Kozlowski <krzk@kernel.org>

    Signed-off-by: Kamil Konieczny <k.konieczny@partner.samsung.com>

    Signed-off-by: Herbert Xu <herbert@gondor.apana.org.au>



Git bisection log:

-------------------------------------------------------------------------------
git bisect start
# good: [a215ce8f0e00c2d707080236f1aafec337371043] Merge tag 'iommu-fix-v5.0-rc8' of git://git.kernel.org/pub/scm/linux/kernel/git/joro/iommu
git bisect good a215ce8f0e00c2d707080236f1aafec337371043
# bad: [8dcd175bc3d50b78413c56d5b17d4bddd77412ef] Merge branch 'akpm' (patches from Andrew)
git bisect bad 8dcd175bc3d50b78413c56d5b17d4bddd77412ef
# good: [096461de96a94c856190ba892ebf62dfba5a38f1] net/sched: avoid unused-label warning
git bisect good 096461de96a94c856190ba892ebf62dfba5a38f1
# bad: [3478588b5136966c80c571cf0006f08e9e5b8f04] Merge branch 'locking-core-for-linus' of git://git.kernel.org/pub/scm/linux/kernel/git/tip/tip
git bisect bad 3478588b5136966c80c571cf0006f08e9e5b8f04
# good: [6456300356433873309a1cae6aa05e77d6b59153] Merge git://git.kernel.org/pub/scm/linux/kernel/git/davem/net-next
git bisect good 6456300356433873309a1cae6aa05e77d6b59153
# bad: [8feed3efa8022107bcb3432ac3ec9917e078ae70] Merge branch 'parisc-5.1-1' of git://git.kernel.org/pub/scm/linux/kernel/git/deller/parisc-linux
git bisect bad 8feed3efa8022107bcb3432ac3ec9917e078ae70
# good: [cf64e495fe221479866c1ea7c6f5cd9698d8a3af] crypto: caam - weak key checking for cbc des, 3des
git bisect good cf64e495fe221479866c1ea7c6f5cd9698d8a3af
# good: [fcc082f35c6d565d351b5b89bb03a82333e9ffe8] Revert "s390/cpum_cf: Add kernel message exaplanations"
git bisect good fcc082f35c6d565d351b5b89bb03a82333e9ffe8
# good: [d3ff9f851b7ad892df8dc168f0d589308fb42ac3] dt-bindings: crypto: document Exynos5433 SlimSSS
git bisect good d3ff9f851b7ad892df8dc168f0d589308fb42ac3
# good: [d578bf28cfc40375b4fc9f7571a3faf17bd2373c] parisc: Add constant for PDC_PAT_COMPLEX firmware call
git bisect good d578bf28cfc40375b4fc9f7571a3faf17bd2373c
# good: [bf6341664ad16070bed675bec659aa54b161ed82] m68k/apollo: Fix comment in Makefile
git bisect good bf6341664ad16070bed675bec659aa54b161ed82
# bad: [eac616557050737a8d6ef6fe0322d0980ff0ffde] x86: Deprecate a.out support
git bisect bad eac616557050737a8d6ef6fe0322d0980ff0ffde
# bad: [63bdf4284c38a48af21745ceb148a087b190cd21] Merge branch 'linus' of git://git.kernel.org/pub/scm/linux/kernel/git/herbert/crypto-2.6
git bisect bad 63bdf4284c38a48af21745ceb148a087b190cd21
# bad: [0918f18c7179e8cdf718d01531a81b28130b4217] crypto: s5p - add AES support for Exynos5433
git bisect bad 0918f18c7179e8cdf718d01531a81b28130b4217
# first bad commit: [0918f18c7179e8cdf718d01531a81b28130b4217] crypto: s5p - add AES support for Exynos5433
-------------------------------------------------------------------------------

Comments

Krzysztof Kozlowski March 7, 2019, 7:30 a.m. UTC | #1 
On Thu, 7 Mar 2019 at 08:13, kernelci.org bot <bot@kernelci.org> wrote:
>

> * * * * * * * * * * * * * * * * * * * * * * * * * * * * * * * * *

> * This automated bisection report was sent to you on the basis  *

> * that you may be involved with the breaking commit it has      *

> * found.  No manual investigation has been done to verify it,   *

> * and the root cause of the problem may be somewhere else.      *

> * Hope this helps!                                              *

> * * * * * * * * * * * * * * * * * * * * * * * * * * * * * * * * *

>

> mainline/master boot bisection: v5.0-4854-g8dcd175bc3d5 on odroid-xu3

>

> Summary:

>   Start:      8dcd175bc3d5 Merge branch 'akpm' (patches from Andrew)

>   Details:    https://kernelci.org/boot/id/5c8052c159b5146b7bfe6018

>   Plain log:  https://storage.kernelci.org//mainline/master/v5.0-4854-g8dcd175bc3d5/arm/exynos_defconfig/gcc-7/lab-collabora/boot-exynos5422-odroidxu3.txt

>   HTML log:   https://storage.kernelci.org//mainline/master/v5.0-4854-g8dcd175bc3d5/arm/exynos_defconfig/gcc-7/lab-collabora/boot-exynos5422-odroidxu3.html

>   Result:     0918f18c7179 crypto: s5p - add AES support for Exynos5433

>

> Checks:

>   revert:     PASS

>   verify:     PASS


Thanks bot!
It is already known and patch is waiting to be applied:
https://patchwork.kernel.org/patch/10835389/

Best regards,
Krzysztof
diff mbox series

Patch

diff --git a/drivers/crypto/s5p-sss.c b/drivers/crypto/s5p-sss.c
index 8d0afdc220ff..f4e625cf53ca 100644
--- a/drivers/crypto/s5p-sss.c
+++ b/drivers/crypto/s5p-sss.c
@@ -232,6 +232,7 @@ 
  * struct samsung_aes_variant - platform specific SSS driver data
  * @aes_offset: AES register offset from SSS module's base.
  * @hash_offset: HASH register offset from SSS module's base.
+ * @clk_names: names of clocks needed to run SSS IP
  *
  * Specifies platform specific configuration of SSS module.
  * Note: A structure for driver specific platform data is used for future
@@ -240,6 +241,7 @@ 
 struct samsung_aes_variant {
 	unsigned int			aes_offset;
 	unsigned int			hash_offset;
+	const char			*clk_names[];
 };
 
 struct s5p_aes_reqctx {
@@ -296,6 +298,7 @@  struct s5p_aes_ctx {
 struct s5p_aes_dev {
 	struct device			*dev;
 	struct clk			*clk;
+	struct clk			*pclk;
 	void __iomem			*ioaddr;
 	void __iomem			*aes_ioaddr;
 	int				irq_fc;
@@ -384,11 +387,19 @@  struct s5p_hash_ctx {
 static const struct samsung_aes_variant s5p_aes_data = {
 	.aes_offset	= 0x4000,
 	.hash_offset	= 0x6000,
+	.clk_names	= { "secss", },
 };
 
 static const struct samsung_aes_variant exynos_aes_data = {
 	.aes_offset	= 0x200,
 	.hash_offset	= 0x400,
+	.clk_names	= { "secss", },
+};
+
+static const struct samsung_aes_variant exynos5433_slim_aes_data = {
+	.aes_offset	= 0x400,
+	.hash_offset	= 0x800,
+	.clk_names	= { "pclk", "aclk", },
 };
 
 static const struct of_device_id s5p_sss_dt_match[] = {
@@ -400,6 +411,10 @@  static const struct of_device_id s5p_sss_dt_match[] = {
 		.compatible = "samsung,exynos4210-secss",
 		.data = &exynos_aes_data,
 	},
+	{
+		.compatible = "samsung,exynos5433-slim-sss",
+		.data = &exynos5433_slim_aes_data,
+	},
 	{ },
 };
 MODULE_DEVICE_TABLE(of, s5p_sss_dt_match);
@@ -2218,18 +2233,39 @@  static int s5p_aes_probe(struct platform_device *pdev)
 			return PTR_ERR(pdata->ioaddr);
 	}
 
-	pdata->clk = devm_clk_get(dev, "secss");
+	pdata->clk = devm_clk_get(dev, variant->clk_names[0]);
 	if (IS_ERR(pdata->clk)) {
-		dev_err(dev, "failed to find secss clock source\n");
+		dev_err(dev, "failed to find secss clock %s\n",
+			variant->clk_names[0]);
 		return -ENOENT;
 	}
 
 	err = clk_prepare_enable(pdata->clk);
 	if (err < 0) {
-		dev_err(dev, "Enabling SSS clk failed, err %d\n", err);
+		dev_err(dev, "Enabling clock %s failed, err %d\n",
+			variant->clk_names[0], err);
 		return err;
 	}
 
+	if (variant->clk_names[1]) {
+		pdata->pclk = devm_clk_get(dev, variant->clk_names[1]);
+		if (IS_ERR(pdata->pclk)) {
+			dev_err(dev, "failed to find clock %s\n",
+				variant->clk_names[1]);
+			err = -ENOENT;
+			goto err_clk;
+		}
+
+		err = clk_prepare_enable(pdata->pclk);
+		if (err < 0) {
+			dev_err(dev, "Enabling clock %s failed, err %d\n",
+				variant->clk_names[0], err);
+			goto err_clk;
+		}
+	} else {
+		pdata->pclk = NULL;
+	}
+
 	spin_lock_init(&pdata->lock);
 	spin_lock_init(&pdata->hash_lock);
 
@@ -2305,8 +2341,11 @@  static int s5p_aes_probe(struct platform_device *pdev)
 	tasklet_kill(&pdata->tasklet);
 
 err_irq:
-	clk_disable_unprepare(pdata->clk);
+	if (pdata->pclk)
+		clk_disable_unprepare(pdata->pclk);
 
+err_clk:
+	clk_disable_unprepare(pdata->clk);
 	s5p_dev = NULL;
 
 	return err;
@@ -2333,6 +2372,9 @@  static int s5p_aes_remove(struct platform_device *pdev)
 		pdata->use_hash = false;
 	}
 
+	if (pdata->pclk)
+		clk_disable_unprepare(pdata->pclk);
+
 	clk_disable_unprepare(pdata->clk);
 	s5p_dev = NULL;
-------------------------------------------------------------------------------