| Message ID | 20190218174032.22972-1-salil.mehta@huawei.com |
|---|---|
| State | Accepted |
| Commit | 4d96e13ee9cd1f7f801e8c7f4b12f09d1da4a5d8 |
| Headers | show |
| Series | [net] net: hns: Fixes the missing put_device in positive leg for roce reset | expand |
From: Salil Mehta <salil.mehta@huawei.com> Date: Mon, 18 Feb 2019 17:40:32 +0000 > This patch fixes the missing device reference release-after-use in > the positive leg of the roce reset API of the HNS DSAF. > > Fixes: c969c6e7ab8c ("net: hns: Fix object reference leaks in hns_dsaf_roce_reset()") > Reported-by: John Garry <john.garry@huawei.com> > Signed-off-by: Salil Mehta <salil.mehta@huawei.com> Applied, thanks Salil.
diff --git a/drivers/net/ethernet/hisilicon/hns/hns_dsaf_main.c b/drivers/net/ethernet/hisilicon/hns/hns_dsaf_main.c index b8155f5..ac55db0 100644 --- a/drivers/net/ethernet/hisilicon/hns/hns_dsaf_main.c +++ b/drivers/net/ethernet/hisilicon/hns/hns_dsaf_main.c @@ -3128,6 +3128,9 @@ int hns_dsaf_roce_reset(struct fwnode_handle *dsaf_fwnode, bool dereset) dsaf_set_bit(credit, DSAF_SBM_ROCEE_CFG_CRD_EN_B, 1); dsaf_write_dev(dsaf_dev, DSAF_SBM_ROCEE_CFG_REG_REG, credit); } + + put_device(&pdev->dev); + return 0; } EXPORT_SYMBOL(hns_dsaf_roce_reset);
This patch fixes the missing device reference release-after-use in the positive leg of the roce reset API of the HNS DSAF. Fixes: c969c6e7ab8c ("net: hns: Fix object reference leaks in hns_dsaf_roce_reset()") Reported-by: John Garry <john.garry@huawei.com> Signed-off-by: Salil Mehta <salil.mehta@huawei.com> --- drivers/net/ethernet/hisilicon/hns/hns_dsaf_main.c | 3 +++ 1 file changed, 3 insertions(+) -- 2.7.4