Message ID | 20190206052857.5077-1-richard.henderson@linaro.org |
---|---|
Headers | show |
Series | target/arm: Implement ARMv8.3-JSConv | expand |
On Wed, 6 Feb 2019 at 05:29, Richard Henderson <richard.henderson@linaro.org> wrote: > > Changes since v1: > * Typo fixed in patch 2, which had scrogged FMOV > * Return 0 for NaN, as for any other ARM fp conversion. > > > r~ > > > Richard Henderson (3): > target/arm: Force result size into dp after operation > target/arm: Restructure disas_fp_int_conv > target/arm: Implement ARMv8.3-JSConv I've applied patches 1 and 2 to target-arm.next; 3 has a bug in it, I think. thanks -- PMM
On 2/14/19 5:53 AM, Peter Maydell wrote: > On Wed, 6 Feb 2019 at 05:29, Richard Henderson > <richard.henderson@linaro.org> wrote: >> >> Changes since v1: >> * Typo fixed in patch 2, which had scrogged FMOV >> * Return 0 for NaN, as for any other ARM fp conversion. >> >> >> r~ >> >> >> Richard Henderson (3): >> target/arm: Force result size into dp after operation >> target/arm: Restructure disas_fp_int_conv >> target/arm: Implement ARMv8.3-JSConv > > I've applied patches 1 and 2 to target-arm.next; 3 has a bug in it, > I think. Please dequeue patch 2; patch 3 has more than one bug in it, and I need to rewrite patch 2 as well. r~
On 2/14/19 1:10 PM, Richard Henderson wrote: > On 2/14/19 5:53 AM, Peter Maydell wrote: >> On Wed, 6 Feb 2019 at 05:29, Richard Henderson >> <richard.henderson@linaro.org> wrote: >>> >>> Changes since v1: >>> * Typo fixed in patch 2, which had scrogged FMOV >>> * Return 0 for NaN, as for any other ARM fp conversion. >>> >>> >>> r~ >>> >>> >>> Richard Henderson (3): >>> target/arm: Force result size into dp after operation >>> target/arm: Restructure disas_fp_int_conv >>> target/arm: Implement ARMv8.3-JSConv >> >> I've applied patches 1 and 2 to target-arm.next; 3 has a bug in it, >> I think. > > Please dequeue patch 2; patch 3 has more than one bug in it, and I need to > rewrite patch 2 as well. Grr. That's patch 1, "force result size into dp" that I want dequeued. Of course, now I've seen your pull request, so if that's already gone through, I guess I can smoosh a revert with my rewrite? r~
On Thu, 14 Feb 2019 at 21:28, Richard Henderson <richard.henderson@linaro.org> wrote: > > On 2/14/19 1:10 PM, Richard Henderson wrote: > > On 2/14/19 5:53 AM, Peter Maydell wrote: > >> On Wed, 6 Feb 2019 at 05:29, Richard Henderson > >> <richard.henderson@linaro.org> wrote: > >>> > >>> Changes since v1: > >>> * Typo fixed in patch 2, which had scrogged FMOV > >>> * Return 0 for NaN, as for any other ARM fp conversion. > >>> > >>> > >>> r~ > >>> > >>> > >>> Richard Henderson (3): > >>> target/arm: Force result size into dp after operation > >>> target/arm: Restructure disas_fp_int_conv > >>> target/arm: Implement ARMv8.3-JSConv > >> > >> I've applied patches 1 and 2 to target-arm.next; 3 has a bug in it, > >> I think. > > > > Please dequeue patch 2; patch 3 has more than one bug in it, and I need to > > rewrite patch 2 as well. > > Grr. That's patch 1, "force result size into dp" that I want dequeued. > Of course, now I've seen your pull request, so if that's already gone through, > I guess I can smoosh a revert with my rewrite? I saw this before pushing the merge, so I've removed both patches 1 and 2 from target-arm.next and will resend the pullreq. thanks -- PMM