| Message ID | 20190116205059.3488-1-ard.biesheuvel@linaro.org |
|---|---|
| State | Accepted |
| Commit | 00755e1c8019cb073de85dea97737aedc10f352c |
| Headers | show |
| Series | [edk2] ArmPkg/DefaultExceptionHandlerLib: add missing UefiLib include | expand |
On Wed, Jan 16, 2019 at 09:50:59PM +0100, Ard Biesheuvel wrote: > Commit 31f5388006fc ("ArmPkg/DefaultExceptionHandlerLib: use console > if available") added calls to AsciiPrint() to the default exception > handler code, but the ARM version did not include UefiLib.h yet > (even though the .INF declares it unconditionally), resulting in > build breakage. So add the missing include. > > Contributed-under: TianoCore Contribution Agreement 1.1 > Signed-off-by: Ard Biesheuvel <ard.biesheuvel@linaro.org> Reviewed-by: Leif Lindholm <leif.lindholm@linaro.org> > --- > ArmPkg/Library/DefaultExceptionHandlerLib/Arm/DefaultExceptionHandler.c | 1 + > 1 file changed, 1 insertion(+) > > diff --git a/ArmPkg/Library/DefaultExceptionHandlerLib/Arm/DefaultExceptionHandler.c b/ArmPkg/Library/DefaultExceptionHandlerLib/Arm/DefaultExceptionHandler.c > index 2e0cfb2d4e03..476ec2061084 100644 > --- a/ArmPkg/Library/DefaultExceptionHandlerLib/Arm/DefaultExceptionHandler.c > +++ b/ArmPkg/Library/DefaultExceptionHandlerLib/Arm/DefaultExceptionHandler.c > @@ -22,6 +22,7 @@ > #include <Library/ArmDisassemblerLib.h> > #include <Library/SerialPortLib.h> > #include <Library/UefiBootServicesTableLib.h> > +#include <Library/UefiLib.h> > > #include <Guid/DebugImageInfoTable.h> > > -- > 2.17.1 > _______________________________________________ edk2-devel mailing list edk2-devel@lists.01.org https://lists.01.org/mailman/listinfo/edk2-devel
On Thu, 17 Jan 2019 at 10:36, Leif Lindholm <leif.lindholm@linaro.org> wrote: > > On Wed, Jan 16, 2019 at 09:50:59PM +0100, Ard Biesheuvel wrote: > > Commit 31f5388006fc ("ArmPkg/DefaultExceptionHandlerLib: use console > > if available") added calls to AsciiPrint() to the default exception > > handler code, but the ARM version did not include UefiLib.h yet > > (even though the .INF declares it unconditionally), resulting in > > build breakage. So add the missing include. > > > > Contributed-under: TianoCore Contribution Agreement 1.1 > > Signed-off-by: Ard Biesheuvel <ard.biesheuvel@linaro.org> > > Reviewed-by: Leif Lindholm <leif.lindholm@linaro.org> > Thanks Pushed as 3837e2e03840..00755e1c8019 > > --- > > ArmPkg/Library/DefaultExceptionHandlerLib/Arm/DefaultExceptionHandler.c | 1 + > > 1 file changed, 1 insertion(+) > > > > diff --git a/ArmPkg/Library/DefaultExceptionHandlerLib/Arm/DefaultExceptionHandler.c b/ArmPkg/Library/DefaultExceptionHandlerLib/Arm/DefaultExceptionHandler.c > > index 2e0cfb2d4e03..476ec2061084 100644 > > --- a/ArmPkg/Library/DefaultExceptionHandlerLib/Arm/DefaultExceptionHandler.c > > +++ b/ArmPkg/Library/DefaultExceptionHandlerLib/Arm/DefaultExceptionHandler.c > > @@ -22,6 +22,7 @@ > > #include <Library/ArmDisassemblerLib.h> > > #include <Library/SerialPortLib.h> > > #include <Library/UefiBootServicesTableLib.h> > > +#include <Library/UefiLib.h> > > > > #include <Guid/DebugImageInfoTable.h> > > > > -- > > 2.17.1 > > _______________________________________________ edk2-devel mailing list edk2-devel@lists.01.org https://lists.01.org/mailman/listinfo/edk2-devel
diff --git a/ArmPkg/Library/DefaultExceptionHandlerLib/Arm/DefaultExceptionHandler.c b/ArmPkg/Library/DefaultExceptionHandlerLib/Arm/DefaultExceptionHandler.c index 2e0cfb2d4e03..476ec2061084 100644 --- a/ArmPkg/Library/DefaultExceptionHandlerLib/Arm/DefaultExceptionHandler.c +++ b/ArmPkg/Library/DefaultExceptionHandlerLib/Arm/DefaultExceptionHandler.c @@ -22,6 +22,7 @@ #include <Library/ArmDisassemblerLib.h> #include <Library/SerialPortLib.h> #include <Library/UefiBootServicesTableLib.h> +#include <Library/UefiLib.h> #include <Guid/DebugImageInfoTable.h>
Commit 31f5388006fc ("ArmPkg/DefaultExceptionHandlerLib: use console if available") added calls to AsciiPrint() to the default exception handler code, but the ARM version did not include UefiLib.h yet (even though the .INF declares it unconditionally), resulting in build breakage. So add the missing include. Contributed-under: TianoCore Contribution Agreement 1.1 Signed-off-by: Ard Biesheuvel <ard.biesheuvel@linaro.org> --- ArmPkg/Library/DefaultExceptionHandlerLib/Arm/DefaultExceptionHandler.c | 1 + 1 file changed, 1 insertion(+) -- 2.17.1 _______________________________________________ edk2-devel mailing list edk2-devel@lists.01.org https://lists.01.org/mailman/listinfo/edk2-devel