| Message ID | 20181206095047.2811-1-nsekhar@ti.com |
|---|---|
| State | Accepted |
| Commit | d8e9cf4d473fc223c272301351becb29bd18ed2a |
| Headers | show |
| Series | [v2] common: fdt_support: print hexadecimal numbers in debug | expand |
On 06/12/18 3:20 PM, Sekhar Nori wrote: > We usually deal with hexadecimal addresses and sizes in > device-tree. Its much easier if debug logs print hexadecimal > values too. > > Reviewed-by: Simon Glass <sjg@chromium.org> > Signed-off-by: Sekhar Nori <nsekhar@ti.com> Reviewed-by: Lokesh Vutla <lokeshvutla@ti.com> Thanks and regards, Lokesh > --- > common/fdt_support.c | 4 ++-- > 1 file changed, 2 insertions(+), 2 deletions(-) > > diff --git a/common/fdt_support.c b/common/fdt_support.c > index 3440e42a257b..42583e3ed8c8 100644 > --- a/common/fdt_support.c > +++ b/common/fdt_support.c > @@ -1025,7 +1025,7 @@ static u64 of_bus_default_map(fdt32_t *addr, const fdt32_t *range, > s = fdt_read_number(range + na + pna, ns); > da = fdt_read_number(addr, na); > > - debug("OF: default map, cp=%llu, s=%llu, da=%llu\n", cp, s, da); > + debug("OF: default map, cp=%llx, s=%llx, da=%llx\n", cp, s, da); > > if (da < cp || da >= (cp + s)) > return OF_BAD_ADDR; > @@ -1080,7 +1080,7 @@ static u64 of_bus_isa_map(fdt32_t *addr, const fdt32_t *range, > s = fdt_read_number(range + na + pna, ns); > da = fdt_read_number(addr + 1, na - 1); > > - debug("OF: ISA map, cp=%llu, s=%llu, da=%llu\n", cp, s, da); > + debug("OF: ISA map, cp=%llx, s=%llx, da=%llx\n", cp, s, da); > > if (da < cp || da >= (cp + s)) > return OF_BAD_ADDR; >
On Thu, Dec 06, 2018 at 03:20:47PM +0530, Sekhar Nori wrote: > We usually deal with hexadecimal addresses and sizes in > device-tree. Its much easier if debug logs print hexadecimal > values too. > > Reviewed-by: Simon Glass <sjg@chromium.org> > Signed-off-by: Sekhar Nori <nsekhar@ti.com> Reviewed-by: Tom Rini <trini@konsulko.com> -- Tom
On Thu, Dec 06, 2018 at 03:20:47PM +0530, Sekhar Nori wrote: > We usually deal with hexadecimal addresses and sizes in > device-tree. Its much easier if debug logs print hexadecimal > values too. > > Reviewed-by: Simon Glass <sjg@chromium.org> > Signed-off-by: Sekhar Nori <nsekhar@ti.com> Reviewed-by: Tom Rini <trini@konsulko.com>
diff --git a/common/fdt_support.c b/common/fdt_support.c index 3440e42a257b..42583e3ed8c8 100644 --- a/common/fdt_support.c +++ b/common/fdt_support.c @@ -1025,7 +1025,7 @@ static u64 of_bus_default_map(fdt32_t *addr, const fdt32_t *range, s = fdt_read_number(range + na + pna, ns); da = fdt_read_number(addr, na); - debug("OF: default map, cp=%llu, s=%llu, da=%llu\n", cp, s, da); + debug("OF: default map, cp=%llx, s=%llx, da=%llx\n", cp, s, da); if (da < cp || da >= (cp + s)) return OF_BAD_ADDR; @@ -1080,7 +1080,7 @@ static u64 of_bus_isa_map(fdt32_t *addr, const fdt32_t *range, s = fdt_read_number(range + na + pna, ns); da = fdt_read_number(addr + 1, na - 1); - debug("OF: ISA map, cp=%llu, s=%llu, da=%llu\n", cp, s, da); + debug("OF: ISA map, cp=%llx, s=%llx, da=%llx\n", cp, s, da); if (da < cp || da >= (cp + s)) return OF_BAD_ADDR;