| Message ID | 20181211162021.760-1-semen.protsenko@linaro.org |
|---|---|
| State | Accepted |
| Commit | 528920f94ef22f9e5cf183cc193246e01280c65e |
| Headers | show |
| Series | arm: ti: boot: Increase system partition size | expand |
On 12/11/2018 10:20 AM, Sam Protsenko wrote: > Android code base is growing, so since Android "Pie" the size of > system.img grew up to be about 740 MiB. Let's increase system.img to > 1 GiB to accommodate for those changes and leave some margin for future > changes. We don't want to make it more than 1 GiB, because we should > keep userdata partition big enough (for user files, like media etc.), > and eMMC size on BeagleBoard-X15 is only 3.5 GiB. > > Signed-off-by: Sam Protsenko <semen.protsenko@linaro.org> Acked-by: Praneeth Bajjuri <praneeth@ti.com> > --- > include/environment/ti/boot.h | 2 +- > 1 file changed, 1 insertion(+), 1 deletion(-) > > diff --git a/include/environment/ti/boot.h b/include/environment/ti/boot.h > index 5891009a5a..86ff6d3ea7 100644 > --- a/include/environment/ti/boot.h > +++ b/include/environment/ti/boot.h > @@ -41,7 +41,7 @@ > "name=crypto,size=16K,uuid=${uuid_gpt_crypto};" \ > "name=recovery,size=40M,uuid=${uuid_gpt_recovery};" \ > "name=boot,size=10M,uuid=${uuid_gpt_boot};" \ > - "name=system,size=768M,uuid=${uuid_gpt_system};" \ > + "name=system,size=1024M,uuid=${uuid_gpt_system};" \ > "name=vendor,size=256M,uuid=${uuid_gpt_vendor};" \ > "name=cache,size=256M,uuid=${uuid_gpt_cache};" \ > "name=ipu1,size=1M,uuid=${uuid_gpt_ipu1};" \
Sam, On 12/11/2018 10:26 AM, Bajjuri, Praneeth wrote: > > On 12/11/2018 10:20 AM, Sam Protsenko wrote: >> Android code base is growing, so since Android "Pie" the size of >> system.img grew up to be about 740 MiB. Let's increase system.img to >> 1 GiB to accommodate for those changes and leave some margin for future >> changes. We don't want to make it more than 1 GiB, because we should >> keep userdata partition big enough (for user files, like media etc.), >> and eMMC size on BeagleBoard-X15 is only 3.5 GiB. >> >> Signed-off-by: Sam Protsenko <semen.protsenko@linaro.org> > Acked-by: Praneeth Bajjuri <praneeth@ti.com> >> --- >> include/environment/ti/boot.h | 2 +- >> 1 file changed, 1 insertion(+), 1 deletion(-) >> >> diff --git a/include/environment/ti/boot.h >> b/include/environment/ti/boot.h >> index 5891009a5a..86ff6d3ea7 100644 >> --- a/include/environment/ti/boot.h >> +++ b/include/environment/ti/boot.h >> @@ -41,7 +41,7 @@ >> "name=crypto,size=16K,uuid=${uuid_gpt_crypto};" \ >> "name=recovery,size=40M,uuid=${uuid_gpt_recovery};" \ >> "name=boot,size=10M,uuid=${uuid_gpt_boot};" \ >> - "name=system,size=768M,uuid=${uuid_gpt_system};" \ >> + "name=system,size=1024M,uuid=${uuid_gpt_system};" \ while at it, Can you remove the legacy partitions which are not applicable anymore for X15. remove : reserved, efs,crypto,cache,ipu1,ipu2. This will give more storage for userdata we can still use misc for reboot reason storage for the purpose of fastboot reboot to (bootloader or recovery) >> "name=vendor,size=256M,uuid=${uuid_gpt_vendor};" \ >> "name=cache,size=256M,uuid=${uuid_gpt_cache};" \ >> "name=ipu1,size=1M,uuid=${uuid_gpt_ipu1};" \
Hi Praneeth, On Fri, Dec 14, 2018 at 1:37 AM Bajjuri, Praneeth <praneeth@ti.com> wrote: > > Sam, > > On 12/11/2018 10:26 AM, Bajjuri, Praneeth wrote: > > > > On 12/11/2018 10:20 AM, Sam Protsenko wrote: > >> Android code base is growing, so since Android "Pie" the size of > >> system.img grew up to be about 740 MiB. Let's increase system.img to > >> 1 GiB to accommodate for those changes and leave some margin for future > >> changes. We don't want to make it more than 1 GiB, because we should > >> keep userdata partition big enough (for user files, like media etc.), > >> and eMMC size on BeagleBoard-X15 is only 3.5 GiB. > >> > >> Signed-off-by: Sam Protsenko <semen.protsenko@linaro.org> > > Acked-by: Praneeth Bajjuri <praneeth@ti.com> > >> --- > >> include/environment/ti/boot.h | 2 +- > >> 1 file changed, 1 insertion(+), 1 deletion(-) > >> > >> diff --git a/include/environment/ti/boot.h > >> b/include/environment/ti/boot.h > >> index 5891009a5a..86ff6d3ea7 100644 > >> --- a/include/environment/ti/boot.h > >> +++ b/include/environment/ti/boot.h > >> @@ -41,7 +41,7 @@ > >> "name=crypto,size=16K,uuid=${uuid_gpt_crypto};" \ > >> "name=recovery,size=40M,uuid=${uuid_gpt_recovery};" \ > >> "name=boot,size=10M,uuid=${uuid_gpt_boot};" \ > >> - "name=system,size=768M,uuid=${uuid_gpt_system};" \ > >> + "name=system,size=1024M,uuid=${uuid_gpt_system};" \ > > while at it, > > Can you remove the legacy partitions which are not applicable anymore > for X15. > > remove : reserved, efs,crypto,cache,ipu1,ipu2. This will give more > storage for userdata > Actually this file is also used for DRA7 and OMAP5 boards. Do you know if we need ipu* partitions on DRA7? "reserved" is actually used to mark U-Boot environment, so I guess I will rename it rather them remove. As for the other partitions, like cache, I think you're right. We shouldn't try and support old Androids in new U-Boot, we have older release tags for this. But I'd prefer to send that change in a separate patch, due to commit message and atomicity. Thanks. > we can still use misc for reboot reason storage for the purpose of > fastboot reboot to (bootloader or recovery) > > >> "name=vendor,size=256M,uuid=${uuid_gpt_vendor};" \ > >> "name=cache,size=256M,uuid=${uuid_gpt_cache};" \ > >> "name=ipu1,size=1M,uuid=${uuid_gpt_ipu1};" \
On 12/14/2018 7:15 AM, Sam Protsenko wrote: > Hi Praneeth, > > On Fri, Dec 14, 2018 at 1:37 AM Bajjuri, Praneeth <praneeth@ti.com> wrote: >> Sam, >> >> On 12/11/2018 10:26 AM, Bajjuri, Praneeth wrote: >>> On 12/11/2018 10:20 AM, Sam Protsenko wrote: >>>> Android code base is growing, so since Android "Pie" the size of >>>> system.img grew up to be about 740 MiB. Let's increase system.img to >>>> 1 GiB to accommodate for those changes and leave some margin for future >>>> changes. We don't want to make it more than 1 GiB, because we should >>>> keep userdata partition big enough (for user files, like media etc.), >>>> and eMMC size on BeagleBoard-X15 is only 3.5 GiB. >>>> >>>> Signed-off-by: Sam Protsenko <semen.protsenko@linaro.org> >>> Acked-by: Praneeth Bajjuri <praneeth@ti.com> >>>> --- >>>> include/environment/ti/boot.h | 2 +- >>>> 1 file changed, 1 insertion(+), 1 deletion(-) >>>> >>>> diff --git a/include/environment/ti/boot.h >>>> b/include/environment/ti/boot.h >>>> index 5891009a5a..86ff6d3ea7 100644 >>>> --- a/include/environment/ti/boot.h >>>> +++ b/include/environment/ti/boot.h >>>> @@ -41,7 +41,7 @@ >>>> "name=crypto,size=16K,uuid=${uuid_gpt_crypto};" \ >>>> "name=recovery,size=40M,uuid=${uuid_gpt_recovery};" \ >>>> "name=boot,size=10M,uuid=${uuid_gpt_boot};" \ >>>> - "name=system,size=768M,uuid=${uuid_gpt_system};" \ >>>> + "name=system,size=1024M,uuid=${uuid_gpt_system};" \ >> while at it, >> >> Can you remove the legacy partitions which are not applicable anymore >> for X15. >> >> remove : reserved, efs,crypto,cache,ipu1,ipu2. This will give more >> storage for userdata >> > Actually this file is also used for DRA7 and OMAP5 boards. Do you know > if we need ipu* partitions on DRA7? Can be removed for DRA7. IPU firmware is part of vendor image and doesnt reside as a separate partition > > "reserved" is actually used to mark U-Boot environment, so I guess I > will rename it rather them remove. > > As for the other partitions, like cache, I think you're right. We > shouldn't try and support old Androids in new U-Boot, we have older > release tags for this. But I'd prefer to send that change in a > separate patch, due to commit message and atomicity. the current fix itself for increasing system image size is fine. Ok on cleaning up legacy partitions with a patch on top > > Thanks. > >> we can still use misc for reboot reason storage for the purpose of >> fastboot reboot to (bootloader or recovery) >> >>>> "name=vendor,size=256M,uuid=${uuid_gpt_vendor};" \ >>>> "name=cache,size=256M,uuid=${uuid_gpt_cache};" \ >>>> "name=ipu1,size=1M,uuid=${uuid_gpt_ipu1};" \
Hi Tom, Could you please merge this as is? I'll do discussed legacy partitions cleaning in next patch. Thanks. On Fri, Dec 14, 2018 at 8:38 PM Bajjuri, Praneeth <praneeth@ti.com> wrote: > > > On 12/14/2018 7:15 AM, Sam Protsenko wrote: > > Hi Praneeth, > > > > On Fri, Dec 14, 2018 at 1:37 AM Bajjuri, Praneeth <praneeth@ti.com> wrote: > >> Sam, > >> > >> On 12/11/2018 10:26 AM, Bajjuri, Praneeth wrote: > >>> On 12/11/2018 10:20 AM, Sam Protsenko wrote: > >>>> Android code base is growing, so since Android "Pie" the size of > >>>> system.img grew up to be about 740 MiB. Let's increase system.img to > >>>> 1 GiB to accommodate for those changes and leave some margin for future > >>>> changes. We don't want to make it more than 1 GiB, because we should > >>>> keep userdata partition big enough (for user files, like media etc.), > >>>> and eMMC size on BeagleBoard-X15 is only 3.5 GiB. > >>>> > >>>> Signed-off-by: Sam Protsenko <semen.protsenko@linaro.org> > >>> Acked-by: Praneeth Bajjuri <praneeth@ti.com> > >>>> --- > >>>> include/environment/ti/boot.h | 2 +- > >>>> 1 file changed, 1 insertion(+), 1 deletion(-) > >>>> > >>>> diff --git a/include/environment/ti/boot.h > >>>> b/include/environment/ti/boot.h > >>>> index 5891009a5a..86ff6d3ea7 100644 > >>>> --- a/include/environment/ti/boot.h > >>>> +++ b/include/environment/ti/boot.h > >>>> @@ -41,7 +41,7 @@ > >>>> "name=crypto,size=16K,uuid=${uuid_gpt_crypto};" \ > >>>> "name=recovery,size=40M,uuid=${uuid_gpt_recovery};" \ > >>>> "name=boot,size=10M,uuid=${uuid_gpt_boot};" \ > >>>> - "name=system,size=768M,uuid=${uuid_gpt_system};" \ > >>>> + "name=system,size=1024M,uuid=${uuid_gpt_system};" \ > >> while at it, > >> > >> Can you remove the legacy partitions which are not applicable anymore > >> for X15. > >> > >> remove : reserved, efs,crypto,cache,ipu1,ipu2. This will give more > >> storage for userdata > >> > > Actually this file is also used for DRA7 and OMAP5 boards. Do you know > > if we need ipu* partitions on DRA7? > Can be removed for DRA7. > IPU firmware is part of vendor image and doesnt reside as a separate > partition > > > > > "reserved" is actually used to mark U-Boot environment, so I guess I > > will rename it rather them remove. > > > > As for the other partitions, like cache, I think you're right. We > > shouldn't try and support old Androids in new U-Boot, we have older > > release tags for this. But I'd prefer to send that change in a > > separate patch, due to commit message and atomicity. > > the current fix itself for increasing system image size is fine. > Ok on cleaning up legacy partitions with a patch on top > > > > > > Thanks. > > > >> we can still use misc for reboot reason storage for the purpose of > >> fastboot reboot to (bootloader or recovery) > >> > >>>> "name=vendor,size=256M,uuid=${uuid_gpt_vendor};" \ > >>>> "name=cache,size=256M,uuid=${uuid_gpt_cache};" \ > >>>> "name=ipu1,size=1M,uuid=${uuid_gpt_ipu1};" \
On Tue, Dec 11, 2018 at 06:20:21PM +0200, Sam Protsenko wrote: > Android code base is growing, so since Android "Pie" the size of > system.img grew up to be about 740 MiB. Let's increase system.img to > 1 GiB to accommodate for those changes and leave some margin for future > changes. We don't want to make it more than 1 GiB, because we should > keep userdata partition big enough (for user files, like media etc.), > and eMMC size on BeagleBoard-X15 is only 3.5 GiB. > > Signed-off-by: Sam Protsenko <semen.protsenko@linaro.org> > Acked-by: Praneeth Bajjuri <praneeth@ti.com> Applied to u-boot/master, thanks! -- Tom
diff --git a/include/environment/ti/boot.h b/include/environment/ti/boot.h index 5891009a5a..86ff6d3ea7 100644 --- a/include/environment/ti/boot.h +++ b/include/environment/ti/boot.h @@ -41,7 +41,7 @@ "name=crypto,size=16K,uuid=${uuid_gpt_crypto};" \ "name=recovery,size=40M,uuid=${uuid_gpt_recovery};" \ "name=boot,size=10M,uuid=${uuid_gpt_boot};" \ - "name=system,size=768M,uuid=${uuid_gpt_system};" \ + "name=system,size=1024M,uuid=${uuid_gpt_system};" \ "name=vendor,size=256M,uuid=${uuid_gpt_vendor};" \ "name=cache,size=256M,uuid=${uuid_gpt_cache};" \ "name=ipu1,size=1M,uuid=${uuid_gpt_ipu1};" \
Android code base is growing, so since Android "Pie" the size of system.img grew up to be about 740 MiB. Let's increase system.img to 1 GiB to accommodate for those changes and leave some margin for future changes. We don't want to make it more than 1 GiB, because we should keep userdata partition big enough (for user files, like media etc.), and eMMC size on BeagleBoard-X15 is only 3.5 GiB. Signed-off-by: Sam Protsenko <semen.protsenko@linaro.org> --- include/environment/ti/boot.h | 2 +- 1 file changed, 1 insertion(+), 1 deletion(-)