| Message ID | 20181009110019.16171-1-ross.burton@intel.com |
|---|---|
| State | New |
| Headers | show |
| Series | glib-2.0: add missing locale dependencies to PN-ptest | expand |
On 10/09/2018 02:00 PM, Ross Burton wrote: > The test suite skips several tests if the required locales are not found, so add > them as dependencies of glib-2.0-ptest. > > Signed-off-by: Ross Burton <ross.burton@intel.com> > --- > meta/recipes-core/glib-2.0/glib.inc | 13 +++++++++++++ > 1 file changed, 13 insertions(+) > > diff --git a/meta/recipes-core/glib-2.0/glib.inc b/meta/recipes-core/glib-2.0/glib.inc > index ad4f2aebd71..f78aa9bfe6d 100644 > --- a/meta/recipes-core/glib-2.0/glib.inc > +++ b/meta/recipes-core/glib-2.0/glib.inc > @@ -152,6 +152,19 @@ RDEPENDS_${PN}-ptest_append_libc-glibc = "\ > glibc-gconv-iso8859-15 \ > glibc-charmap-invariant \ > glibc-localedata-translit-cjk-variants \ > + locale-base-tr-tr \ > + locale-base-lt-lt \ > + locale-base-ja-jp.euc-jp \ > + locale-base-fa-ir \ > + locale-base-ru-ru \ > + locale-base-de-de \ > + locale-base-pl-pl \ > + locale-base-hr-hr \ > + locale-base-el-gr \ > + locale-base-fr-fr \ > + locale-base-fr-fr \ > + locale-base-es-es \ > + locale-base-en-gb \ > " > > INSANE_SKIP_${PN}-ptest += "libdir" > Having GLIBC_GENERATE_LOCALES = "en_US.UTF-8" and 'ptest' in DISTRO_FEATURES, it would seem after this commit I'm seeing following warnings during bitbake: WARNING: glib-2.0-1_2.58.0-r0 do_package_qa: QA Issue: glib-2.0-ptest rdepends on locale-base-de-de, but it isn't a build dependency? [build-deps] WARNING: glib-2.0-1_2.58.0-r0 do_package_qa: QA Issue: glib-2.0-ptest rdepends on locale-base-el-gr, but it isn't a build dependency? [build-deps] WARNING: glib-2.0-1_2.58.0-r0 do_package_qa: QA Issue: glib-2.0-ptest rdepends on locale-base-en-gb, but it isn't a build dependency? [build-deps] WARNING: glib-2.0-1_2.58.0-r0 do_package_qa: QA Issue: glib-2.0-ptest rdepends on locale-base-es-es, but it isn't a build dependency? [build-deps] WARNING: glib-2.0-1_2.58.0-r0 do_package_qa: QA Issue: glib-2.0-ptest rdepends on locale-base-fa-ir, but it isn't a build dependency? [build-deps] WARNING: glib-2.0-1_2.58.0-r0 do_package_qa: QA Issue: glib-2.0-ptest rdepends on locale-base-fr-fr, but it isn't a build dependency? [build-deps] WARNING: glib-2.0-1_2.58.0-r0 do_package_qa: QA Issue: glib-2.0-ptest rdepends on locale-base-hr-hr, but it isn't a build dependency? [build-deps] WARNING: glib-2.0-1_2.58.0-r0 do_package_qa: QA Issue: glib-2.0-ptest rdepends on locale-base-ja-jp.euc-jp, but it isn't a build dependency? [build-deps] WARNING: glib-2.0-1_2.58.0-r0 do_package_qa: QA Issue: glib-2.0-ptest rdepends on locale-base-lt-lt, but it isn't a build dependency? [build-deps] WARNING: glib-2.0-1_2.58.0-r0 do_package_qa: QA Issue: glib-2.0-ptest rdepends on locale-base-ru-ru, but it isn't a build dependency? [build-deps] WARNING: glib-2.0-1_2.58.0-r0 do_package_qa: QA Issue: glib-2.0-ptest rdepends on locale-base-tr-tr, but it isn't a build dependency? [build-deps] If I switch GLIBC_GENERATE_LOCALES to 'all' these warnings no longer appear. -Niko -- _______________________________________________ Openembedded-core mailing list Openembedded-core@lists.openembedded.org http://lists.openembedded.org/mailman/listinfo/openembedded-core
Sounds about right. Not sure what would count as a solution here? Ross On Wed, 7 Nov 2018 at 12:40, Mauno Niko <niko.mauno@vaisala.com> wrote: > > On 10/09/2018 02:00 PM, Ross Burton wrote: > > The test suite skips several tests if the required locales are not found, so add > > them as dependencies of glib-2.0-ptest. > > > > Signed-off-by: Ross Burton <ross.burton@intel.com> > > --- > > meta/recipes-core/glib-2.0/glib.inc | 13 +++++++++++++ > > 1 file changed, 13 insertions(+) > > > > diff --git a/meta/recipes-core/glib-2.0/glib.inc b/meta/recipes-core/glib-2.0/glib.inc > > index ad4f2aebd71..f78aa9bfe6d 100644 > > --- a/meta/recipes-core/glib-2.0/glib.inc > > +++ b/meta/recipes-core/glib-2.0/glib.inc > > @@ -152,6 +152,19 @@ RDEPENDS_${PN}-ptest_append_libc-glibc = "\ > > glibc-gconv-iso8859-15 \ > > glibc-charmap-invariant \ > > glibc-localedata-translit-cjk-variants \ > > + locale-base-tr-tr \ > > + locale-base-lt-lt \ > > + locale-base-ja-jp.euc-jp \ > > + locale-base-fa-ir \ > > + locale-base-ru-ru \ > > + locale-base-de-de \ > > + locale-base-pl-pl \ > > + locale-base-hr-hr \ > > + locale-base-el-gr \ > > + locale-base-fr-fr \ > > + locale-base-fr-fr \ > > + locale-base-es-es \ > > + locale-base-en-gb \ > > " > > > > INSANE_SKIP_${PN}-ptest += "libdir" > > > > Having GLIBC_GENERATE_LOCALES = "en_US.UTF-8" and 'ptest' in DISTRO_FEATURES, it would seem after this commit I'm seeing following warnings during bitbake: > > WARNING: glib-2.0-1_2.58.0-r0 do_package_qa: QA Issue: glib-2.0-ptest rdepends on locale-base-de-de, but it isn't a build dependency? [build-deps] > WARNING: glib-2.0-1_2.58.0-r0 do_package_qa: QA Issue: glib-2.0-ptest rdepends on locale-base-el-gr, but it isn't a build dependency? [build-deps] > WARNING: glib-2.0-1_2.58.0-r0 do_package_qa: QA Issue: glib-2.0-ptest rdepends on locale-base-en-gb, but it isn't a build dependency? [build-deps] > WARNING: glib-2.0-1_2.58.0-r0 do_package_qa: QA Issue: glib-2.0-ptest rdepends on locale-base-es-es, but it isn't a build dependency? [build-deps] > WARNING: glib-2.0-1_2.58.0-r0 do_package_qa: QA Issue: glib-2.0-ptest rdepends on locale-base-fa-ir, but it isn't a build dependency? [build-deps] > WARNING: glib-2.0-1_2.58.0-r0 do_package_qa: QA Issue: glib-2.0-ptest rdepends on locale-base-fr-fr, but it isn't a build dependency? [build-deps] > WARNING: glib-2.0-1_2.58.0-r0 do_package_qa: QA Issue: glib-2.0-ptest rdepends on locale-base-hr-hr, but it isn't a build dependency? [build-deps] > WARNING: glib-2.0-1_2.58.0-r0 do_package_qa: QA Issue: glib-2.0-ptest rdepends on locale-base-ja-jp.euc-jp, but it isn't a build dependency? [build-deps] > WARNING: glib-2.0-1_2.58.0-r0 do_package_qa: QA Issue: glib-2.0-ptest rdepends on locale-base-lt-lt, but it isn't a build dependency? [build-deps] > WARNING: glib-2.0-1_2.58.0-r0 do_package_qa: QA Issue: glib-2.0-ptest rdepends on locale-base-ru-ru, but it isn't a build dependency? [build-deps] > WARNING: glib-2.0-1_2.58.0-r0 do_package_qa: QA Issue: glib-2.0-ptest rdepends on locale-base-tr-tr, but it isn't a build dependency? [build-deps] > > If I switch GLIBC_GENERATE_LOCALES to 'all' these warnings no longer appear. > > -Niko -- _______________________________________________ Openembedded-core mailing list Openembedded-core@lists.openembedded.org http://lists.openembedded.org/mailman/listinfo/openembedded-core
It was also discussed here: http://lists.openembedded.org/pipermail/openembedded-core/2018-October/156591.html and resulted in few fixes for _remove operator and: http://lists.openembedded.org/pipermail/openembedded-core/2018-October/156695.html http://lists.openembedded.org/pipermail/openembedded-core/2018-October/156696.html On Wed, Nov 7, 2018 at 2:55 PM Burton, Ross <ross.burton@intel.com> wrote: > Sounds about right. Not sure what would count as a solution here? > > Ross > On Wed, 7 Nov 2018 at 12:40, Mauno Niko <niko.mauno@vaisala.com> wrote: > > > > On 10/09/2018 02:00 PM, Ross Burton wrote: > > > The test suite skips several tests if the required locales are not > found, so add > > > them as dependencies of glib-2.0-ptest. > > > > > > Signed-off-by: Ross Burton <ross.burton@intel.com> > > > --- > > > meta/recipes-core/glib-2.0/glib.inc | 13 +++++++++++++ > > > 1 file changed, 13 insertions(+) > > > > > > diff --git a/meta/recipes-core/glib-2.0/glib.inc > b/meta/recipes-core/glib-2.0/glib.inc > > > index ad4f2aebd71..f78aa9bfe6d 100644 > > > --- a/meta/recipes-core/glib-2.0/glib.inc > > > +++ b/meta/recipes-core/glib-2.0/glib.inc > > > @@ -152,6 +152,19 @@ RDEPENDS_${PN}-ptest_append_libc-glibc = "\ > > > glibc-gconv-iso8859-15 \ > > > glibc-charmap-invariant \ > > > glibc-localedata-translit-cjk-variants \ > > > + locale-base-tr-tr \ > > > + locale-base-lt-lt \ > > > + locale-base-ja-jp.euc-jp \ > > > + locale-base-fa-ir \ > > > + locale-base-ru-ru \ > > > + locale-base-de-de \ > > > + locale-base-pl-pl \ > > > + locale-base-hr-hr \ > > > + locale-base-el-gr \ > > > + locale-base-fr-fr \ > > > + locale-base-fr-fr \ > > > + locale-base-es-es \ > > > + locale-base-en-gb \ > > > " > > > > > > INSANE_SKIP_${PN}-ptest += "libdir" > > > > > > > Having GLIBC_GENERATE_LOCALES = "en_US.UTF-8" and 'ptest' in > DISTRO_FEATURES, it would seem after this commit I'm seeing following > warnings during bitbake: > > > > WARNING: glib-2.0-1_2.58.0-r0 do_package_qa: QA Issue: glib-2.0-ptest > rdepends on locale-base-de-de, but it isn't a build dependency? [build-deps] > > WARNING: glib-2.0-1_2.58.0-r0 do_package_qa: QA Issue: glib-2.0-ptest > rdepends on locale-base-el-gr, but it isn't a build dependency? [build-deps] > > WARNING: glib-2.0-1_2.58.0-r0 do_package_qa: QA Issue: glib-2.0-ptest > rdepends on locale-base-en-gb, but it isn't a build dependency? [build-deps] > > WARNING: glib-2.0-1_2.58.0-r0 do_package_qa: QA Issue: glib-2.0-ptest > rdepends on locale-base-es-es, but it isn't a build dependency? [build-deps] > > WARNING: glib-2.0-1_2.58.0-r0 do_package_qa: QA Issue: glib-2.0-ptest > rdepends on locale-base-fa-ir, but it isn't a build dependency? [build-deps] > > WARNING: glib-2.0-1_2.58.0-r0 do_package_qa: QA Issue: glib-2.0-ptest > rdepends on locale-base-fr-fr, but it isn't a build dependency? [build-deps] > > WARNING: glib-2.0-1_2.58.0-r0 do_package_qa: QA Issue: glib-2.0-ptest > rdepends on locale-base-hr-hr, but it isn't a build dependency? [build-deps] > > WARNING: glib-2.0-1_2.58.0-r0 do_package_qa: QA Issue: glib-2.0-ptest > rdepends on locale-base-ja-jp.euc-jp, but it isn't a build dependency? > [build-deps] > > WARNING: glib-2.0-1_2.58.0-r0 do_package_qa: QA Issue: glib-2.0-ptest > rdepends on locale-base-lt-lt, but it isn't a build dependency? [build-deps] > > WARNING: glib-2.0-1_2.58.0-r0 do_package_qa: QA Issue: glib-2.0-ptest > rdepends on locale-base-ru-ru, but it isn't a build dependency? [build-deps] > > WARNING: glib-2.0-1_2.58.0-r0 do_package_qa: QA Issue: glib-2.0-ptest > rdepends on locale-base-tr-tr, but it isn't a build dependency? [build-deps] > > > > If I switch GLIBC_GENERATE_LOCALES to 'all' these warnings no longer > appear. > > > > -Niko > -- > _______________________________________________ > Openembedded-core mailing list > Openembedded-core@lists.openembedded.org > http://lists.openembedded.org/mailman/listinfo/openembedded-core > <div dir="ltr"><div dir="ltr"><div dir="ltr"><div dir="ltr">It was also discussed here:<div><a href="http://lists.openembedded.org/pipermail/openembedded-core/2018-October/156591.html">http://lists.openembedded.org/pipermail/openembedded-core/2018-October/156591.html</a><br></div><div><br></div><div>and resulted in few fixes for _remove operator and:</div><div><a href="http://lists.openembedded.org/pipermail/openembedded-core/2018-October/156695.html">http://lists.openembedded.org/pipermail/openembedded-core/2018-October/156695.html</a><br></div><div><a href="http://lists.openembedded.org/pipermail/openembedded-core/2018-October/156696.html">http://lists.openembedded.org/pipermail/openembedded-core/2018-October/156696.html</a><br></div></div></div></div></div><br><div class="gmail_quote"><div dir="ltr">On Wed, Nov 7, 2018 at 2:55 PM Burton, Ross <<a href="mailto:ross.burton@intel.com">ross.burton@intel.com</a>> wrote:<br></div><blockquote class="gmail_quote" style="margin:0 0 0 .8ex;border-left:1px #ccc solid;padding-left:1ex">Sounds about right. Not sure what would count as a solution here?<br> <br> Ross<br> On Wed, 7 Nov 2018 at 12:40, Mauno Niko <<a href="mailto:niko.mauno@vaisala.com" target="_blank">niko.mauno@vaisala.com</a>> wrote:<br> ><br> > On 10/09/2018 02:00 PM, Ross Burton wrote:<br> > > The test suite skips several tests if the required locales are not found, so add<br> > > them as dependencies of glib-2.0-ptest.<br> > ><br> > > Signed-off-by: Ross Burton <<a href="mailto:ross.burton@intel.com" target="_blank">ross.burton@intel.com</a>><br> > > ---<br> > > meta/recipes-core/glib-2.0/glib.inc | 13 +++++++++++++<br> > > 1 file changed, 13 insertions(+)<br> > ><br> > > diff --git a/meta/recipes-core/glib-2.0/glib.inc b/meta/recipes-core/glib-2.0/glib.inc<br> > > index ad4f2aebd71..f78aa9bfe6d 100644<br> > > --- a/meta/recipes-core/glib-2.0/glib.inc<br> > > +++ b/meta/recipes-core/glib-2.0/glib.inc<br> > > @@ -152,6 +152,19 @@ RDEPENDS_${PN}-ptest_append_libc-glibc = "\<br> > > glibc-gconv-iso8859-15 \<br> > > glibc-charmap-invariant \<br> > > glibc-localedata-translit-cjk-variants \<br> > > + locale-base-tr-tr \<br> > > + locale-base-lt-lt \<br> > > + locale-base-ja-jp.euc-jp \<br> > > + locale-base-fa-ir \<br> > > + locale-base-ru-ru \<br> > > + locale-base-de-de \<br> > > + locale-base-pl-pl \<br> > > + locale-base-hr-hr \<br> > > + locale-base-el-gr \<br> > > + locale-base-fr-fr \<br> > > + locale-base-fr-fr \<br> > > + locale-base-es-es \<br> > > + locale-base-en-gb \<br> > > "<br> > ><br> > > INSANE_SKIP_${PN}-ptest += "libdir"<br> > ><br> ><br> > Having GLIBC_GENERATE_LOCALES = "en_US.UTF-8" and 'ptest' in DISTRO_FEATURES, it would seem after this commit I'm seeing following warnings during bitbake:<br> ><br> > WARNING: glib-2.0-1_2.58.0-r0 do_package_qa: QA Issue: glib-2.0-ptest rdepends on locale-base-de-de, but it isn't a build dependency? [build-deps]<br> > WARNING: glib-2.0-1_2.58.0-r0 do_package_qa: QA Issue: glib-2.0-ptest rdepends on locale-base-el-gr, but it isn't a build dependency? [build-deps]<br> > WARNING: glib-2.0-1_2.58.0-r0 do_package_qa: QA Issue: glib-2.0-ptest rdepends on locale-base-en-gb, but it isn't a build dependency? [build-deps]<br> > WARNING: glib-2.0-1_2.58.0-r0 do_package_qa: QA Issue: glib-2.0-ptest rdepends on locale-base-es-es, but it isn't a build dependency? [build-deps]<br> > WARNING: glib-2.0-1_2.58.0-r0 do_package_qa: QA Issue: glib-2.0-ptest rdepends on locale-base-fa-ir, but it isn't a build dependency? [build-deps]<br> > WARNING: glib-2.0-1_2.58.0-r0 do_package_qa: QA Issue: glib-2.0-ptest rdepends on locale-base-fr-fr, but it isn't a build dependency? [build-deps]<br> > WARNING: glib-2.0-1_2.58.0-r0 do_package_qa: QA Issue: glib-2.0-ptest rdepends on locale-base-hr-hr, but it isn't a build dependency? [build-deps]<br> > WARNING: glib-2.0-1_2.58.0-r0 do_package_qa: QA Issue: glib-2.0-ptest rdepends on locale-base-ja-jp.euc-jp, but it isn't a build dependency? [build-deps]<br> > WARNING: glib-2.0-1_2.58.0-r0 do_package_qa: QA Issue: glib-2.0-ptest rdepends on locale-base-lt-lt, but it isn't a build dependency? [build-deps]<br> > WARNING: glib-2.0-1_2.58.0-r0 do_package_qa: QA Issue: glib-2.0-ptest rdepends on locale-base-ru-ru, but it isn't a build dependency? [build-deps]<br> > WARNING: glib-2.0-1_2.58.0-r0 do_package_qa: QA Issue: glib-2.0-ptest rdepends on locale-base-tr-tr, but it isn't a build dependency? [build-deps]<br> ><br> > If I switch GLIBC_GENERATE_LOCALES to 'all' these warnings no longer appear.<br> ><br> > -Niko<br> -- <br> _______________________________________________<br> Openembedded-core mailing list<br> <a href="mailto:Openembedded-core@lists.openembedded.org" target="_blank">Openembedded-core@lists.openembedded.org</a><br> <a href="http://lists.openembedded.org/mailman/listinfo/openembedded-core" rel="noreferrer" target="_blank">http://lists.openembedded.org/mailman/listinfo/openembedded-core</a><br> </blockquote></div> -- _______________________________________________ Openembedded-core mailing list Openembedded-core@lists.openembedded.org http://lists.openembedded.org/mailman/listinfo/openembedded-core
diff --git a/meta/recipes-core/glib-2.0/glib.inc b/meta/recipes-core/glib-2.0/glib.inc index ad4f2aebd71..f78aa9bfe6d 100644 --- a/meta/recipes-core/glib-2.0/glib.inc +++ b/meta/recipes-core/glib-2.0/glib.inc @@ -152,6 +152,19 @@ RDEPENDS_${PN}-ptest_append_libc-glibc = "\ glibc-gconv-iso8859-15 \ glibc-charmap-invariant \ glibc-localedata-translit-cjk-variants \ + locale-base-tr-tr \ + locale-base-lt-lt \ + locale-base-ja-jp.euc-jp \ + locale-base-fa-ir \ + locale-base-ru-ru \ + locale-base-de-de \ + locale-base-pl-pl \ + locale-base-hr-hr \ + locale-base-el-gr \ + locale-base-fr-fr \ + locale-base-fr-fr \ + locale-base-es-es \ + locale-base-en-gb \ " INSANE_SKIP_${PN}-ptest += "libdir"
The test suite skips several tests if the required locales are not found, so add them as dependencies of glib-2.0-ptest. Signed-off-by: Ross Burton <ross.burton@intel.com> --- meta/recipes-core/glib-2.0/glib.inc | 13 +++++++++++++ 1 file changed, 13 insertions(+) -- 2.11.0 -- _______________________________________________ Openembedded-core mailing list Openembedded-core@lists.openembedded.org http://lists.openembedded.org/mailman/listinfo/openembedded-core