| Message ID | 20181024134458.14212-1-sudeep.holla@arm.com |
|---|---|
| State | Accepted |
| Commit | a7314405d83c8f95736edb0ea7ade5d459b79afe |
| Headers | show |
| Series | [1/2] cpufreq: drop ARM_BIG_LITTLE_CPUFREQ support for ARM64 | expand |
On 24-10-18, 14:44, Sudeep Holla wrote: > ARM_BIG_LITTLE_CPUFREQ depends on topology_physical_package_id to get > the cluster id which inturn provides the information on related cpus > in the same performance domain. > > ARM64 core doesn't provide the cluster information as it's not > architecturally defined. There are no users of this driver in ARM64 > after the one and only user(SCPI) moved away. So let's ban the usage > of this driver for ARM64. > > Cc: Rafael J. Wysocki <rjw@rjwysocki.net> > Cc: Viresh Kumar <viresh.kumar@linaro.org> > Signed-off-by: Sudeep Holla <sudeep.holla@arm.com> > --- > drivers/cpufreq/Kconfig.arm | 2 +- > 1 file changed, 1 insertion(+), 1 deletion(-) > > diff --git a/drivers/cpufreq/Kconfig.arm b/drivers/cpufreq/Kconfig.arm > index 0cd8eb76ad59..040cfedf3e37 100644 > --- a/drivers/cpufreq/Kconfig.arm > +++ b/drivers/cpufreq/Kconfig.arm > @@ -28,7 +28,7 @@ config ARM_ARMADA_37XX_CPUFREQ > # big LITTLE core layer and glue drivers > config ARM_BIG_LITTLE_CPUFREQ > tristate "Generic ARM big LITTLE CPUfreq driver" > - depends on (ARM_CPU_TOPOLOGY || ARM64) && HAVE_CLK > + depends on ARM_CPU_TOPOLOGY && HAVE_CLK > # if CPU_THERMAL is on and THERMAL=m, ARM_BIT_LITTLE_CPUFREQ cannot be =y > depends on !CPU_THERMAL || THERMAL > select PM_OPP Acked-by: Viresh Kumar <viresh.kumar@linaro.org> -- viresh
On Wednesday, October 24, 2018 3:44:57 PM CEST Sudeep Holla wrote: > ARM_BIG_LITTLE_CPUFREQ depends on topology_physical_package_id to get > the cluster id which inturn provides the information on related cpus > in the same performance domain. > > ARM64 core doesn't provide the cluster information as it's not > architecturally defined. There are no users of this driver in ARM64 > after the one and only user(SCPI) moved away. So let's ban the usage > of this driver for ARM64. > > Cc: Rafael J. Wysocki <rjw@rjwysocki.net> > Cc: Viresh Kumar <viresh.kumar@linaro.org> > Signed-off-by: Sudeep Holla <sudeep.holla@arm.com> > --- > drivers/cpufreq/Kconfig.arm | 2 +- > 1 file changed, 1 insertion(+), 1 deletion(-) > > diff --git a/drivers/cpufreq/Kconfig.arm b/drivers/cpufreq/Kconfig.arm > index 0cd8eb76ad59..040cfedf3e37 100644 > --- a/drivers/cpufreq/Kconfig.arm > +++ b/drivers/cpufreq/Kconfig.arm > @@ -28,7 +28,7 @@ config ARM_ARMADA_37XX_CPUFREQ > # big LITTLE core layer and glue drivers > config ARM_BIG_LITTLE_CPUFREQ > tristate "Generic ARM big LITTLE CPUfreq driver" > - depends on (ARM_CPU_TOPOLOGY || ARM64) && HAVE_CLK > + depends on ARM_CPU_TOPOLOGY && HAVE_CLK > # if CPU_THERMAL is on and THERMAL=m, ARM_BIT_LITTLE_CPUFREQ cannot be =y > depends on !CPU_THERMAL || THERMAL > select PM_OPP > -- > 2.17.1 > > Both [1-2/2] applied with ACKs from Viresh, thanks!
diff --git a/drivers/cpufreq/Kconfig.arm b/drivers/cpufreq/Kconfig.arm index 0cd8eb76ad59..040cfedf3e37 100644 --- a/drivers/cpufreq/Kconfig.arm +++ b/drivers/cpufreq/Kconfig.arm @@ -28,7 +28,7 @@ config ARM_ARMADA_37XX_CPUFREQ # big LITTLE core layer and glue drivers config ARM_BIG_LITTLE_CPUFREQ tristate "Generic ARM big LITTLE CPUfreq driver" - depends on (ARM_CPU_TOPOLOGY || ARM64) && HAVE_CLK + depends on ARM_CPU_TOPOLOGY && HAVE_CLK # if CPU_THERMAL is on and THERMAL=m, ARM_BIT_LITTLE_CPUFREQ cannot be =y depends on !CPU_THERMAL || THERMAL select PM_OPP
ARM_BIG_LITTLE_CPUFREQ depends on topology_physical_package_id to get the cluster id which inturn provides the information on related cpus in the same performance domain. ARM64 core doesn't provide the cluster information as it's not architecturally defined. There are no users of this driver in ARM64 after the one and only user(SCPI) moved away. So let's ban the usage of this driver for ARM64. Cc: Rafael J. Wysocki <rjw@rjwysocki.net> Cc: Viresh Kumar <viresh.kumar@linaro.org> Signed-off-by: Sudeep Holla <sudeep.holla@arm.com> --- drivers/cpufreq/Kconfig.arm | 2 +- 1 file changed, 1 insertion(+), 1 deletion(-) -- 2.17.1