diff mbox series

[4/4] gpgme: Inherit distutils3-base

Message ID 62f7c23173a051958c2cf6e8d7a4fce9bd0ef279.1535478536.git.raj.khem@gmail.com
State Accepted
Commit 8bfb54edc6fafda2301aece91ec6b55905e2a418
Headers show
Series Misc Fixes | expand

Commit Message

Khem Raj Aug. 28, 2018, 5:50 p.m. UTC 
its building a module therefore its important to provide correct cross
build environment, distutils3-base automatically inherits python3native
this is seen when using clang where it tried to link with gcc since the
environment falls back to builtin LDSHARED variable

Signed-off-by: Khem Raj <raj.khem@gmail.com>

---
 meta/recipes-support/gpgme/gpgme_1.11.1.bb | 4 ++--
 1 file changed, 2 insertions(+), 2 deletions(-)

-- 
2.18.0

-- 
_______________________________________________
Openembedded-core mailing list
Openembedded-core@lists.openembedded.org
http://lists.openembedded.org/mailman/listinfo/openembedded-core

Comments

Alex Kiernan Sept. 17, 2018, 9:26 a.m. UTC | #1 
Hi Khem

On Tue, Aug 28, 2018 at 6:51 PM Khem Raj <raj.khem@gmail.com> wrote:
>

> its building a module therefore its important to provide correct cross

> build environment, distutils3-base automatically inherits python3native

> this is seen when using clang where it tried to link with gcc since the

> environment falls back to builtin LDSHARED variable

>

> Signed-off-by: Khem Raj <raj.khem@gmail.com>


With this change I'm getting python3 pulled into images when using
gpgme, which I really don't want. If I add:

diff --git a/meta/recipes-support/gpgme/gpgme_1.11.1.bb
b/meta/recipes-support/gpgme/gpgme_1.11.1.bb
index ac9fccf..8b34aa3 100644
--- a/meta/recipes-support/gpgme/gpgme_1.11.1.bb
+++ b/meta/recipes-support/gpgme/gpgme_1.11.1.bb
@@ -50,6 +50,8 @@ LANGUAGES .= "${@bb.utils.contains('PACKAGECONFIG',
'python3', ' python3', '', d

 PYTHON_INHERIT = "${@bb.utils.contains('PACKAGECONFIG', 'python2', '
distutils-base', '', d)}"
 PYTHON_INHERIT .= "${@bb.utils.contains('PACKAGECONFIG', 'python3', '
distutils3-base', '', d)}"
+PYTHON_INHERIT_class-target = "${@bb.utils.contains('PACKAGECONFIG',
'python2', ' pythonnative', '', d)}"
+PYTHON_INHERIT_class-target .= "${@bb.utils.contains('PACKAGECONFIG',
'python3', ' python3native', '', d)}"

 EXTRA_OECONF += '--enable-languages="${LANGUAGES}" \
                  --disable-gpgconf-test \

I avoid that runtime dep, but does that still work for clang?

> ---

>  meta/recipes-support/gpgme/gpgme_1.11.1.bb | 4 ++--

>  1 file changed, 2 insertions(+), 2 deletions(-)

>

> diff --git a/meta/recipes-support/gpgme/gpgme_1.11.1.bb b/meta/recipes-support/gpgme/gpgme_1.11.1.bb

> index 151fc03f55..ac9fccf133 100644

> --- a/meta/recipes-support/gpgme/gpgme_1.11.1.bb

> +++ b/meta/recipes-support/gpgme/gpgme_1.11.1.bb

> @@ -48,8 +48,8 @@ LANGUAGES ?= "${DEFAULT_LANGUAGES}"

>  LANGUAGES .= "${@bb.utils.contains('PACKAGECONFIG', 'python2', ' python2', '', d)}"

>  LANGUAGES .= "${@bb.utils.contains('PACKAGECONFIG', 'python3', ' python3', '', d)}"

>

> -PYTHON_INHERIT = "${@bb.utils.contains('PACKAGECONFIG', 'python2', 'pythonnative', '', d)}"

> -PYTHON_INHERIT .= "${@bb.utils.contains('PACKAGECONFIG', 'python3', 'python3native', '', d)}"

> +PYTHON_INHERIT = "${@bb.utils.contains('PACKAGECONFIG', 'python2', ' distutils-base', '', d)}"

> +PYTHON_INHERIT .= "${@bb.utils.contains('PACKAGECONFIG', 'python3', ' distutils3-base', '', d)}"

>

>  EXTRA_OECONF += '--enable-languages="${LANGUAGES}" \

>                   --disable-gpgconf-test \

> --

> 2.18.0

>

> --

> _______________________________________________

> Openembedded-core mailing list

> Openembedded-core@lists.openembedded.org

> http://lists.openembedded.org/mailman/listinfo/openembedded-core




-- 
Alex Kiernan
-- 
_______________________________________________
Openembedded-core mailing list
Openembedded-core@lists.openembedded.org
http://lists.openembedded.org/mailman/listinfo/openembedded-core
Khem Raj Sept. 17, 2018, 2:56 p.m. UTC | #2 
No, it doesn't. but
inherit distutils-common-base python3native
together will work and also drop the runtime dep on python
On Mon, Sep 17, 2018 at 2:27 AM Alex Kiernan <alex.kiernan@gmail.com> wrote:
>

> Hi Khem

>

> On Tue, Aug 28, 2018 at 6:51 PM Khem Raj <raj.khem@gmail.com> wrote:

> >

> > its building a module therefore its important to provide correct cross

> > build environment, distutils3-base automatically inherits python3native

> > this is seen when using clang where it tried to link with gcc since the

> > environment falls back to builtin LDSHARED variable

> >

> > Signed-off-by: Khem Raj <raj.khem@gmail.com>

>

> With this change I'm getting python3 pulled into images when using

> gpgme, which I really don't want. If I add:

>

> diff --git a/meta/recipes-support/gpgme/gpgme_1.11.1.bb

> b/meta/recipes-support/gpgme/gpgme_1.11.1.bb

> index ac9fccf..8b34aa3 100644

> --- a/meta/recipes-support/gpgme/gpgme_1.11.1.bb

> +++ b/meta/recipes-support/gpgme/gpgme_1.11.1.bb

> @@ -50,6 +50,8 @@ LANGUAGES .= "${@bb.utils.contains('PACKAGECONFIG',

> 'python3', ' python3', '', d

>

>  PYTHON_INHERIT = "${@bb.utils.contains('PACKAGECONFIG', 'python2', '

> distutils-base', '', d)}"

>  PYTHON_INHERIT .= "${@bb.utils.contains('PACKAGECONFIG', 'python3', '

> distutils3-base', '', d)}"

> +PYTHON_INHERIT_class-target = "${@bb.utils.contains('PACKAGECONFIG',

> 'python2', ' pythonnative', '', d)}"

> +PYTHON_INHERIT_class-target .= "${@bb.utils.contains('PACKAGECONFIG',

> 'python3', ' python3native', '', d)}"

>

>  EXTRA_OECONF += '--enable-languages="${LANGUAGES}" \

>                   --disable-gpgconf-test \

>

> I avoid that runtime dep, but does that still work for clang?

>

> > ---

> >  meta/recipes-support/gpgme/gpgme_1.11.1.bb | 4 ++--

> >  1 file changed, 2 insertions(+), 2 deletions(-)

> >

> > diff --git a/meta/recipes-support/gpgme/gpgme_1.11.1.bb b/meta/recipes-support/gpgme/gpgme_1.11.1.bb

> > index 151fc03f55..ac9fccf133 100644

> > --- a/meta/recipes-support/gpgme/gpgme_1.11.1.bb

> > +++ b/meta/recipes-support/gpgme/gpgme_1.11.1.bb

> > @@ -48,8 +48,8 @@ LANGUAGES ?= "${DEFAULT_LANGUAGES}"

> >  LANGUAGES .= "${@bb.utils.contains('PACKAGECONFIG', 'python2', ' python2', '', d)}"

> >  LANGUAGES .= "${@bb.utils.contains('PACKAGECONFIG', 'python3', ' python3', '', d)}"

> >

> > -PYTHON_INHERIT = "${@bb.utils.contains('PACKAGECONFIG', 'python2', 'pythonnative', '', d)}"

> > -PYTHON_INHERIT .= "${@bb.utils.contains('PACKAGECONFIG', 'python3', 'python3native', '', d)}"

> > +PYTHON_INHERIT = "${@bb.utils.contains('PACKAGECONFIG', 'python2', ' distutils-base', '', d)}"

> > +PYTHON_INHERIT .= "${@bb.utils.contains('PACKAGECONFIG', 'python3', ' distutils3-base', '', d)}"

> >

> >  EXTRA_OECONF += '--enable-languages="${LANGUAGES}" \

> >                   --disable-gpgconf-test \

> > --

> > 2.18.0

> >

> > --

> > _______________________________________________

> > Openembedded-core mailing list

> > Openembedded-core@lists.openembedded.org

> > http://lists.openembedded.org/mailman/listinfo/openembedded-core

>

>

>

> --

> Alex Kiernan

-- 
_______________________________________________
Openembedded-core mailing list
Openembedded-core@lists.openembedded.org
http://lists.openembedded.org/mailman/listinfo/openembedded-core
Alex Kiernan Sept. 17, 2018, 5:13 p.m. UTC | #3 
Thanks, that works for me. I'll get a patch posted.
On Mon, Sep 17, 2018 at 3:57 PM Khem Raj <raj.khem@gmail.com> wrote:
>

> No, it doesn't. but

> inherit distutils-common-base python3native

> together will work and also drop the runtime dep on python

> On Mon, Sep 17, 2018 at 2:27 AM Alex Kiernan <alex.kiernan@gmail.com> wrote:

> >

> > Hi Khem

> >

> > On Tue, Aug 28, 2018 at 6:51 PM Khem Raj <raj.khem@gmail.com> wrote:

> > >

> > > its building a module therefore its important to provide correct cross

> > > build environment, distutils3-base automatically inherits python3native

> > > this is seen when using clang where it tried to link with gcc since the

> > > environment falls back to builtin LDSHARED variable

> > >

> > > Signed-off-by: Khem Raj <raj.khem@gmail.com>

> >

> > With this change I'm getting python3 pulled into images when using

> > gpgme, which I really don't want. If I add:

> >

> > diff --git a/meta/recipes-support/gpgme/gpgme_1.11.1.bb

> > b/meta/recipes-support/gpgme/gpgme_1.11.1.bb

> > index ac9fccf..8b34aa3 100644

> > --- a/meta/recipes-support/gpgme/gpgme_1.11.1.bb

> > +++ b/meta/recipes-support/gpgme/gpgme_1.11.1.bb

> > @@ -50,6 +50,8 @@ LANGUAGES .= "${@bb.utils.contains('PACKAGECONFIG',

> > 'python3', ' python3', '', d

> >

> >  PYTHON_INHERIT = "${@bb.utils.contains('PACKAGECONFIG', 'python2', '

> > distutils-base', '', d)}"

> >  PYTHON_INHERIT .= "${@bb.utils.contains('PACKAGECONFIG', 'python3', '

> > distutils3-base', '', d)}"

> > +PYTHON_INHERIT_class-target = "${@bb.utils.contains('PACKAGECONFIG',

> > 'python2', ' pythonnative', '', d)}"

> > +PYTHON_INHERIT_class-target .= "${@bb.utils.contains('PACKAGECONFIG',

> > 'python3', ' python3native', '', d)}"

> >

> >  EXTRA_OECONF += '--enable-languages="${LANGUAGES}" \

> >                   --disable-gpgconf-test \

> >

> > I avoid that runtime dep, but does that still work for clang?

> >

> > > ---

> > >  meta/recipes-support/gpgme/gpgme_1.11.1.bb | 4 ++--

> > >  1 file changed, 2 insertions(+), 2 deletions(-)

> > >

> > > diff --git a/meta/recipes-support/gpgme/gpgme_1.11.1.bb b/meta/recipes-support/gpgme/gpgme_1.11.1.bb

> > > index 151fc03f55..ac9fccf133 100644

> > > --- a/meta/recipes-support/gpgme/gpgme_1.11.1.bb

> > > +++ b/meta/recipes-support/gpgme/gpgme_1.11.1.bb

> > > @@ -48,8 +48,8 @@ LANGUAGES ?= "${DEFAULT_LANGUAGES}"

> > >  LANGUAGES .= "${@bb.utils.contains('PACKAGECONFIG', 'python2', ' python2', '', d)}"

> > >  LANGUAGES .= "${@bb.utils.contains('PACKAGECONFIG', 'python3', ' python3', '', d)}"

> > >

> > > -PYTHON_INHERIT = "${@bb.utils.contains('PACKAGECONFIG', 'python2', 'pythonnative', '', d)}"

> > > -PYTHON_INHERIT .= "${@bb.utils.contains('PACKAGECONFIG', 'python3', 'python3native', '', d)}"

> > > +PYTHON_INHERIT = "${@bb.utils.contains('PACKAGECONFIG', 'python2', ' distutils-base', '', d)}"

> > > +PYTHON_INHERIT .= "${@bb.utils.contains('PACKAGECONFIG', 'python3', ' distutils3-base', '', d)}"

> > >

> > >  EXTRA_OECONF += '--enable-languages="${LANGUAGES}" \

> > >                   --disable-gpgconf-test \

> > > --

> > > 2.18.0

> > >

> > > --

> > > _______________________________________________

> > > Openembedded-core mailing list

> > > Openembedded-core@lists.openembedded.org

> > > http://lists.openembedded.org/mailman/listinfo/openembedded-core

> >

> >

> >

> > --

> > Alex Kiernan




-- 
Alex Kiernan
-- 
_______________________________________________
Openembedded-core mailing list
Openembedded-core@lists.openembedded.org
http://lists.openembedded.org/mailman/listinfo/openembedded-core
diff mbox series

Patch

diff --git a/meta/recipes-support/gpgme/gpgme_1.11.1.bb b/meta/recipes-support/gpgme/gpgme_1.11.1.bb
index 151fc03f55..ac9fccf133 100644
--- a/meta/recipes-support/gpgme/gpgme_1.11.1.bb
+++ b/meta/recipes-support/gpgme/gpgme_1.11.1.bb
@@ -48,8 +48,8 @@  LANGUAGES ?= "${DEFAULT_LANGUAGES}"
 LANGUAGES .= "${@bb.utils.contains('PACKAGECONFIG', 'python2', ' python2', '', d)}"
 LANGUAGES .= "${@bb.utils.contains('PACKAGECONFIG', 'python3', ' python3', '', d)}"
 
-PYTHON_INHERIT = "${@bb.utils.contains('PACKAGECONFIG', 'python2', 'pythonnative', '', d)}"
-PYTHON_INHERIT .= "${@bb.utils.contains('PACKAGECONFIG', 'python3', 'python3native', '', d)}"
+PYTHON_INHERIT = "${@bb.utils.contains('PACKAGECONFIG', 'python2', ' distutils-base', '', d)}"
+PYTHON_INHERIT .= "${@bb.utils.contains('PACKAGECONFIG', 'python3', ' distutils3-base', '', d)}"
 
 EXTRA_OECONF += '--enable-languages="${LANGUAGES}" \
                  --disable-gpgconf-test \