| Message ID | 153202755842.21481.1772155561595981441.stgit@T460 |
|---|---|
| Headers | show |
| Series | vhost_user.c code cleanup | expand |
Hi Nikolay, On 07/19/2018 09:13 PM, Nikolay Nikolaev wrote: > vhost: vhost_user.c code cleanup > > This patchesries introduce a set of code redesigns in vhost_user.c. > > The goal is to unify and simplify vhost-user message handling. The > patches do not intend to introduce any functional changes. > > v2 changes: > - Fix the comments by Tiwei Bie > - Keep the old behavior > - Fall through when the callback returns VH_RESULT_ERR > - Fall through if the request is out of range > > --- > > Nikolay Nikolaev (5): > vhost: unify VhostUserMsg usage > vhost: make message handling functions prepare the reply > vhost: handle unsupported message types in functions > vhost: unify message handling function signature > vhost: message handling implemented as a callback array > > > lib/librte_vhost/vhost_user.c | 392 ++++++++++++++++++++++------------------- > 1 file changed, 208 insertions(+), 184 deletions(-) > > -- > Signature > Could you please rebase and fix the series (see Iliya comments) on top of git://dpdk.org/next/dpdk-next-virtio master branch? Thanks, Maxime
Hello Maxime, I'll rebase and fix Ilya's comments. Thanks for the reviews. regards, Nikolay Nikolaev On Tue, Sep 11, 2018 at 12:38 PM Maxime Coquelin <maxime.coquelin@redhat.com> wrote: > Hi Nikolay, > > On 07/19/2018 09:13 PM, Nikolay Nikolaev wrote: > > vhost: vhost_user.c code cleanup > > > > This patchesries introduce a set of code redesigns in vhost_user.c. > > > > The goal is to unify and simplify vhost-user message handling. The > > patches do not intend to introduce any functional changes. > > > > v2 changes: > > - Fix the comments by Tiwei Bie > > - Keep the old behavior > > - Fall through when the callback returns VH_RESULT_ERR > > - Fall through if the request is out of range > > > > --- > > > > Nikolay Nikolaev (5): > > vhost: unify VhostUserMsg usage > > vhost: make message handling functions prepare the reply > > vhost: handle unsupported message types in functions > > vhost: unify message handling function signature > > vhost: message handling implemented as a callback array > > > > > > lib/librte_vhost/vhost_user.c | 392 > ++++++++++++++++++++++------------------- > > 1 file changed, 208 insertions(+), 184 deletions(-) > > > > -- > > Signature > > > > Could you please rebase and fix the series (see Iliya comments) on top > of git://dpdk.org/next/dpdk-next-virtio master branch? > > Thanks, > Maxime >
vhost: vhost_user.c code cleanup This patchesries introduce a set of code redesigns in vhost_user.c. The goal is to unify and simplify vhost-user message handling. The patches do not intend to introduce any functional changes. v2 changes: - Fix the comments by Tiwei Bie - Keep the old behavior - Fall through when the callback returns VH_RESULT_ERR - Fall through if the request is out of range --- Nikolay Nikolaev (5): vhost: unify VhostUserMsg usage vhost: make message handling functions prepare the reply vhost: handle unsupported message types in functions vhost: unify message handling function signature vhost: message handling implemented as a callback array lib/librte_vhost/vhost_user.c | 392 ++++++++++++++++++++++------------------- 1 file changed, 208 insertions(+), 184 deletions(-) -- Signature