| Message ID | 20180829145616.9314-1-linus.walleij@linaro.org |
|---|---|
| State | New |
| Headers | show |
| Series | [1/2] gpio: tpx65xxx: Include the right header | expand |
On 08/29/2018 09:56 AM, Linus Walleij wrote: > These are drivers so include only <linux/gpio/driver.h>. > > Cc: Andrew F. Davis <afd@ti.com> > Cc: Keerthy <j-keerthy@ti.com> > Signed-off-by: Linus Walleij <linus.walleij@linaro.org> > --- Acked-by: Andrew F. Davis <afd@ti.com> > drivers/gpio/gpio-tps65086.c | 2 +- > drivers/gpio/gpio-tps6586x.c | 2 +- > drivers/gpio/gpio-tps65910.c | 2 +- > drivers/gpio/gpio-tps65912.c | 2 +- > 4 files changed, 4 insertions(+), 4 deletions(-) > > diff --git a/drivers/gpio/gpio-tps65086.c b/drivers/gpio/gpio-tps65086.c > index b23c4d2429be..47a8b209183c 100644 > --- a/drivers/gpio/gpio-tps65086.c > +++ b/drivers/gpio/gpio-tps65086.c > @@ -14,7 +14,7 @@ > * Based on the TPS65912 driver > */ > > -#include <linux/gpio.h> > +#include <linux/gpio/driver.h> > #include <linux/module.h> > #include <linux/platform_device.h> > > diff --git a/drivers/gpio/gpio-tps6586x.c b/drivers/gpio/gpio-tps6586x.c > index 042b9a20781a..f7404a6de55a 100644 > --- a/drivers/gpio/gpio-tps6586x.c > +++ b/drivers/gpio/gpio-tps6586x.c > @@ -22,7 +22,7 @@ > */ > > #include <linux/errno.h> > -#include <linux/gpio.h> > +#include <linux/gpio/driver.h> > #include <linux/kernel.h> > #include <linux/init.h> > #include <linux/mfd/tps6586x.h> > diff --git a/drivers/gpio/gpio-tps65910.c b/drivers/gpio/gpio-tps65910.c > index e63d7dabf78b..55c745b53d0f 100644 > --- a/drivers/gpio/gpio-tps65910.c > +++ b/drivers/gpio/gpio-tps65910.c > @@ -16,7 +16,7 @@ > #include <linux/kernel.h> > #include <linux/init.h> > #include <linux/errno.h> > -#include <linux/gpio.h> > +#include <linux/gpio/driver.h> > #include <linux/i2c.h> > #include <linux/platform_device.h> > #include <linux/mfd/tps65910.h> > diff --git a/drivers/gpio/gpio-tps65912.c b/drivers/gpio/gpio-tps65912.c > index abc0798ef843..aac78d18437d 100644 > --- a/drivers/gpio/gpio-tps65912.c > +++ b/drivers/gpio/gpio-tps65912.c > @@ -17,7 +17,7 @@ > * Margarita Olaya Cabrera <magi@slimlogic.co.uk> > */ > > -#include <linux/gpio.h> > +#include <linux/gpio/driver.h> > #include <linux/module.h> > #include <linux/platform_device.h> > >
On 8/29/2018 8:26 PM, Linus Walleij wrote: > These are drivers so include only <linux/gpio/driver.h>. Reviewed-by: Keerthy <j-keerthy@ti.com> > > Cc: Andrew F. Davis <afd@ti.com> > Cc: Keerthy <j-keerthy@ti.com> > Signed-off-by: Linus Walleij <linus.walleij@linaro.org> > --- > drivers/gpio/gpio-tps65086.c | 2 +- > drivers/gpio/gpio-tps6586x.c | 2 +- > drivers/gpio/gpio-tps65910.c | 2 +- > drivers/gpio/gpio-tps65912.c | 2 +- > 4 files changed, 4 insertions(+), 4 deletions(-) > > diff --git a/drivers/gpio/gpio-tps65086.c b/drivers/gpio/gpio-tps65086.c > index b23c4d2429be..47a8b209183c 100644 > --- a/drivers/gpio/gpio-tps65086.c > +++ b/drivers/gpio/gpio-tps65086.c > @@ -14,7 +14,7 @@ > * Based on the TPS65912 driver > */ > > -#include <linux/gpio.h> > +#include <linux/gpio/driver.h> > #include <linux/module.h> > #include <linux/platform_device.h> > > diff --git a/drivers/gpio/gpio-tps6586x.c b/drivers/gpio/gpio-tps6586x.c > index 042b9a20781a..f7404a6de55a 100644 > --- a/drivers/gpio/gpio-tps6586x.c > +++ b/drivers/gpio/gpio-tps6586x.c > @@ -22,7 +22,7 @@ > */ > > #include <linux/errno.h> > -#include <linux/gpio.h> > +#include <linux/gpio/driver.h> > #include <linux/kernel.h> > #include <linux/init.h> > #include <linux/mfd/tps6586x.h> > diff --git a/drivers/gpio/gpio-tps65910.c b/drivers/gpio/gpio-tps65910.c > index e63d7dabf78b..55c745b53d0f 100644 > --- a/drivers/gpio/gpio-tps65910.c > +++ b/drivers/gpio/gpio-tps65910.c > @@ -16,7 +16,7 @@ > #include <linux/kernel.h> > #include <linux/init.h> > #include <linux/errno.h> > -#include <linux/gpio.h> > +#include <linux/gpio/driver.h> > #include <linux/i2c.h> > #include <linux/platform_device.h> > #include <linux/mfd/tps65910.h> > diff --git a/drivers/gpio/gpio-tps65912.c b/drivers/gpio/gpio-tps65912.c > index abc0798ef843..aac78d18437d 100644 > --- a/drivers/gpio/gpio-tps65912.c > +++ b/drivers/gpio/gpio-tps65912.c > @@ -17,7 +17,7 @@ > * Margarita Olaya Cabrera <magi@slimlogic.co.uk> > */ > > -#include <linux/gpio.h> > +#include <linux/gpio/driver.h> > #include <linux/module.h> > #include <linux/platform_device.h> > >
diff --git a/drivers/gpio/gpio-tps65086.c b/drivers/gpio/gpio-tps65086.c index b23c4d2429be..47a8b209183c 100644 --- a/drivers/gpio/gpio-tps65086.c +++ b/drivers/gpio/gpio-tps65086.c @@ -14,7 +14,7 @@ * Based on the TPS65912 driver */ -#include <linux/gpio.h> +#include <linux/gpio/driver.h> #include <linux/module.h> #include <linux/platform_device.h> diff --git a/drivers/gpio/gpio-tps6586x.c b/drivers/gpio/gpio-tps6586x.c index 042b9a20781a..f7404a6de55a 100644 --- a/drivers/gpio/gpio-tps6586x.c +++ b/drivers/gpio/gpio-tps6586x.c @@ -22,7 +22,7 @@ */ #include <linux/errno.h> -#include <linux/gpio.h> +#include <linux/gpio/driver.h> #include <linux/kernel.h> #include <linux/init.h> #include <linux/mfd/tps6586x.h> diff --git a/drivers/gpio/gpio-tps65910.c b/drivers/gpio/gpio-tps65910.c index e63d7dabf78b..55c745b53d0f 100644 --- a/drivers/gpio/gpio-tps65910.c +++ b/drivers/gpio/gpio-tps65910.c @@ -16,7 +16,7 @@ #include <linux/kernel.h> #include <linux/init.h> #include <linux/errno.h> -#include <linux/gpio.h> +#include <linux/gpio/driver.h> #include <linux/i2c.h> #include <linux/platform_device.h> #include <linux/mfd/tps65910.h> diff --git a/drivers/gpio/gpio-tps65912.c b/drivers/gpio/gpio-tps65912.c index abc0798ef843..aac78d18437d 100644 --- a/drivers/gpio/gpio-tps65912.c +++ b/drivers/gpio/gpio-tps65912.c @@ -17,7 +17,7 @@ * Margarita Olaya Cabrera <magi@slimlogic.co.uk> */ -#include <linux/gpio.h> +#include <linux/gpio/driver.h> #include <linux/module.h> #include <linux/platform_device.h>
These are drivers so include only <linux/gpio/driver.h>. Cc: Andrew F. Davis <afd@ti.com> Cc: Keerthy <j-keerthy@ti.com> Signed-off-by: Linus Walleij <linus.walleij@linaro.org> --- drivers/gpio/gpio-tps65086.c | 2 +- drivers/gpio/gpio-tps6586x.c | 2 +- drivers/gpio/gpio-tps65910.c | 2 +- drivers/gpio/gpio-tps65912.c | 2 +- 4 files changed, 4 insertions(+), 4 deletions(-) -- 2.17.1