| Message ID | 20180822150045.22864-2-julien.grall@arm.com |
|---|---|
| State | Superseded |
| Headers | show |
| Series | tools/libxl: Switch Arm guest type to PVH | expand |
On Wed, Aug 22, 2018 at 04:00:44PM +0100, Julien Grall wrote: > libxl__arch_domain_build_info_setdefault > > A follow-up will require to modify default of multiple fields of > build_info. So rename the function accordingly. No functional change. > > Signed-off-by: Julien Grall <julien.grall@arm.com> Reviewed-by: Roger Pau Monné <roger.pau@citrix.com>
On Wed, Aug 22, 2018 at 05:08:18PM +0200, Roger Pau Monné wrote: > On Wed, Aug 22, 2018 at 04:00:44PM +0100, Julien Grall wrote: > > libxl__arch_domain_build_info_setdefault > > > > A follow-up will require to modify default of multiple fields of > > build_info. So rename the function accordingly. > > No functional change. > > > > > Signed-off-by: Julien Grall <julien.grall@arm.com> > > Reviewed-by: Roger Pau Monné <roger.pau@citrix.com> Acked-by: Wei Liu <wei.liu2@citrix.com>
diff --git a/tools/libxl/libxl_arch.h b/tools/libxl/libxl_arch.h index c8ccaaf14c..5ab0c95974 100644 --- a/tools/libxl/libxl_arch.h +++ b/tools/libxl/libxl_arch.h @@ -65,8 +65,7 @@ _hidden int libxl__arch_domain_map_irq(libxl__gc *gc, uint32_t domid, int irq); _hidden -void libxl__arch_domain_build_info_acpi_setdefault( - libxl_domain_build_info *b_info); +void libxl__arch_domain_build_info_setdefault(libxl_domain_build_info *b_info); _hidden int libxl__arch_extra_memory(libxl__gc *gc, diff --git a/tools/libxl/libxl_arm.c b/tools/libxl/libxl_arm.c index 3ee37d2d12..18c41f4ee9 100644 --- a/tools/libxl/libxl_arm.c +++ b/tools/libxl/libxl_arm.c @@ -1135,9 +1135,9 @@ int libxl__arch_domain_map_irq(libxl__gc *gc, uint32_t domid, int irq) return xc_domain_bind_pt_spi_irq(CTX->xch, domid, irq, irq); } -void libxl__arch_domain_build_info_acpi_setdefault( - libxl_domain_build_info *b_info) +void libxl__arch_domain_build_info_setdefault(libxl_domain_build_info *b_info) { + /* ACPI is disabled by default */ libxl_defbool_setdefault(&b_info->acpi, false); } diff --git a/tools/libxl/libxl_create.c b/tools/libxl/libxl_create.c index b7b44e280b..d4fa06daea 100644 --- a/tools/libxl/libxl_create.c +++ b/tools/libxl/libxl_create.c @@ -215,7 +215,7 @@ int libxl__domain_build_info_setdefault(libxl__gc *gc, if (!b_info->event_channels) b_info->event_channels = 1023; - libxl__arch_domain_build_info_acpi_setdefault(b_info); + libxl__arch_domain_build_info_setdefault(b_info); libxl_defbool_setdefault(&b_info->dm_restrict, false); switch (b_info->type) { diff --git a/tools/libxl/libxl_x86.c b/tools/libxl/libxl_x86.c index 6f670b03b5..81523a568f 100644 --- a/tools/libxl/libxl_x86.c +++ b/tools/libxl/libxl_x86.c @@ -613,8 +613,7 @@ int libxl__arch_domain_finalise_hw_description(libxl__gc *gc, return rc; } -void libxl__arch_domain_build_info_acpi_setdefault( - libxl_domain_build_info *b_info) +void libxl__arch_domain_build_info_setdefault(libxl_domain_build_info *b_info) { libxl_defbool_setdefault(&b_info->acpi, true); }
libxl__arch_domain_build_info_setdefault A follow-up will require to modify default of multiple fields of build_info. So rename the function accordingly. Signed-off-by: Julien Grall <julien.grall@arm.com> --- tools/libxl/libxl_arch.h | 3 +-- tools/libxl/libxl_arm.c | 4 ++-- tools/libxl/libxl_create.c | 2 +- tools/libxl/libxl_x86.c | 3 +-- 4 files changed, 5 insertions(+), 7 deletions(-)