| Message ID | 20180806223041.45954-1-agraf@suse.de |
|---|---|
| State | Accepted |
| Commit | 18e684dd4ca46a7a1bccc4e30ab47e92315e59c1 |
| Headers | show |
| Series | sandbox: Move BSS after EFI sections | expand |
Hi, On 6 August 2018 at 16:30, Alexander Graf <agraf@suse.de> wrote: > Something went wrong when writing the sandbox linker scripts and so we > ended up with a .bss section marker right before the efi runtime sections. > > That obviously is a terrible idea, as it may result in overwriting efi > runtime code and data. So let's move the .bss identifier behind the efi > sections. > > Signed-off-by: Alexander Graf <agraf@suse.de> > --- > arch/sandbox/cpu/u-boot.lds | 5 ++--- > 1 file changed, 2 insertions(+), 3 deletions(-) I think we should revert the patch that changed this, and deal with each of its changes one by one. As of now, sandbox is broken. I already sent a patch for this. Regards, Simon
diff --git a/arch/sandbox/cpu/u-boot.lds b/arch/sandbox/cpu/u-boot.lds index 727bcc3598..40c2214301 100644 --- a/arch/sandbox/cpu/u-boot.lds +++ b/arch/sandbox/cpu/u-boot.lds @@ -17,9 +17,7 @@ SECTIONS _u_boot_sandbox_getopt : { *(.u_boot_sandbox_getopt) } __u_boot_sandbox_option_end = .; - __bss_start = .; - - .__efi_runtime_start : { + .__efi_runtime_start : { *(.__efi_runtime_start) } @@ -48,6 +46,7 @@ SECTIONS *(.__efi_runtime_rel_stop) } + __bss_start = .; } INSERT BEFORE .data;
Something went wrong when writing the sandbox linker scripts and so we ended up with a .bss section marker right before the efi runtime sections. That obviously is a terrible idea, as it may result in overwriting efi runtime code and data. So let's move the .bss identifier behind the efi sections. Signed-off-by: Alexander Graf <agraf@suse.de> --- arch/sandbox/cpu/u-boot.lds | 5 ++--- 1 file changed, 2 insertions(+), 3 deletions(-)