mbox series

[edk2,v1,edk-platforms,0/2] Fix missing PL011UartClockLib

Message ID 1533782704-29302-1-git-send-email-haojian.zhuang@linaro.org
Headers show
Series Fix missing PL011UartClockLib | expand

Message

Haojian Zhuang Aug. 9, 2018, 2:45 a.m. UTC 
Fix build failure by appending PL011UartClockLib

Haojian Zhuang (2):
  Platform/HiKey960: add PL011UartClockLib
  Platform/HiKey: add PL011UartClockLib

 Platform/Hisilicon/HiKey/HiKey.dsc       | 1 +
 Platform/Hisilicon/HiKey960/HiKey960.dsc | 1 +
 2 files changed, 2 insertions(+)

Cc: Leif Lindholm <leif.lindholm@linaro.org>
Cc: Ard Biesheuvel <ard.biesheuvel@linaro.org>
-- 
2.7.4

_______________________________________________
edk2-devel mailing list
edk2-devel@lists.01.org
https://lists.01.org/mailman/listinfo/edk2-devel

Comments

Leif Lindholm Aug. 14, 2018, 4:16 p.m. UTC | #1 
Hi Haojian,

On Thu, Aug 09, 2018 at 10:45:04AM +0800, Haojian Zhuang wrote:
> Fix build failure by appending PL011UartClockLib


I don't think these patches are required.

Commit 1160c702c24f ("Platform: Add PL011UartClockLib resolution to
all PL011UartLib users") added this resolution to
Silicon/Hisilicon/Hisilicon.dsc.inc, which is included by both these
files.

Can you confirm please?

Best Regards,

Leif

> Haojian Zhuang (2):

>   Platform/HiKey960: add PL011UartClockLib

>   Platform/HiKey: add PL011UartClockLib

> 

>  Platform/Hisilicon/HiKey/HiKey.dsc       | 1 +

>  Platform/Hisilicon/HiKey960/HiKey960.dsc | 1 +

>  2 files changed, 2 insertions(+)

> 

> Cc: Leif Lindholm <leif.lindholm@linaro.org>

> Cc: Ard Biesheuvel <ard.biesheuvel@linaro.org>

> -- 

> 2.7.4

> 

_______________________________________________
edk2-devel mailing list
edk2-devel@lists.01.org
https://lists.01.org/mailman/listinfo/edk2-devel
Haojian Zhuang Aug. 15, 2018, 7:47 a.m. UTC | #2 
Hi Leif,

Yes, this patch series could be ignored now.

Best Regards
Haojian
________________________________________
From: Leif Lindholm <leif.lindholm@linaro.org>

Sent: Tuesday, August 14, 2018 4:16 PM
To: Haojian Zhuang
Cc: edk2-devel@lists.01.org; Ard Biesheuvel
Subject: Re: [edk2][PATCH v1 edk-platforms 0/2] Fix missing PL011UartClockLib

Hi Haojian,

On Thu, Aug 09, 2018 at 10:45:04AM +0800, Haojian Zhuang wrote:
&gt; Fix build failure by appending PL011UartClockLib

I don't think these patches are required.

Commit 1160c702c24f ("Platform: Add PL011UartClockLib resolution to
all PL011UartLib users") added this resolution to
Silicon/Hisilicon/Hisilicon.dsc.inc, which is included by both these
files.

Can you confirm please?

Best Regards,

Leif

&gt; Haojian Zhuang (2):
&gt;   Platform/HiKey960: add PL011UartClockLib
&gt;   Platform/HiKey: add PL011UartClockLib
&gt;
&gt;  Platform/Hisilicon/HiKey/HiKey.dsc       | 1 +
&gt;  Platform/Hisilicon/HiKey960/HiKey960.dsc | 1 +
&gt;  2 files changed, 2 insertions(+)
&gt;
&gt; Cc: Leif Lindholm <leif.lindholm@linaro.org>
&gt; Cc: Ard Biesheuvel <ard.biesheuvel@linaro.org>
&gt; --
&gt; 2.7.4
&gt;
</ard.biesheuvel@linaro.org></leif.lindholm@linaro.org></leif.lindholm@linaro.org>
_______________________________________________
edk2-devel mailing list
edk2-devel@lists.01.org
https://lists.01.org/mailman/listinfo/edk2-devel