| Message ID | 20180801123111.3595-1-richard.henderson@linaro.org |
|---|---|
| Headers | show |
| Series | target/arm sve fixes | expand |
On Wed, Aug 1, 2018 at 2:31 PM, Richard Henderson <richard.henderson@linaro.org> wrote: > These four patches are minor, reported by Laurent this week. This fixes the reported issues, thanks! > If there happens to be an -rc4 release, it would be nice if > they were included. But if not, no biggie. I suspect that > other minor issues will be found past these four, so I would > hope everyone who cares about sve is just as happy working > from a branch anyway. I indeed still have some things to look at. Laurent > > r~ > > > Richard Henderson (4): > target/arm: Fix sign of sve_cmpeq_ppzw/sve_cmpne_ppzw > target/arm: Fix typo in do_sat_addsub_64 > target/arm: Reorganize SVE WHILE > target/arm: Fix typo in helper_sve_movz_d > > target/arm/sve_helper.c | 19 ++++++-------- > target/arm/translate-sve.c | 51 ++++++++++++++++++++++++-------------- > 2 files changed, 40 insertions(+), 30 deletions(-) > > -- > 2.17.1 >
Richard Henderson <richard.henderson@linaro.org> writes: > These four patches are minor, reported by Laurent this week. > > If there happens to be an -rc4 release, it would be nice if > they were included. But if not, no biggie. I suspect that > other minor issues will be found past these four, so I would > hope everyone who cares about sve is just as happy working > from a branch anyway. All the RISU tests are still passing so: Tested-by: Alex Bennée <alex.bennee@linaro.org> > > > r~ > > > Richard Henderson (4): > target/arm: Fix sign of sve_cmpeq_ppzw/sve_cmpne_ppzw > target/arm: Fix typo in do_sat_addsub_64 > target/arm: Reorganize SVE WHILE > target/arm: Fix typo in helper_sve_movz_d > > target/arm/sve_helper.c | 19 ++++++-------- > target/arm/translate-sve.c | 51 ++++++++++++++++++++++++-------------- > 2 files changed, 40 insertions(+), 30 deletions(-) -- Alex Bennée
Hi,
This series seems to have some coding style problems. See output below for
more information:
Type: series
Message-id: 20180801123111.3595-1-richard.henderson@linaro.org
Subject: [Qemu-devel] [PATCH 0/4] target/arm sve fixes
=== TEST SCRIPT BEGIN ===
#!/bin/bash
BASE=base
n=1
total=$(git log --oneline $BASE.. | wc -l)
failed=0
git config --local diff.renamelimit 0
git config --local diff.renames True
git config --local diff.algorithm histogram
commits="$(git log --format=%H --reverse $BASE..)"
for c in $commits; do
echo "Checking PATCH $n/$total: $(git log -n 1 --format=%s $c)..."
if ! git show $c --format=email | ./scripts/checkpatch.pl --mailback -; then
failed=1
echo
fi
n=$((n+1))
done
exit $failed
=== TEST SCRIPT END ===
Updating 3c8cf5a9c21ff8782164d1def7f44bd888713384
Switched to a new branch 'test'
316eefdbc8 target/arm: Fix typo in helper_sve_movz_d
4b115c0c0d target/arm: Reorganize SVE WHILE
b5f496f5e7 target/arm: Fix typo in do_sat_addsub_64
795c7bee8d target/arm: Fix sign of sve_cmpeq_ppzw/sve_cmpne_ppzw
=== OUTPUT BEGIN ===
Checking PATCH 1/4: target/arm: Fix sign of sve_cmpeq_ppzw/sve_cmpne_ppzw...
ERROR: spaces required around that '==' (ctx:WxB)
#31: FILE: target/arm/sve_helper.c:2439:
+DO_CMP_PPZW_B(sve_cmpeq_ppzw_b, int8_t, uint64_t, ==)
^
ERROR: spaces required around that '==' (ctx:WxB)
#32: FILE: target/arm/sve_helper.c:2440:
+DO_CMP_PPZW_H(sve_cmpeq_ppzw_h, int16_t, uint64_t, ==)
^
ERROR: spaces required around that '==' (ctx:WxB)
#33: FILE: target/arm/sve_helper.c:2441:
+DO_CMP_PPZW_S(sve_cmpeq_ppzw_s, int32_t, uint64_t, ==)
^
ERROR: spaces required around that '!=' (ctx:WxB)
#38: FILE: target/arm/sve_helper.c:2443:
+DO_CMP_PPZW_B(sve_cmpne_ppzw_b, int8_t, uint64_t, !=)
^
ERROR: spaces required around that '!=' (ctx:WxB)
#39: FILE: target/arm/sve_helper.c:2444:
+DO_CMP_PPZW_H(sve_cmpne_ppzw_h, int16_t, uint64_t, !=)
^
ERROR: spaces required around that '!=' (ctx:WxB)
#40: FILE: target/arm/sve_helper.c:2445:
+DO_CMP_PPZW_S(sve_cmpne_ppzw_s, int32_t, uint64_t, !=)
^
total: 6 errors, 0 warnings, 19 lines checked
Your patch has style problems, please review. If any of these errors
are false positives report them to the maintainer, see
CHECKPATCH in MAINTAINERS.
Checking PATCH 2/4: target/arm: Fix typo in do_sat_addsub_64...
Checking PATCH 3/4: target/arm: Reorganize SVE WHILE...
Checking PATCH 4/4: target/arm: Fix typo in helper_sve_movz_d...
=== OUTPUT END ===
Test command exited with code: 1
---
Email generated automatically by Patchew [http://patchew.org/].
Please send your feedback to patchew-devel@redhat.com
Hi,
This series seems to have some coding style problems. See output below for
more information:
Type: series
Message-id: 20180801123111.3595-1-richard.henderson@linaro.org
Subject: [Qemu-devel] [PATCH 0/4] target/arm sve fixes
=== TEST SCRIPT BEGIN ===
#!/bin/bash
BASE=base
n=1
total=$(git log --oneline $BASE.. | wc -l)
failed=0
git config --local diff.renamelimit 0
git config --local diff.renames True
git config --local diff.algorithm histogram
commits="$(git log --format=%H --reverse $BASE..)"
for c in $commits; do
echo "Checking PATCH $n/$total: $(git log -n 1 --format=%s $c)..."
if ! git show $c --format=email | ./scripts/checkpatch.pl --mailback -; then
failed=1
echo
fi
n=$((n+1))
done
exit $failed
=== TEST SCRIPT END ===
Updating 3c8cf5a9c21ff8782164d1def7f44bd888713384
Switched to a new branch 'test'
e4c5ee9260 target/arm: Fix typo in helper_sve_movz_d
9a37ac5908 target/arm: Reorganize SVE WHILE
c529b75fec target/arm: Fix typo in do_sat_addsub_64
fb72755faa target/arm: Fix sign of sve_cmpeq_ppzw/sve_cmpne_ppzw
=== OUTPUT BEGIN ===
Checking PATCH 1/4: target/arm: Fix sign of sve_cmpeq_ppzw/sve_cmpne_ppzw...
ERROR: spaces required around that '==' (ctx:WxB)
#31: FILE: target/arm/sve_helper.c:2439:
+DO_CMP_PPZW_B(sve_cmpeq_ppzw_b, int8_t, uint64_t, ==)
^
ERROR: spaces required around that '==' (ctx:WxB)
#32: FILE: target/arm/sve_helper.c:2440:
+DO_CMP_PPZW_H(sve_cmpeq_ppzw_h, int16_t, uint64_t, ==)
^
ERROR: spaces required around that '==' (ctx:WxB)
#33: FILE: target/arm/sve_helper.c:2441:
+DO_CMP_PPZW_S(sve_cmpeq_ppzw_s, int32_t, uint64_t, ==)
^
ERROR: spaces required around that '!=' (ctx:WxB)
#38: FILE: target/arm/sve_helper.c:2443:
+DO_CMP_PPZW_B(sve_cmpne_ppzw_b, int8_t, uint64_t, !=)
^
ERROR: spaces required around that '!=' (ctx:WxB)
#39: FILE: target/arm/sve_helper.c:2444:
+DO_CMP_PPZW_H(sve_cmpne_ppzw_h, int16_t, uint64_t, !=)
^
ERROR: spaces required around that '!=' (ctx:WxB)
#40: FILE: target/arm/sve_helper.c:2445:
+DO_CMP_PPZW_S(sve_cmpne_ppzw_s, int32_t, uint64_t, !=)
^
total: 6 errors, 0 warnings, 19 lines checked
Your patch has style problems, please review. If any of these errors
are false positives report them to the maintainer, see
CHECKPATCH in MAINTAINERS.
Checking PATCH 2/4: target/arm: Fix typo in do_sat_addsub_64...
Checking PATCH 3/4: target/arm: Reorganize SVE WHILE...
Checking PATCH 4/4: target/arm: Fix typo in helper_sve_movz_d...
=== OUTPUT END ===
Test command exited with code: 1
---
Email generated automatically by Patchew [http://patchew.org/].
Please send your feedback to patchew-devel@redhat.com
On 1 August 2018 at 13:31, Richard Henderson <richard.henderson@linaro.org> wrote: > These four patches are minor, reported by Laurent this week. > > If there happens to be an -rc4 release, it would be nice if > they were included. But if not, no biggie. I suspect that > other minor issues will be found past these four, so I would > hope everyone who cares about sve is just as happy working > from a branch anyway. Applied to target-arm.for-3.1, thanks. (I currently expect there will be an -rc4, but I only want to put in fixes for regressions from 2.12.) -- PMM