| Message ID | 20180710152216.2393454-1-arnd@arndb.de |
|---|---|
| State | New |
| Headers | show |
| Series | printk: remove unused suppress_message_printing() | expand |
On (07/10/18 17:22), Arnd Bergmann wrote: > Moving the call to suppress_message_printing() into the '#ifdef CONFIG_PRINTK' > section means that the alternative definition is now unused when PRINTK is > disabled: > > kernel/printk/printk.c:2033:13: error: 'suppress_message_printing' defined but not used [-Werror=unused-function] > > This removes the stub function. > > Fixes: 375899cddcbb ("printk: make sure to print log on console.") > Signed-off-by: Arnd Bergmann <arnd@arndb.de> Arnd, thanks for the patch. I think we got the same report yesterday (0-day build bot) and Petr have addressed the warning already. -ss
diff --git a/kernel/printk/printk.c b/kernel/printk/printk.c index 4ca0f9bca82c..e015ac4ee367 100644 --- a/kernel/printk/printk.c +++ b/kernel/printk/printk.c @@ -2030,8 +2030,6 @@ static void call_console_drivers(const char *ext_text, size_t ext_len, const char *text, size_t len) {} static size_t msg_print_text(const struct printk_log *msg, bool syslog, char *buf, size_t size) { return 0; } -static bool suppress_message_printing(int level) { return false; } - #endif /* CONFIG_PRINTK */ #ifdef CONFIG_EARLY_PRINTK
Moving the call to suppress_message_printing() into the '#ifdef CONFIG_PRINTK' section means that the alternative definition is now unused when PRINTK is disabled: kernel/printk/printk.c:2033:13: error: 'suppress_message_printing' defined but not used [-Werror=unused-function] This removes the stub function. Fixes: 375899cddcbb ("printk: make sure to print log on console.") Signed-off-by: Arnd Bergmann <arnd@arndb.de> --- kernel/printk/printk.c | 2 -- 1 file changed, 2 deletions(-) -- 2.9.0