| Message ID | 20180706125858.3602497-1-arnd@arndb.de |
|---|---|
| State | New |
| Headers | show |
| Series | [net-next] devlink: fix incorrect return statement | expand |
From: Arnd Bergmann <arnd@arndb.de> Date: Fri, 6 Jul 2018 14:58:51 +0200 > A newly added dummy helper function tries to return a failure from a "void" > function: > > In file included from include/net/dsa.h:24, > from arch/arm/plat-orion/common.c:21: > include/net/devlink.h: In function 'devlink_param_value_changed': > include/net/devlink.h:771:9: error: 'return' with a value, in function returning void [-Werror] > return -EOPNOTSUPP; > > This fixes it by removing the bogus statement. > > Fixes: ea601e170988 ("devlink: Add devlink notifications support for params") > Signed-off-by: Arnd Bergmann <arnd@arndb.de> Applied.
diff --git a/include/net/devlink.h b/include/net/devlink.h index 8ed571385626..f67c29cede15 100644 --- a/include/net/devlink.h +++ b/include/net/devlink.h @@ -768,7 +768,6 @@ devlink_param_driverinit_value_set(struct devlink *devlink, u32 param_id, static inline void devlink_param_value_changed(struct devlink *devlink, u32 param_id) { - return -EOPNOTSUPP; } #endif
A newly added dummy helper function tries to return a failure from a "void" function: In file included from include/net/dsa.h:24, from arch/arm/plat-orion/common.c:21: include/net/devlink.h: In function 'devlink_param_value_changed': include/net/devlink.h:771:9: error: 'return' with a value, in function returning void [-Werror] return -EOPNOTSUPP; This fixes it by removing the bogus statement. Fixes: ea601e170988 ("devlink: Add devlink notifications support for params") Signed-off-by: Arnd Bergmann <arnd@arndb.de> --- include/net/devlink.h | 1 - 1 file changed, 1 deletion(-) -- 2.9.0