| Message ID | 20180525160729.92026-1-arnd@arndb.de |
|---|---|
| State | Superseded |
| Headers | show |
| Series | usb/gadget: aspeed-vhub: add USB_LIBCOMPOSITE dependency | expand |
On Fri, 2018-05-25 at 18:07 +0200, Arnd Bergmann wrote: > Without that option, we run into a link failure: > > drivers/usb/gadget/udc/aspeed-vhub/hub.o: In function `ast_vhub_std_hub_request': > hub.c:(.text+0x5b0): undefined reference to `usb_gadget_get_string' Thanks ! I hadn't realized these functions were part of an optional library. > Fixes: 7ecca2a4080c ("usb/gadget: Add driver for Aspeed SoC virtual hub") > Signed-off-by: Arnd Bergmann <arnd@arndb.de> Acked-by: Benjamin Herrenschmidt <benh@kernel.crashing.org> > --- > drivers/usb/gadget/udc/aspeed-vhub/Kconfig | 1 + > 1 file changed, 1 insertion(+) > > diff --git a/drivers/usb/gadget/udc/aspeed-vhub/Kconfig b/drivers/usb/gadget/udc/aspeed-vhub/Kconfig > index f0cdf89b8503..83ba8a2eb6af 100644 > --- a/drivers/usb/gadget/udc/aspeed-vhub/Kconfig > +++ b/drivers/usb/gadget/udc/aspeed-vhub/Kconfig > @@ -2,6 +2,7 @@ > config USB_ASPEED_VHUB > tristate "Aspeed vHub UDC driver" > depends on ARCH_ASPEED || COMPILE_TEST > + depends on USB_LIBCOMPOSITE > help > USB peripheral controller for the Aspeed AST2500 family > SoCs supporting the "vHub" functionality and USB2.0
Hi, Arnd Bergmann <arnd@arndb.de> writes: > Without that option, we run into a link failure: > > drivers/usb/gadget/udc/aspeed-vhub/hub.o: In function `ast_vhub_std_hub_request': > hub.c:(.text+0x5b0): undefined reference to `usb_gadget_get_string' > > Fixes: 7ecca2a4080c ("usb/gadget: Add driver for Aspeed SoC virtual hub") > Signed-off-by: Arnd Bergmann <arnd@arndb.de> Acked-by: Felipe Balbi <felipe.balbi@linux.intel.com> -- balbi
On Wed, 2018-05-30 at 15:29 +0300, Felipe Balbi wrote: > Hi, > > Arnd Bergmann <arnd@arndb.de> writes: > > Without that option, we run into a link failure: > > > > drivers/usb/gadget/udc/aspeed-vhub/hub.o: In function `ast_vhub_std_hub_request': > > hub.c:(.text+0x5b0): undefined reference to `usb_gadget_get_string' > > > > Fixes: 7ecca2a4080c ("usb/gadget: Add driver for Aspeed SoC virtual hub") > > Signed-off-by: Arnd Bergmann <arnd@arndb.de> > > Acked-by: Felipe Balbi <felipe.balbi@linux.intel.com> Greg, can you send this to Linus asap ? Some people are hitting build breakages upstream because of this. Thanks ! Cheers, Ben,
On 06/11/2018 09:29 PM, Benjamin Herrenschmidt wrote: > On Wed, 2018-05-30 at 15:29 +0300, Felipe Balbi wrote: >> Hi, >> >> Arnd Bergmann <arnd@arndb.de> writes: >>> Without that option, we run into a link failure: >>> >>> drivers/usb/gadget/udc/aspeed-vhub/hub.o: In function `ast_vhub_std_hub_request': >>> hub.c:(.text+0x5b0): undefined reference to `usb_gadget_get_string' >>> >>> Fixes: 7ecca2a4080c ("usb/gadget: Add driver for Aspeed SoC virtual hub") >>> Signed-off-by: Arnd Bergmann <arnd@arndb.de> >> >> Acked-by: Felipe Balbi <felipe.balbi@linux.intel.com> > > Greg, can you send this to Linus asap ? Some people are hitting build > breakages upstream because of this. Agreed. > Thanks ! ditto. -- ~Randy
diff --git a/drivers/usb/gadget/udc/aspeed-vhub/Kconfig b/drivers/usb/gadget/udc/aspeed-vhub/Kconfig index f0cdf89b8503..83ba8a2eb6af 100644 --- a/drivers/usb/gadget/udc/aspeed-vhub/Kconfig +++ b/drivers/usb/gadget/udc/aspeed-vhub/Kconfig @@ -2,6 +2,7 @@ config USB_ASPEED_VHUB tristate "Aspeed vHub UDC driver" depends on ARCH_ASPEED || COMPILE_TEST + depends on USB_LIBCOMPOSITE help USB peripheral controller for the Aspeed AST2500 family SoCs supporting the "vHub" functionality and USB2.0
Without that option, we run into a link failure: drivers/usb/gadget/udc/aspeed-vhub/hub.o: In function `ast_vhub_std_hub_request': hub.c:(.text+0x5b0): undefined reference to `usb_gadget_get_string' Fixes: 7ecca2a4080c ("usb/gadget: Add driver for Aspeed SoC virtual hub") Signed-off-by: Arnd Bergmann <arnd@arndb.de> --- drivers/usb/gadget/udc/aspeed-vhub/Kconfig | 1 + 1 file changed, 1 insertion(+) -- 2.9.0