Message ID | 20180607184844.30126-1-richard.henderson@linaro.org |
---|---|
Headers | show |
Series | linux-user: syscall number fixes | expand |
Hi, This series seems to have some coding style problems. See output below for more information: Type: series Message-id: 20180607184844.30126-1-richard.henderson@linaro.org Subject: [Qemu-devel] [PATCH 0/4] linux-user: syscall number fixes === TEST SCRIPT BEGIN === #!/bin/bash BASE=base n=1 total=$(git log --oneline $BASE.. | wc -l) failed=0 git config --local diff.renamelimit 0 git config --local diff.renames True git config --local diff.algorithm histogram commits="$(git log --format=%H --reverse $BASE..)" for c in $commits; do echo "Checking PATCH $n/$total: $(git log -n 1 --format=%s $c)..." if ! git show $c --format=email | ./scripts/checkpatch.pl --mailback -; then failed=1 echo fi n=$((n+1)) done exit $failed === TEST SCRIPT END === Updating 3c8cf5a9c21ff8782164d1def7f44bd888713384 From https://github.com/patchew-project/qemu * [new tag] patchew/20180607184844.30126-1-richard.henderson@linaro.org -> patchew/20180607184844.30126-1-richard.henderson@linaro.org Switched to a new branch 'test' 6080fbaefd linux-user/sparc64: Add inotify_rm_watch and tee syscalls a332062a9c linux-user/microblaze: Fix typo in accept4 syscall 04bf90a937 linux-user/hppa: Fix typo in mknodat syscall 63845de478 linux-user/alpha: Fix epoll syscalls === OUTPUT BEGIN === Checking PATCH 1/4: linux-user/alpha: Fix epoll syscalls... ERROR: code indent should never use tabs #22: FILE: linux-user/alpha/syscall_nr.h:346: +#define TARGET_NR_epoll_create^I^I407$ ERROR: code indent should never use tabs #23: FILE: linux-user/alpha/syscall_nr.h:347: +#define TARGET_NR_epoll_ctl^I^I408$ ERROR: code indent should never use tabs #24: FILE: linux-user/alpha/syscall_nr.h:348: +#define TARGET_NR_epoll_wait^I^I409$ total: 3 errors, 0 warnings, 27 lines checked Your patch has style problems, please review. If any of these errors are false positives report them to the maintainer, see CHECKPATCH in MAINTAINERS. Checking PATCH 2/4: linux-user/hppa: Fix typo in mknodat syscall... Checking PATCH 3/4: linux-user/microblaze: Fix typo in accept4 syscall... ERROR: code indent should never use tabs #18: FILE: linux-user/microblaze/syscall_nr.h:366: +#define TARGET_NR_accept4^I^I362 /* new */$ total: 1 errors, 0 warnings, 8 lines checked Your patch has style problems, please review. If any of these errors are false positives report them to the maintainer, see CHECKPATCH in MAINTAINERS. Checking PATCH 4/4: linux-user/sparc64: Add inotify_rm_watch and tee syscalls... WARNING: line over 80 characters #18: FILE: linux-user/sparc64/syscall_nr.h:157: +#define TARGET_NR_inotify_rm_watch 156 /* Linux specific */ total: 0 errors, 1 warnings, 16 lines checked Your patch has style problems, please review. If any of these errors are false positives report them to the maintainer, see CHECKPATCH in MAINTAINERS. === OUTPUT END === Test command exited with code: 1 --- Email generated automatically by Patchew [http://patchew.org/]. Please send your feedback to patchew-devel@redhat.com
Le 07/06/2018 à 20:56, no-reply@patchew.org a écrit : ... > === OUTPUT BEGIN === > Checking PATCH 1/4: linux-user/alpha: Fix epoll syscalls... > ERROR: code indent should never use tabs > #22: FILE: linux-user/alpha/syscall_nr.h:346: > +#define TARGET_NR_epoll_create^I^I407$ > > ERROR: code indent should never use tabs > #23: FILE: linux-user/alpha/syscall_nr.h:347: > +#define TARGET_NR_epoll_ctl^I^I408$ > > ERROR: code indent should never use tabs > #24: FILE: linux-user/alpha/syscall_nr.h:348: > +#define TARGET_NR_epoll_wait^I^I409$ > > total: 3 errors, 0 warnings, 27 lines checked ... > ERROR: code indent should never use tabs > #18: FILE: linux-user/microblaze/syscall_nr.h:366: > +#define TARGET_NR_accept4^I^I362 /* new */$ > If you agree, I will remove tabs when I'll commit the patches for the pull-request. Thanks, Laurent
On 06/07/2018 10:17 AM, Laurent Vivier wrote: > If you agree, I will remove tabs when I'll commit the patches for the > pull-request. Yes please. I should have noticed them there when making my change. r~