| Message ID | 1527497103-3593-1-git-send-email-leo.yan@linaro.org |
|---|---|
| Headers | show |
| Series | Perf script: Add python script for CoreSight trace disassembler | expand |
Em Mon, May 28, 2018 at 04:44:59PM +0800, Leo Yan escreveu: > This patch series is to support for using 'perf script' for CoreSight > trace disassembler, for this purpose this patch series adds a new > python script to parse CoreSight tracing event and use command 'objdump' > for disassembled lines, finally this can generate readable program > execution flow for reviewing tracing data. > > Patch 0001 is one fixing patch to generate samples for the start packet > and exception packets. > > Patch 0002 is the prerequisite to add addr into sample dict, so this > value can be used by python script to analyze instruction range. > > Patch 0003 is to add python script for trace disassembler. > > Patch 0004 is to add doc to explain python script usage and give > example for it. > > This patch series has been rebased on acme git tree [1] with the commit > 19422a9f2a3b ("perf tools: Fix kernel_start for PTI on x86") and tested > on Hikey (ARM64 octa CA53 cores). Thanks, applied to perf/core. - Arnaldo
On 28 May 2018 at 14:03, Arnaldo Carvalho de Melo <acme@kernel.org> wrote: > Em Mon, May 28, 2018 at 04:44:59PM +0800, Leo Yan escreveu: >> This patch series is to support for using 'perf script' for CoreSight >> trace disassembler, for this purpose this patch series adds a new >> python script to parse CoreSight tracing event and use command 'objdump' >> for disassembled lines, finally this can generate readable program >> execution flow for reviewing tracing data. >> >> Patch 0001 is one fixing patch to generate samples for the start packet >> and exception packets. >> >> Patch 0002 is the prerequisite to add addr into sample dict, so this >> value can be used by python script to analyze instruction range. >> >> Patch 0003 is to add python script for trace disassembler. >> >> Patch 0004 is to add doc to explain python script usage and give >> example for it. >> >> This patch series has been rebased on acme git tree [1] with the commit >> 19422a9f2a3b ("perf tools: Fix kernel_start for PTI on x86") and tested >> on Hikey (ARM64 octa CA53 cores). > > Thanks, applied to perf/core. Please hold off on that Arnaldo - I'm currently reviewing the set and I think some things can be improved. Thanks, Mathieu > > - Arnaldo
Em Mon, May 28, 2018 at 03:53:42PM -0600, Mathieu Poirier escreveu: > On 28 May 2018 at 14:03, Arnaldo Carvalho de Melo <acme@kernel.org> wrote: > > Em Mon, May 28, 2018 at 04:44:59PM +0800, Leo Yan escreveu: > >> This patch series is to support for using 'perf script' for CoreSight > >> trace disassembler, for this purpose this patch series adds a new > >> python script to parse CoreSight tracing event and use command 'objdump' > >> for disassembled lines, finally this can generate readable program > >> execution flow for reviewing tracing data. > >> > >> Patch 0001 is one fixing patch to generate samples for the start packet > >> and exception packets. > >> > >> Patch 0002 is the prerequisite to add addr into sample dict, so this > >> value can be used by python script to analyze instruction range. > >> > >> Patch 0003 is to add python script for trace disassembler. > >> > >> Patch 0004 is to add doc to explain python script usage and give > >> example for it. > >> > >> This patch series has been rebased on acme git tree [1] with the commit > >> 19422a9f2a3b ("perf tools: Fix kernel_start for PTI on x86") and tested > >> on Hikey (ARM64 octa CA53 cores). > > > > Thanks, applied to perf/core. > > Please hold off on that Arnaldo - I'm currently reviewing the set and > I think some things can be improved. Ok, I dropped all but the one adding sample->addr to the python dictionary, that is ok to cherry pick. - Arnaldo
This patch series is to support for using 'perf script' for CoreSight trace disassembler, for this purpose this patch series adds a new python script to parse CoreSight tracing event and use command 'objdump' for disassembled lines, finally this can generate readable program execution flow for reviewing tracing data. Patch 0001 is one fixing patch to generate samples for the start packet and exception packets. Patch 0002 is the prerequisite to add addr into sample dict, so this value can be used by python script to analyze instruction range. Patch 0003 is to add python script for trace disassembler. Patch 0004 is to add doc to explain python script usage and give example for it. This patch series has been rebased on acme git tree [1] with the commit 19422a9f2a3b ("perf tools: Fix kernel_start for PTI on x86") and tested on Hikey (ARM64 octa CA53 cores). In this version the script has no dependency on ARM64 platform and is expected to support ARM32 platform, but I am lacking ARM32 platform for testing on it, so firstly upstream to support ARM64 platform. This patch series is firstly to support 'per-thread' recording tracing data, but we also need to verify the script can dump trace disassembler CPU wide tracing and kernel panic kdump tracing data. I also verified this patch series which can work with kernel panic kdump tracing data, because Mathieu is working on CPU wide tracing related work, so after this we need to retest for CPU wide tracing and kdump tracing to ensure the python script can handle well for all cases. You are very welcome to test the script in this patch series, your testing result and suggestion are very valuable to perfect this script to cover more cases. Changes from v2: * Synced with Rob for handling CS_ETM_TRACE_ON packet, so refined 0001 patch according to dicussion; * Minor cleanup and fixes in 0003 patch for python script: remove 'svc' checking. Changes from v1: * According to Mike and Rob suggestion, add the fixing to generate samples for the start packet and exception packets. * Simplify the python script to remove the exception prediction algorithm, we can rely on the sane exception packets for disassembler. Leo Yan (4): perf cs-etm: Generate branch sample for missed packets perf script python: Add addr into perf sample dict perf script python: Add script for CoreSight trace disassembler coresight: Document for CoreSight trace disassembler Documentation/trace/coresight.txt | 52 +++++ tools/perf/scripts/python/arm-cs-trace-disasm.py | 235 +++++++++++++++++++++ tools/perf/util/cs-etm.c | 93 ++++++-- .../util/scripting-engines/trace-event-python.c | 2 + 4 files changed, 362 insertions(+), 20 deletions(-) create mode 100644 tools/perf/scripts/python/arm-cs-trace-disasm.py -- 2.7.4