mbox series

[ARM/FDPIC,v4,0/4] FDPIC ABI for ARM

Message ID 20180430080404.7323-1-christophe.lyon@st.com
Headers show
Series FDPIC ABI for ARM | expand

Message

Christophe Lyon April 30, 2018, 8:03 a.m. UTC 
Hello,

This patch series implements the QEMU contribution of the FDPIC
ABI for ARM targets.

This ABI enables to run Linux on ARM MMU-less cores and supports
shared libraries to reduce the memory footprint.

Without MMU, text and data segment relative distances are different
from one process to another, hence the need for a dedicated FDPIC
register holding the start address of the data segment. One of the
side effects is that function pointers require two words to be
represented: the address of the code, and the data segment start
address. These two words are designated as "Function Descriptor",
hence the "FD PIC" name.

On ARM, the FDPIC register is r9 [3].

This work was developed some time ago by STMicroelectronics, and was
presented during Linaro Connect SFO15 (September 2015). You can watch
the discussion and read the slides [1].
This presentation was related to the toolchain published on github [2],
which is based on binutils-2.22, gcc-4.7, uclibc-0.9.33.2, gdb-7.5.1
and qemu-2.3.0, and for which pre-built binaries are available [2].

The ABI itself is described in details in [3].

Our Linux kernel patches have been updated and committed by Nicolas
Pitre (Linaro) in July 2017. They are required so that the loader is
able to handle this new file type. Indeed, the ELF files are tagged
with ELFOSABI_ARM_FDPIC. This new tag has been allocated by ARM, as
well as the new relocations involved.

This patch series has been rebased on top of QEMU from 2018-03-28.

I have also rebased the GCC patch series, but it is still WIP as
cleanup is still needed before I can request a review. It can be
useful to build a preview toolchain though, so my WIP branch is
available at [4].
To build such a toolchain, you'd also need to use my uClibc
branch [5].

I am currently working on updating the patches for the other toolchain
components, and will upstream them soon. This includes gcc, uclibc,
and gdb.

This series provides support for ARM v7 and later architectures and
has been used to run the GCC tests on arm-linux-gnueabi without
regression, as well as arm-linux-uclibceabi.

v3->v4:
- Fix nits in patch #3.

v2->v3:
- Do not add the is_fdpic field to TaskState, as the information can
  be retrieved from the 'info' data in TaskState.
- Setup_return() now returns an error if the FDPIC function
  description isn't readable. Callers of setup_return() are updated to
  force_sigsegv in such cases.

v1->v2:
- Patch #1 removes CONFIG_USE_FDPIC
- Patch #2 corresponds to the previous patch #1, and is now simpler
  without configure option
- Patch #3 corresponds to the previous patch #2, and uses TaskState
  instead of CPUARMState
- patch #4 corresponds to the previous patch #3, and fixes guest
  pointer dereferencing

Are the QEMU patches OK for inclusion in master?

Thanks,

Christophe.


[1] http://connect.linaro.org/resource/sfo15/sfo15-406-arm-fdpic-toolset-kernel-libraries-for-cortex-m-cortex-r-mmuless-cores/
[2] https://github.com/mickael-guene/fdpic_manifest
[3] https://github.com/mickael-guene/fdpic_doc/blob/master/abi.txt
[4] https://git.linaro.org/people/christophe.lyon/gcc.git/log/?h=fdpic-upstream
[5] https://git.linaro.org/people/christophe.lyon/uclibc.git/log/?h=uClibc-0.9.33.2-fdpic-upstream

Christophe Lyon (4):
  Remove CONFIG_USE_FDPIC.
  linux-user: ARM-FDPIC: Identify ARM FDPIC binaries
  linux-user: ARM-FDPIC: Add support of FDPIC for ARM.
  linux-user: ARM-FDPIC: Add support for signals for FDPIC targets

 include/elf.h        |   1 +
 linux-user/elfload.c |  54 ++++++++++++++++++++------
 linux-user/qemu.h    |  13 ++++++-
 linux-user/signal.c  | 105 +++++++++++++++++++++++++++++++++++++++++++--------
 4 files changed, 144 insertions(+), 29 deletions(-)

-- 
2.6.3

Comments

Peter Maydell April 30, 2018, 8:11 a.m. UTC | #1 
On 30 April 2018 at 09:03, Christophe Lyon <christophe.lyon@st.com> wrote:
> Hello,

>

> This patch series implements the QEMU contribution of the FDPIC

> ABI for ARM targets.


Hi; I definitely reviewed at least some of these patches,
but this respin seems to have lost all the reviewed-by tags?

thanks
-- PMM
Christophe Lyon April 30, 2018, 8:40 a.m. UTC | #2 
On 30 April 2018 at 10:11, Peter Maydell <peter.maydell@linaro.org> wrote:
> On 30 April 2018 at 09:03, Christophe Lyon <christophe.lyon@st.com> wrote:

>> Hello,

>>

>> This patch series implements the QEMU contribution of the FDPIC

>> ABI for ARM targets.

>

> Hi; I definitely reviewed at least some of these patches,

> but this respin seems to have lost all the reviewed-by tags?

>

Indeed, I failed to include them.
Shall I send a v5 including these tags?

Sorry,

Christophe

> thanks

> -- PMM
Peter Maydell April 30, 2018, 8:59 a.m. UTC | #3 
On 30 April 2018 at 09:40, Christophe Lyon <christophe.lyon@linaro.org> wrote:
> On 30 April 2018 at 10:11, Peter Maydell <peter.maydell@linaro.org> wrote:

>> On 30 April 2018 at 09:03, Christophe Lyon <christophe.lyon@st.com> wrote:

>>> Hello,

>>>

>>> This patch series implements the QEMU contribution of the FDPIC

>>> ABI for ARM targets.

>>

>> Hi; I definitely reviewed at least some of these patches,

>> but this respin seems to have lost all the reviewed-by tags?

>>

> Indeed, I failed to include them.

> Shall I send a v5 including these tags?


No, but if you can check which ones should have them that would
be helpful.

thanks
-- PMM
Christophe Lyon April 30, 2018, 9:08 a.m. UTC | #4 
On 30 April 2018 at 10:59, Peter Maydell <peter.maydell@linaro.org> wrote:
> On 30 April 2018 at 09:40, Christophe Lyon <christophe.lyon@linaro.org> wrote:

>> On 30 April 2018 at 10:11, Peter Maydell <peter.maydell@linaro.org> wrote:

>>> On 30 April 2018 at 09:03, Christophe Lyon <christophe.lyon@st.com> wrote:

>>>> Hello,

>>>>

>>>> This patch series implements the QEMU contribution of the FDPIC

>>>> ABI for ARM targets.

>>>

>>> Hi; I definitely reviewed at least some of these patches,

>>> but this respin seems to have lost all the reviewed-by tags?

>>>

>> Indeed, I failed to include them.

>> Shall I send a v5 including these tags?

>

> No, but if you can check which ones should have them that would

> be helpful.

>

OK, so all 4 patches have
Reviewed-by: Peter Maydell <peter.maydell@linaro.org>

(you added it to patch 3/4, provided I fixed the nits, which I did in v4).

Thanks

Christophe

> thanks

> -- PMM
Peter Maydell April 30, 2018, 9:12 a.m. UTC | #5 
On 30 April 2018 at 10:08, Christophe Lyon <christophe.lyon@linaro.org> wrote:
> On 30 April 2018 at 10:59, Peter Maydell <peter.maydell@linaro.org> wrote:

>> On 30 April 2018 at 09:40, Christophe Lyon <christophe.lyon@linaro.org> wrote:

>>> On 30 April 2018 at 10:11, Peter Maydell <peter.maydell@linaro.org> wrote:

>>>> On 30 April 2018 at 09:03, Christophe Lyon <christophe.lyon@st.com> wrote:

>>>>> Hello,

>>>>>

>>>>> This patch series implements the QEMU contribution of the FDPIC

>>>>> ABI for ARM targets.

>>>>

>>>> Hi; I definitely reviewed at least some of these patches,

>>>> but this respin seems to have lost all the reviewed-by tags?

>>>>

>>> Indeed, I failed to include them.

>>> Shall I send a v5 including these tags?

>>

>> No, but if you can check which ones should have them that would

>> be helpful.

>>

> OK, so all 4 patches have

> Reviewed-by: Peter Maydell <peter.maydell@linaro.org>

> (you added it to patch 3/4, provided I fixed the nits, which I did in v4).


Great. Riku/Laurent -- I'm assuming you're going to take this set
via the linux-user tree.

-- PMM
Laurent Vivier April 30, 2018, 9:28 a.m. UTC | #6 
Le 30/04/2018 à 11:12, Peter Maydell a écrit :
> On 30 April 2018 at 10:08, Christophe Lyon <christophe.lyon@linaro.org> wrote:

>> On 30 April 2018 at 10:59, Peter Maydell <peter.maydell@linaro.org> wrote:

>>> On 30 April 2018 at 09:40, Christophe Lyon <christophe.lyon@linaro.org> wrote:

>>>> On 30 April 2018 at 10:11, Peter Maydell <peter.maydell@linaro.org> wrote:

>>>>> On 30 April 2018 at 09:03, Christophe Lyon <christophe.lyon@st.com> wrote:

>>>>>> Hello,

>>>>>>

>>>>>> This patch series implements the QEMU contribution of the FDPIC

>>>>>> ABI for ARM targets.

>>>>>

>>>>> Hi; I definitely reviewed at least some of these patches,

>>>>> but this respin seems to have lost all the reviewed-by tags?

>>>>>

>>>> Indeed, I failed to include them.

>>>> Shall I send a v5 including these tags?

>>>

>>> No, but if you can check which ones should have them that would

>>> be helpful.

>>>

>> OK, so all 4 patches have

>> Reviewed-by: Peter Maydell <peter.maydell@linaro.org>

>> (you added it to patch 3/4, provided I fixed the nits, which I did in v4).

> 

> Great. Riku/Laurent -- I'm assuming you're going to take this set

> via the linux-user tree.


I just sent a pull request without it...

Do you prefer I update this one or I send another one later?

Thanks,
Laurent
Peter Maydell April 30, 2018, 9:46 a.m. UTC | #7 
On 30 April 2018 at 10:28, Laurent Vivier <laurent@vivier.eu> wrote:
> Le 30/04/2018 à 11:12, Peter Maydell a écrit :

>> Great. Riku/Laurent -- I'm assuming you're going to take this set

>> via the linux-user tree.

>

> I just sent a pull request without it...

>

> Do you prefer I update this one or I send another one later?


No, it can go into your next one I think. I see you've sent
the signal.c refactoring, which this will conflict with,
so either you or Christophe will need to rebase it anyway.

thanks
-- PMM
Laurent Vivier April 30, 2018, 9:47 a.m. UTC | #8 
Le 30/04/2018 à 11:46, Peter Maydell a écrit :
> On 30 April 2018 at 10:28, Laurent Vivier <laurent@vivier.eu> wrote:

>> Le 30/04/2018 à 11:12, Peter Maydell a écrit :

>>> Great. Riku/Laurent -- I'm assuming you're going to take this set

>>> via the linux-user tree.

>>

>> I just sent a pull request without it...

>>

>> Do you prefer I update this one or I send another one later?

> 

> No, it can go into your next one I think. I see you've sent

> the signal.c refactoring, which this will conflict with,

> so either you or Christophe will need to rebase it anyway.


Yes, I will.

Thanks,
Laurent
Laurent Vivier April 30, 2018, 12:03 p.m. UTC | #9 
Le 30/04/2018 à 11:46, Peter Maydell a écrit :
> On 30 April 2018 at 10:28, Laurent Vivier <laurent@vivier.eu> wrote:

>> Le 30/04/2018 à 11:12, Peter Maydell a écrit :

>>> Great. Riku/Laurent -- I'm assuming you're going to take this set

>>> via the linux-user tree.

>>

>> I just sent a pull request without it...

>>

>> Do you prefer I update this one or I send another one later?

> 

> No, it can go into your next one I think. I see you've sent

> the signal.c refactoring, which this will conflict with,

> so either you or Christophe will need to rebase it anyway.

> 

> thanks

> -- PMM

> 


OK, I've rebased the series on top of the new master and applied to my
branch linux-user-for-2.13
(see https://github.com/vivier/qemu/tree/linux-user-for-2.13)

Thanks,
Laurent
Christophe Lyon May 2, 2018, 8:38 a.m. UTC | #10 
On 30 April 2018 at 14:03, Laurent Vivier <laurent@vivier.eu> wrote:
> Le 30/04/2018 à 11:46, Peter Maydell a écrit :

>> On 30 April 2018 at 10:28, Laurent Vivier <laurent@vivier.eu> wrote:

>>> Le 30/04/2018 à 11:12, Peter Maydell a écrit :

>>>> Great. Riku/Laurent -- I'm assuming you're going to take this set

>>>> via the linux-user tree.

>>>

>>> I just sent a pull request without it...

>>>

>>> Do you prefer I update this one or I send another one later?

>>

>> No, it can go into your next one I think. I see you've sent

>> the signal.c refactoring, which this will conflict with,

>> so either you or Christophe will need to rebase it anyway.

>>

>> thanks

>> -- PMM

>>

>

> OK, I've rebased the series on top of the new master and applied to my

> branch linux-user-for-2.13

> (see https://github.com/vivier/qemu/tree/linux-user-for-2.13)

>


For the record, I ran a smoke test with this branch and my small
example with a signal handler worked as expected.

Thanks,

Christophe

> Thanks,

> Laurent