| Message ID | 20180418141003.10229-1-jakob.unterwurzacher@theobroma-systems.com |
|---|---|
| State | Accepted |
| Commit | 71c23a821c6bcacba71a094efe49ee689605906b |
| Headers | show |
| Series | can: dev: increase bus-off message severity | expand |
On 04/18/2018 04:10 PM, Jakob Unterwurzacher wrote: > bus-off is usually caused by hardware malfunction or > configuration error (baud rate mismatch) and causes a > complete loss of communication. > > Increase the "bus-off" message's severity from netdev_dbg > to netdev_info to make it visible to the user. > > A can interface going into bus-off is similar in severity to > ethernet's "Link is Down" message, which is also printed > at info level. > > It is debatable whether the the "restarted" message should > also be changed to netdev_info to make the interface state > changes comprehensible from the kernel log. > I have chosen to keep the "restarted" message at dbg for now > as the "bus-off" message should be enough for the user to > notice and investigate the problem. > > Signed-off-by: Jakob Unterwurzacher <jakob.unterwurzacher@theobroma-systems.com> > Cc: linux-can@vger.kernel.org > Cc: linux-kernel@vger.kernel.org Applied to can. Tnx, Marc -- Pengutronix e.K. | Marc Kleine-Budde | Industrial Linux Solutions | Phone: +49-231-2826-924 | Vertretung West/Dortmund | Fax: +49-5121-206917-5555 | Amtsgericht Hildesheim, HRA 2686 | http://www.pengutronix.de |
diff --git a/drivers/net/can/dev.c b/drivers/net/can/dev.c index b1779566c5bb..3c71f1cb205f 100644 --- a/drivers/net/can/dev.c +++ b/drivers/net/can/dev.c @@ -605,7 +605,7 @@ void can_bus_off(struct net_device *dev) { struct can_priv *priv = netdev_priv(dev); - netdev_dbg(dev, "bus-off\n"); + netdev_info(dev, "bus-off\n"); netif_carrier_off(dev);
bus-off is usually caused by hardware malfunction or configuration error (baud rate mismatch) and causes a complete loss of communication. Increase the "bus-off" message's severity from netdev_dbg to netdev_info to make it visible to the user. A can interface going into bus-off is similar in severity to ethernet's "Link is Down" message, which is also printed at info level. It is debatable whether the the "restarted" message should also be changed to netdev_info to make the interface state changes comprehensible from the kernel log. I have chosen to keep the "restarted" message at dbg for now as the "bus-off" message should be enough for the user to notice and investigate the problem. Signed-off-by: Jakob Unterwurzacher <jakob.unterwurzacher@theobroma-systems.com> Cc: linux-can@vger.kernel.org Cc: linux-kernel@vger.kernel.org --- drivers/net/can/dev.c | 2 +- 1 file changed, 1 insertion(+), 1 deletion(-) -- 2.11.0