| Message ID | 1393357243-2958-8-git-send-email-balbi@ti.com |
|---|---|
| State | New |
| Headers | show |
Hi, On Tue, Feb 25, 2014 at 01:40:39PM -0600, Felipe Balbi wrote: > That bit still needs to be set for recent versions > of the IP. When necessary, IP will automatically > take PHYs out of suspend. > > Signed-off-by: Felipe Balbi <balbi@ti.com> > --- > drivers/usb/dwc3/core.c | 8 ++++++++ > 1 file changed, 8 insertions(+) > > diff --git a/drivers/usb/dwc3/core.c b/drivers/usb/dwc3/core.c > index 2864aad..745c1a0 100644 > --- a/drivers/usb/dwc3/core.c > +++ b/drivers/usb/dwc3/core.c > @@ -412,6 +412,14 @@ static int dwc3_core_init(struct dwc3 *dwc) > > dwc3_writel(dwc->regs, DWC3_GCTL, reg); > > + reg = dwc3_readl(dwc->regs, DWC3_GUSB3PIPECTL(0)); > + reg |= DWC3_GUSB3PIPECTL_SUSPHY; > + dwc3_writel(dwc->regs, DWC3_GUSB3PIPECTL(0), reg); > + > + reg = dwc3_readl(dwc->regs, DWC3_GUSB2PHYCFG(0)); > + reg |= DWC3_GUSB2PHYCFG_SUSPHY; > + dwc3_writel(dwc->regs, DWC3_GUSB2PHYCFG(0), reg); perhaps I should wrap this with a revision check so that we don't suspend PHYs in anything < 1.94a, I'll do that.
diff --git a/drivers/usb/dwc3/core.c b/drivers/usb/dwc3/core.c index 2864aad..745c1a0 100644 --- a/drivers/usb/dwc3/core.c +++ b/drivers/usb/dwc3/core.c @@ -412,6 +412,14 @@ static int dwc3_core_init(struct dwc3 *dwc) dwc3_writel(dwc->regs, DWC3_GCTL, reg); + reg = dwc3_readl(dwc->regs, DWC3_GUSB3PIPECTL(0)); + reg |= DWC3_GUSB3PIPECTL_SUSPHY; + dwc3_writel(dwc->regs, DWC3_GUSB3PIPECTL(0), reg); + + reg = dwc3_readl(dwc->regs, DWC3_GUSB2PHYCFG(0)); + reg |= DWC3_GUSB2PHYCFG_SUSPHY; + dwc3_writel(dwc->regs, DWC3_GUSB2PHYCFG(0), reg); + ret = dwc3_alloc_scratch_buffers(dwc); if (ret) goto err1;
That bit still needs to be set for recent versions of the IP. When necessary, IP will automatically take PHYs out of suspend. Signed-off-by: Felipe Balbi <balbi@ti.com> --- drivers/usb/dwc3/core.c | 8 ++++++++ 1 file changed, 8 insertions(+)