| Message ID | 1520405747-11023-1-git-send-email-heyi.guo@linaro.org |
|---|---|
| State | Superseded |
| Headers | show |
| Series | [edk2,1/3] Hisilicon/D0x: Set ACPI GTDT always-on flag | expand |
Hello Heyi, On 03/07/18 07:55, Heyi Guo wrote: > From: Jason Zhang <zhangjinsong2@huawei.com> > > Timer is always working on Hisilicon D0x, even system enters WFI/WFE, > and there is no other low power status, so we set "always-on" flag in > ACPI GTDT. > > Contributed-under: TianoCore Contribution Agreement 1.1 > Signed-off-by: Jason Zhang <zhangjinsong2@huawei.com> > Signed-off-by: Heyi Guo <heyi.guo@linaro.org> > Cc: Ard Biesheuvel <ard.biesheuvel@linaro.org> > Cc: Leif Lindholm <leif.lindholm@linaro.org> > Cc: Graeme Gregory <graeme.gregory@linaro.org> > --- > Silicon/Hisilicon/Hi1610/Hi1610AcpiTables/Gtdt.aslc | 3 ++- > Silicon/Hisilicon/Hi1616/D05AcpiTables/Gtdt.aslc | 2 +- > 2 files changed, 3 insertions(+), 2 deletions(-) this is for edk2-platforms, isn't it? If so, next time please add "edk2-platforms" to the subject prefix, as in: [PATCH edk2-platforms] or [edk2-platforms PATCH] Thanks! Laszlo _______________________________________________ edk2-devel mailing list edk2-devel@lists.01.org https://lists.01.org/mailman/listinfo/edk2-devel
Yes it is. Sorry for missing to do that. Will keep in mind next time :) Thanks, Heyi On Wed, Mar 07, 2018 at 10:36:48AM +0100, Laszlo Ersek wrote: > Hello Heyi, > > On 03/07/18 07:55, Heyi Guo wrote: > > From: Jason Zhang <zhangjinsong2@huawei.com> > > > > Timer is always working on Hisilicon D0x, even system enters WFI/WFE, > > and there is no other low power status, so we set "always-on" flag in > > ACPI GTDT. > > > > Contributed-under: TianoCore Contribution Agreement 1.1 > > Signed-off-by: Jason Zhang <zhangjinsong2@huawei.com> > > Signed-off-by: Heyi Guo <heyi.guo@linaro.org> > > Cc: Ard Biesheuvel <ard.biesheuvel@linaro.org> > > Cc: Leif Lindholm <leif.lindholm@linaro.org> > > Cc: Graeme Gregory <graeme.gregory@linaro.org> > > --- > > Silicon/Hisilicon/Hi1610/Hi1610AcpiTables/Gtdt.aslc | 3 ++- > > Silicon/Hisilicon/Hi1616/D05AcpiTables/Gtdt.aslc | 2 +- > > 2 files changed, 3 insertions(+), 2 deletions(-) > > this is for edk2-platforms, isn't it? > > If so, next time please add "edk2-platforms" to the subject prefix, as in: > > [PATCH edk2-platforms] > > or > > [edk2-platforms PATCH] > > Thanks! > Laszlo _______________________________________________ edk2-devel mailing list edk2-devel@lists.01.org https://lists.01.org/mailman/listinfo/edk2-devel
diff --git a/Silicon/Hisilicon/Hi1610/Hi1610AcpiTables/Gtdt.aslc b/Silicon/Hisilicon/Hi1610/Hi1610AcpiTables/Gtdt.aslc index 4c1050ae83b9..3feb99e88c88 100644 --- a/Silicon/Hisilicon/Hi1610/Hi1610AcpiTables/Gtdt.aslc +++ b/Silicon/Hisilicon/Hi1610/Hi1610AcpiTables/Gtdt.aslc @@ -40,8 +40,9 @@ #define GTDT_TIMER_LEVEL_TRIGGERED 0 #define GTDT_TIMER_ACTIVE_LOW EFI_ACPI_6_1_GTDT_TIMER_FLAG_TIMER_INTERRUPT_POLARITY #define GTDT_TIMER_ACTIVE_HIGH 0 +#define GTDT_TIMER_ALWAYS_ON_CAPABILITY EFI_ACPI_6_1_GTDT_TIMER_FLAG_ALWAYS_ON_CAPABILITY -#define GTDT_GTIMER_FLAGS (GTDT_TIMER_ACTIVE_LOW | GTDT_TIMER_LEVEL_TRIGGERED) +#define GTDT_GTIMER_FLAGS (GTDT_TIMER_ALWAYS_ON_CAPABILITY | GTDT_TIMER_ACTIVE_LOW | GTDT_TIMER_LEVEL_TRIGGERED) #pragma pack (1) diff --git a/Silicon/Hisilicon/Hi1616/D05AcpiTables/Gtdt.aslc b/Silicon/Hisilicon/Hi1616/D05AcpiTables/Gtdt.aslc index 16e2c6a972ba..2a9d209c00f0 100644 --- a/Silicon/Hisilicon/Hi1616/D05AcpiTables/Gtdt.aslc +++ b/Silicon/Hisilicon/Hi1616/D05AcpiTables/Gtdt.aslc @@ -28,7 +28,7 @@ #define GTDT_TIMER_ACTIVE_HIGH 0 #define GTDT_TIMER_ALWAYS_ON_CAPABILITY EFI_ACPI_6_1_GTDT_TIMER_FLAG_ALWAYS_ON_CAPABILITY -#define GTDT_GTIMER_FLAGS (GTDT_TIMER_ACTIVE_LOW | GTDT_TIMER_LEVEL_TRIGGERED) +#define GTDT_GTIMER_FLAGS (GTDT_TIMER_ALWAYS_ON_CAPABILITY | GTDT_TIMER_ACTIVE_LOW | GTDT_TIMER_LEVEL_TRIGGERED) #pragma pack (1)