diff mbox series

[2/7] ARM: LTO: avoid THUMB2_KERNEL+LTO

Message ID 20180220215954.4092811-3-arnd@arndb.de
State New
Headers show
Series ARM: hacks for link-time optimization | expand

Commit Message

Arnd Bergmann Feb. 20, 2018, 9:59 p.m. UTC 
Trying to build an LTO-Enabled kernel with Thumb2 instructions failed
horribly for me, with an endless output of things like

ccVnNycO.s:2665: Error: thumb conditional instruction should be in IT block -- `bxne lr'
ccVnNycO.s:7128: Error: thumb conditional instruction should be in IT block -- `strexeq r5,r2,[r3]'
ccVnNycO.s:7258: Error: thumb conditional instruction should be in IT block -- `strexeq lr,r0,[r3]'
ccVnNycO.s:17380: Error: thumb conditional instruction should be in IT block -- `strexeq r1,r2,[r6]'
ccVnNycO.s:19163: Error: thumb conditional instruction should be in IT block -- `strexeq r8,r6,[r3]'
ccVnNycO.s:22722: Error: thumb conditional instruction should be in IT block -- `strexeq r7,r1,[r0]'
ccVnNycO.s:24105: conditional infixes are deprecated in unified syntax
ccVnNycO.s:24105: Error: thumb conditional instruction should be in IT block -- `sbcccs r1,r1,r3'
ccVnNycO.s:24105: Error: thumb conditional instruction should be in IT block -- `movcc r3,#0'
ccVnNycO.s:24210: conditional infixes are deprecated in unified syntax
ccVnNycO.s:24210: Error: thumb conditional instruction should be in IT block -- `sbcccs r2,r2,r3'
ccVnNycO.s:24210: Error: thumb conditional instruction should be in IT block -- `movcc r3,#0'

I did not investigate this too much, disabling Thumb2 support when LTO is
set lets me build randconfig kernels.

Since ARM_SINGLE_ARMV7M is Thumb2-only, I have to disallow LTO for V7-M
targets.

Signed-off-by: Arnd Bergmann <arnd@arndb.de>

---
 arch/arm/Kconfig | 3 ++-
 1 file changed, 2 insertions(+), 1 deletion(-)

-- 
2.9.0

Comments

Nicolas Pitre Feb. 21, 2018, 3:12 a.m. UTC | #1 
On Tue, 20 Feb 2018, Arnd Bergmann wrote:

> Trying to build an LTO-Enabled kernel with Thumb2 instructions failed

> horribly for me, with an endless output of things like

> 

> ccVnNycO.s:2665: Error: thumb conditional instruction should be in IT block -- `bxne lr'

> ccVnNycO.s:7128: Error: thumb conditional instruction should be in IT block -- `strexeq r5,r2,[r3]'

> ccVnNycO.s:7258: Error: thumb conditional instruction should be in IT block -- `strexeq lr,r0,[r3]'

> ccVnNycO.s:17380: Error: thumb conditional instruction should be in IT block -- `strexeq r1,r2,[r6]'

> ccVnNycO.s:19163: Error: thumb conditional instruction should be in IT block -- `strexeq r8,r6,[r3]'

> ccVnNycO.s:22722: Error: thumb conditional instruction should be in IT block -- `strexeq r7,r1,[r0]'

> ccVnNycO.s:24105: conditional infixes are deprecated in unified syntax

> ccVnNycO.s:24105: Error: thumb conditional instruction should be in IT block -- `sbcccs r1,r1,r3'

> ccVnNycO.s:24105: Error: thumb conditional instruction should be in IT block -- `movcc r3,#0'

> ccVnNycO.s:24210: conditional infixes are deprecated in unified syntax

> ccVnNycO.s:24210: Error: thumb conditional instruction should be in IT block -- `sbcccs r2,r2,r3'

> ccVnNycO.s:24210: Error: thumb conditional instruction should be in IT block -- `movcc r3,#0'

> 

> I did not investigate this too much, disabling Thumb2 support when LTO is

> set lets me build randconfig kernels.

> 

> Since ARM_SINGLE_ARMV7M is Thumb2-only, I have to disallow LTO for V7-M

> targets.


Here's the workaround I sent you on January 2rd:

----- >*
#!/bin/bash

# work around https://gcc.gnu.org/bugzilla/show_bug.cgi?id=78353

GCC_ROOT=/opt/gcc-linaro-6.3.1-2017.05-x86_64_arm-linux-gnueabihf

set -e
set -x

cd $GCC_ROOT//arm-linux-gnueabihf/bin
[ -e fat-as ] && exit 1
mv as fat-as
cat > as << EOF
#!/bin/bash
exec -a "\$0" "\$(dirname "\$0")/fat-as" -mimplicit-it=always "\$@"
EOF
chmod +x as
----- >8


Nicolas
Arnd Bergmann Feb. 21, 2018, 11:48 a.m. UTC | #2 
On Wed, Feb 21, 2018 at 4:12 AM, Nicolas Pitre <nicolas.pitre@linaro.org> wrote:
> On Tue, 20 Feb 2018, Arnd Bergmann wrote:

>

>> Trying to build an LTO-Enabled kernel with Thumb2 instructions failed

>> horribly for me, with an endless output of things like

>>

>> ccVnNycO.s:2665: Error: thumb conditional instruction should be in IT block -- `bxne lr'

>> ccVnNycO.s:7128: Error: thumb conditional instruction should be in IT block -- `strexeq r5,r2,[r3]'

>> ccVnNycO.s:7258: Error: thumb conditional instruction should be in IT block -- `strexeq lr,r0,[r3]'

>> ccVnNycO.s:17380: Error: thumb conditional instruction should be in IT block -- `strexeq r1,r2,[r6]'

>> ccVnNycO.s:19163: Error: thumb conditional instruction should be in IT block -- `strexeq r8,r6,[r3]'

>> ccVnNycO.s:22722: Error: thumb conditional instruction should be in IT block -- `strexeq r7,r1,[r0]'

>> ccVnNycO.s:24105: conditional infixes are deprecated in unified syntax

>> ccVnNycO.s:24105: Error: thumb conditional instruction should be in IT block -- `sbcccs r1,r1,r3'

>> ccVnNycO.s:24105: Error: thumb conditional instruction should be in IT block -- `movcc r3,#0'

>> ccVnNycO.s:24210: conditional infixes are deprecated in unified syntax

>> ccVnNycO.s:24210: Error: thumb conditional instruction should be in IT block -- `sbcccs r2,r2,r3'

>> ccVnNycO.s:24210: Error: thumb conditional instruction should be in IT block -- `movcc r3,#0'

>>

>> I did not investigate this too much, disabling Thumb2 support when LTO is

>> set lets me build randconfig kernels.

>>

>> Since ARM_SINGLE_ARMV7M is Thumb2-only, I have to disallow LTO for V7-M

>> targets.

>

> Here's the workaround I sent you on January 2rd:


Hmm, I thought I had applied that correctly but looking again now I
must have overwritten
the assembler when I reinstalled the toolchain from source to get a
fixed version of the
compiler.

       Arnd
Matthias Kaehlcke March 7, 2018, 6:30 p.m. UTC | #3 
El Tue, Feb 20, 2018 at 10:59:49PM +0100 Arnd Bergmann ha dit:

> Trying to build an LTO-Enabled kernel with Thumb2 instructions failed

> horribly for me, with an endless output of things like

> 

> ccVnNycO.s:2665: Error: thumb conditional instruction should be in IT block -- `bxne lr'

> ccVnNycO.s:7128: Error: thumb conditional instruction should be in IT block -- `strexeq r5,r2,[r3]'

> ccVnNycO.s:7258: Error: thumb conditional instruction should be in IT block -- `strexeq lr,r0,[r3]'

> ccVnNycO.s:17380: Error: thumb conditional instruction should be in IT block -- `strexeq r1,r2,[r6]'

> ccVnNycO.s:19163: Error: thumb conditional instruction should be in IT block -- `strexeq r8,r6,[r3]'

> ccVnNycO.s:22722: Error: thumb conditional instruction should be in IT block -- `strexeq r7,r1,[r0]'

> ccVnNycO.s:24105: conditional infixes are deprecated in unified syntax

> ccVnNycO.s:24105: Error: thumb conditional instruction should be in IT block -- `sbcccs r1,r1,r3'

> ccVnNycO.s:24105: Error: thumb conditional instruction should be in IT block -- `movcc r3,#0'

> ccVnNycO.s:24210: conditional infixes are deprecated in unified syntax

> ccVnNycO.s:24210: Error: thumb conditional instruction should be in IT block -- `sbcccs r2,r2,r3'

> ccVnNycO.s:24210: Error: thumb conditional instruction should be in IT block -- `movcc r3,#0'


For the record:

The errors about sbcccs and movcc probably stem from here:

/* We use 33-bit arithmetic here... */
#define __range_ok(addr, size) ({ \
        unsigned long flag, roksum; \
        __chk_user_ptr(addr);   \
        __asm__("adds %1, %2, %3; sbcccs %1, %1, %0; movcc %0, #0" \
                : "=&r" (flag), "=&r" (roksum) \
                : "r" (addr), "Ir" (size), "0" (current_thread_info()->addr_limit) \
                : "cc"); \
        flag; })

arch/arm/include/asm/uaccess.h

I stumbled across this when trying to build a 32-bit ARM kernel with
clang. This post has some more information:

https://lists.linuxfoundation.org/pipermail/llvmlinux/2012-November/000073.html

"This is a problem with the above Linux inline ASM code, not with Clang,
nor with gas. It appears the new "Unified syntax" for ARM ASM code now
used by gas doesn't allow the use of conditional infixes anymore (the CC
part)."

Unfortunately I'm probably not fluent enough with ARM inline assembly
to come up with a good alternative.

Matthias

> I did not investigate this too much, disabling Thumb2 support when LTO is

> set lets me build randconfig kernels.

> 

> Since ARM_SINGLE_ARMV7M is Thumb2-only, I have to disallow LTO for V7-M

> targets.

> 

> Signed-off-by: Arnd Bergmann <arnd@arndb.de>

> ---

>  arch/arm/Kconfig | 3 ++-

>  1 file changed, 2 insertions(+), 1 deletion(-)

> 

> diff --git a/arch/arm/Kconfig b/arch/arm/Kconfig

> index 8ed0f664f86f..fbf2c3ab9a97 100644

> --- a/arch/arm/Kconfig

> +++ b/arch/arm/Kconfig

> @@ -18,7 +18,7 @@ config ARM

>  	select ARCH_OPTIONAL_KERNEL_RWX if ARCH_HAS_STRICT_KERNEL_RWX

>  	select ARCH_OPTIONAL_KERNEL_RWX_DEFAULT if CPU_V7

>  	select ARCH_SUPPORTS_ATOMIC_RMW

> -	select ARCH_SUPPORTS_LTO

> +	select ARCH_SUPPORTS_LTO if !ARM_SINGLE_ARMV7M

>  	select ARCH_USE_BUILTIN_BSWAP

>  	select ARCH_USE_CMPXCHG_LOCKREF

>  	select ARCH_WANT_IPC_PARSE_VERSION

> @@ -1533,6 +1533,7 @@ config SCHED_HRTICK

>  config THUMB2_KERNEL

>  	bool "Compile the kernel in Thumb-2 mode" if !CPU_THUMBONLY

>  	depends on (CPU_V7 || CPU_V7M) && !CPU_V6 && !CPU_V6K

> +	depends on !LTO

>  	default y if CPU_THUMBONLY

>  	select ARM_UNWIND

>  	help
Nicolas Pitre March 7, 2018, 6:52 p.m. UTC | #4 
On Wed, 7 Mar 2018, Matthias Kaehlcke wrote:

> El Tue, Feb 20, 2018 at 10:59:49PM +0100 Arnd Bergmann ha dit:

> 

> > Trying to build an LTO-Enabled kernel with Thumb2 instructions failed

> > horribly for me, with an endless output of things like

> > 

> > ccVnNycO.s:2665: Error: thumb conditional instruction should be in IT block -- `bxne lr'

> > ccVnNycO.s:7128: Error: thumb conditional instruction should be in IT block -- `strexeq r5,r2,[r3]'

> > ccVnNycO.s:7258: Error: thumb conditional instruction should be in IT block -- `strexeq lr,r0,[r3]'

> > ccVnNycO.s:17380: Error: thumb conditional instruction should be in IT block -- `strexeq r1,r2,[r6]'

> > ccVnNycO.s:19163: Error: thumb conditional instruction should be in IT block -- `strexeq r8,r6,[r3]'

> > ccVnNycO.s:22722: Error: thumb conditional instruction should be in IT block -- `strexeq r7,r1,[r0]'

> > ccVnNycO.s:24105: conditional infixes are deprecated in unified syntax

> > ccVnNycO.s:24105: Error: thumb conditional instruction should be in IT block -- `sbcccs r1,r1,r3'

> > ccVnNycO.s:24105: Error: thumb conditional instruction should be in IT block -- `movcc r3,#0'

> > ccVnNycO.s:24210: conditional infixes are deprecated in unified syntax

> > ccVnNycO.s:24210: Error: thumb conditional instruction should be in IT block -- `sbcccs r2,r2,r3'

> > ccVnNycO.s:24210: Error: thumb conditional instruction should be in IT block -- `movcc r3,#0'

> 

> For the record:

> 

> The errors about sbcccs and movcc probably stem from here:

> 

> /* We use 33-bit arithmetic here... */

> #define __range_ok(addr, size) ({ \

>         unsigned long flag, roksum; \

>         __chk_user_ptr(addr);   \

>         __asm__("adds %1, %2, %3; sbcccs %1, %1, %0; movcc %0, #0" \

>                 : "=&r" (flag), "=&r" (roksum) \

>                 : "r" (addr), "Ir" (size), "0" (current_thread_info()->addr_limit) \

>                 : "cc"); \

>         flag; })

> 

> arch/arm/include/asm/uaccess.h

> 

> I stumbled across this when trying to build a 32-bit ARM kernel with

> clang.


You have to tell clang to pass -mno-warn-deprecated to gas. That's what 
the gcc build currently does.

In this particular case with LTO, the same trick as done for 
-mimplicit-it=always would do it to work around 
https://gcc.gnu.org/bugzilla/show_bug.cgi?id=78353.


Nicolas
diff mbox series

Patch

diff --git a/arch/arm/Kconfig b/arch/arm/Kconfig
index 8ed0f664f86f..fbf2c3ab9a97 100644
--- a/arch/arm/Kconfig
+++ b/arch/arm/Kconfig
@@ -18,7 +18,7 @@  config ARM
 	select ARCH_OPTIONAL_KERNEL_RWX if ARCH_HAS_STRICT_KERNEL_RWX
 	select ARCH_OPTIONAL_KERNEL_RWX_DEFAULT if CPU_V7
 	select ARCH_SUPPORTS_ATOMIC_RMW
-	select ARCH_SUPPORTS_LTO
+	select ARCH_SUPPORTS_LTO if !ARM_SINGLE_ARMV7M
 	select ARCH_USE_BUILTIN_BSWAP
 	select ARCH_USE_CMPXCHG_LOCKREF
 	select ARCH_WANT_IPC_PARSE_VERSION
@@ -1533,6 +1533,7 @@  config SCHED_HRTICK
 config THUMB2_KERNEL
 	bool "Compile the kernel in Thumb-2 mode" if !CPU_THUMBONLY
 	depends on (CPU_V7 || CPU_V7M) && !CPU_V6 && !CPU_V6K
+	depends on !LTO
 	default y if CPU_THUMBONLY
 	select ARM_UNWIND
 	help