| Message ID | 20180223154052.9828-1-ard.biesheuvel@linaro.org |
|---|---|
| Headers | show |
| Series | Add Secure96 mezzanine support | expand |
On Fri, Feb 23, 2018 at 03:40:46PM +0000, Ard Biesheuvel wrote: > This v3 (as did v2) implements a complete split between the generic > 96boards LS connector support and its associated plumbing (defining which > I2C, SPI and GPIO controllers are connected) on the one hand, and support > for the Secure96 mezzanine board in particular on the other. More > specifically, all Secure96 PCDs were dropped, and the only platform > specific configuration that remains is including the Secure96 driver > and the driver for its peripherals to the build. > > v3: > - The ATSHA204A driver has been merged, so it has been dropped from this > series. > - Rename Platform/NinetySixBoards back to Platform/96Boards. Note that in > some places, using leading digits is problematic so the string does still > occur in a couple of places. > - Rebase onto EDK2 that has the MultiPhase.h VFR changes. All of my feedback has been addressed, so for the series: Reviewed-by: Leif Lindholm <leif.lindholm@linaro.org> If we get enum support in VfrCompile in the future, a minor cleanup to the code introduced by 5/6 will be possible, but this is an excellent start to a generic mezzanine infrastructure - thanks! _______________________________________________ edk2-devel mailing list edk2-devel@lists.01.org https://lists.01.org/mailman/listinfo/edk2-devel
On 23 February 2018 at 15:56, Leif Lindholm <leif.lindholm@linaro.org> wrote: > On Fri, Feb 23, 2018 at 03:40:46PM +0000, Ard Biesheuvel wrote: >> This v3 (as did v2) implements a complete split between the generic >> 96boards LS connector support and its associated plumbing (defining which >> I2C, SPI and GPIO controllers are connected) on the one hand, and support >> for the Secure96 mezzanine board in particular on the other. More >> specifically, all Secure96 PCDs were dropped, and the only platform >> specific configuration that remains is including the Secure96 driver >> and the driver for its peripherals to the build. >> >> v3: >> - The ATSHA204A driver has been merged, so it has been dropped from this >> series. >> - Rename Platform/NinetySixBoards back to Platform/96Boards. Note that in >> some places, using leading digits is problematic so the string does still >> occur in a couple of places. >> - Rebase onto EDK2 that has the MultiPhase.h VFR changes. > > All of my feedback has been addressed, so for the series: > Reviewed-by: Leif Lindholm <leif.lindholm@linaro.org> > > If we get enum support in VfrCompile in the future, a minor cleanup to > the code introduced by 5/6 will be possible, but this is an excellent > start to a generic mezzanine infrastructure - thanks! Thank you Pushed as 487015fb23c1..d8e4d4565841 _______________________________________________ edk2-devel mailing list edk2-devel@lists.01.org https://lists.01.org/mailman/listinfo/edk2-devel