| Message ID | 20180222162420.2825703-1-arnd@arndb.de |
|---|---|
| State | New |
| Headers | show |
| Series | drm/p[111: add CONFIG_OF dependency | expand |
Arnd Bergmann <arnd@arndb.de> writes: > We cannot select a symbol without meeting its other dependencies: > > warning: (DRM_PL111) selects DRM_DUMB_VGA_DAC which has unmet direct dependencies (HAS_IOMEM && DRM && DRM_BRIDGE && OF) > drivers/gpu/drm/bridge/dumb-vga-dac.c: In function 'dumb_vga_probe': > drivers/gpu/drm/bridge/dumb-vga-dac.c:207:13: error: 'struct drm_bridge' has no member named 'of_node' > vga->bridge.of_node = pdev->dev.of_node; > ^ > > Here it seems reasonable to depend on CONFIG_OF, as all platforms > using this driver already require that anyway. Looks like we'll be going with https://patchwork.freedesktop.org/patch/205580/
On Thu, Feb 22, 2018 at 9:08 PM, Eric Anholt <eric@anholt.net> wrote: > Arnd Bergmann <arnd@arndb.de> writes: > >> We cannot select a symbol without meeting its other dependencies: >> >> warning: (DRM_PL111) selects DRM_DUMB_VGA_DAC which has unmet direct dependencies (HAS_IOMEM && DRM && DRM_BRIDGE && OF) >> drivers/gpu/drm/bridge/dumb-vga-dac.c: In function 'dumb_vga_probe': >> drivers/gpu/drm/bridge/dumb-vga-dac.c:207:13: error: 'struct drm_bridge' has no member named 'of_node' >> vga->bridge.of_node = pdev->dev.of_node; >> ^ >> >> Here it seems reasonable to depend on CONFIG_OF, as all platforms >> using this driver already require that anyway. > > Looks like we'll be going with > > https://patchwork.freedesktop.org/patch/205580/ Ok, even better! Arnd
diff --git a/drivers/gpu/drm/pl111/Kconfig b/drivers/gpu/drm/pl111/Kconfig index 82cb3e60ddc8..776448e8d4ee 100644 --- a/drivers/gpu/drm/pl111/Kconfig +++ b/drivers/gpu/drm/pl111/Kconfig @@ -3,6 +3,7 @@ config DRM_PL111 depends on DRM depends on ARM || ARM64 || COMPILE_TEST depends on COMMON_CLK + depends on OF select DRM_KMS_HELPER select DRM_KMS_CMA_HELPER select DRM_GEM_CMA_HELPER
We cannot select a symbol without meeting its other dependencies: warning: (DRM_PL111) selects DRM_DUMB_VGA_DAC which has unmet direct dependencies (HAS_IOMEM && DRM && DRM_BRIDGE && OF) drivers/gpu/drm/bridge/dumb-vga-dac.c: In function 'dumb_vga_probe': drivers/gpu/drm/bridge/dumb-vga-dac.c:207:13: error: 'struct drm_bridge' has no member named 'of_node' vga->bridge.of_node = pdev->dev.of_node; ^ Here it seems reasonable to depend on CONFIG_OF, as all platforms using this driver already require that anyway. Fixes: 49f81d80ab84 ("drm/pl111: Support handling bridge timings") Signed-off-by: Arnd Bergmann <arnd@arndb.de> --- drivers/gpu/drm/pl111/Kconfig | 1 + 1 file changed, 1 insertion(+) -- 2.9.0