| Message ID | 20180206125806.19350-16-kishon@ti.com |
|---|---|
| State | New |
| Headers | show |
| Series | None | expand |
Kishon, On Tuesday 06 February 2018 06:28 PM, Kishon Vijay Abraham I wrote: > Add UHS/HS200/DDR speed mode capability to MMC1 and MMC2 dt nodes. > > Signed-off-by: Kishon Vijay Abraham I <kishon@ti.com> Along with this, dont we need to have /delete-property/ mmc-hs200-1_8v; for eMMC on Beagle x15 which does not support HS200? Or are you planning to depend on lack of pinctrl entries for HS200 to take care of that? Thanks, Sekhar > --- > arch/arm/boot/dts/dra7.dtsi | 10 ++++++++++ > 1 file changed, 10 insertions(+) > > diff --git a/arch/arm/boot/dts/dra7.dtsi b/arch/arm/boot/dts/dra7.dtsi > index 7bf33d522b14..feb496e7c5ef 100644 > --- a/arch/arm/boot/dts/dra7.dtsi > +++ b/arch/arm/boot/dts/dra7.dtsi > @@ -1073,7 +1073,13 @@ > status = "disabled"; > pbias-supply = <&pbias_mmc_reg>; > max-frequency = <192000000>; > + sd-uhs-sdr104; > + sd-uhs-sdr50; > + sd-uhs-ddr50; > + sd-uhs-sdr25; > + sd-uhs-sdr12; > cap-sd-highspeed; > + mmc-ddr-1_8v; > cap-mmc-highspeed; > }; > > @@ -1092,6 +1098,10 @@ > status = "disabled"; > max-frequency = <192000000>; > cap-sd-highspeed; > + sd-uhs-sdr25; > + sd-uhs-sdr12; > + mmc-hs200-1_8v; > + mmc-ddr-1_8v; > cap-mmc-highspeed; > }; > > -- > 2.11.0 >
Hi, On Wednesday 07 February 2018 02:41 PM, Sekhar Nori wrote: > Kishon, > > On Tuesday 06 February 2018 06:28 PM, Kishon Vijay Abraham I wrote: >> Add UHS/HS200/DDR speed mode capability to MMC1 and MMC2 dt nodes. >> >> Signed-off-by: Kishon Vijay Abraham I <kishon@ti.com> > > Along with this, dont we need to have > > /delete-property/ mmc-hs200-1_8v; > > for eMMC on Beagle x15 which does not support HS200? > > Or are you planning to depend on lack of pinctrl entries for HS200 to > take care of that? right now it relies on lack of pinctrl entries but I think adding delete property is appropriate. Actually I missed porting the patch that adds /delete-property/. Thanks Kishon > > Thanks, > Sekhar > > >> --- >> arch/arm/boot/dts/dra7.dtsi | 10 ++++++++++ >> 1 file changed, 10 insertions(+) >> >> diff --git a/arch/arm/boot/dts/dra7.dtsi b/arch/arm/boot/dts/dra7.dtsi >> index 7bf33d522b14..feb496e7c5ef 100644 >> --- a/arch/arm/boot/dts/dra7.dtsi >> +++ b/arch/arm/boot/dts/dra7.dtsi >> @@ -1073,7 +1073,13 @@ >> status = "disabled"; >> pbias-supply = <&pbias_mmc_reg>; >> max-frequency = <192000000>; >> + sd-uhs-sdr104; >> + sd-uhs-sdr50; >> + sd-uhs-ddr50; >> + sd-uhs-sdr25; >> + sd-uhs-sdr12; >> cap-sd-highspeed; >> + mmc-ddr-1_8v; >> cap-mmc-highspeed; >> }; >> >> @@ -1092,6 +1098,10 @@ >> status = "disabled"; >> max-frequency = <192000000>; >> cap-sd-highspeed; >> + sd-uhs-sdr25; >> + sd-uhs-sdr12; >> + mmc-hs200-1_8v; >> + mmc-ddr-1_8v; >> cap-mmc-highspeed; >> }; >> >> -- >> 2.11.0 >> >
* Sekhar Nori <nsekhar@ti.com> [180213 11:11]: > On Wednesday 07 February 2018 02:51 PM, Kishon Vijay Abraham I wrote: > > Hi, > > > > On Wednesday 07 February 2018 02:41 PM, Sekhar Nori wrote: > >> Kishon, > >> > >> On Tuesday 06 February 2018 06:28 PM, Kishon Vijay Abraham I wrote: > >>> Add UHS/HS200/DDR speed mode capability to MMC1 and MMC2 dt nodes. > >>> > >>> Signed-off-by: Kishon Vijay Abraham I <kishon@ti.com> > >> > >> Along with this, dont we need to have > >> > >> /delete-property/ mmc-hs200-1_8v; > >> > >> for eMMC on Beagle x15 which does not support HS200? > >> > >> Or are you planning to depend on lack of pinctrl entries for HS200 to > >> take care of that? > > > > right now it relies on lack of pinctrl entries but I think adding delete > > property is appropriate. Actually I missed porting the patch that adds > > /delete-property/. > > Actually, thinking more, this should be probably be handled using > "no-1-8-v" property. Reading the comment above SDHCI_QUIRK2_NO_1_8_V, it > is specifically meant for the case when system (board) does not support > 1.8V even when host (controller) does. Which is exactly the case with > Beagle x15. OK so that seems to be related to the last patch. I've applied the first two defconfig patches into omap-for-v4.17/defconfig and patches up to patch 13/15 into omap-for-v4.17/dt-sdhci. Kishon, please repost the missing changes or ping me when the driver dependencies have cleared for further patches to be applied to enable sdhci. Regards, Tony
diff --git a/arch/arm/boot/dts/dra7.dtsi b/arch/arm/boot/dts/dra7.dtsi index 7bf33d522b14..feb496e7c5ef 100644 --- a/arch/arm/boot/dts/dra7.dtsi +++ b/arch/arm/boot/dts/dra7.dtsi @@ -1073,7 +1073,13 @@ status = "disabled"; pbias-supply = <&pbias_mmc_reg>; max-frequency = <192000000>; + sd-uhs-sdr104; + sd-uhs-sdr50; + sd-uhs-ddr50; + sd-uhs-sdr25; + sd-uhs-sdr12; cap-sd-highspeed; + mmc-ddr-1_8v; cap-mmc-highspeed; }; @@ -1092,6 +1098,10 @@ status = "disabled"; max-frequency = <192000000>; cap-sd-highspeed; + sd-uhs-sdr25; + sd-uhs-sdr12; + mmc-hs200-1_8v; + mmc-ddr-1_8v; cap-mmc-highspeed; };
Add UHS/HS200/DDR speed mode capability to MMC1 and MMC2 dt nodes. Signed-off-by: Kishon Vijay Abraham I <kishon@ti.com> --- arch/arm/boot/dts/dra7.dtsi | 10 ++++++++++ 1 file changed, 10 insertions(+) -- 2.11.0